Skip to content

Commit b9fabd4

Browse files
authored
feat: Use mini require (#4845)
Merge pull request #4845 from ajaxorg/use-mini_require
2 parents 922a50e + 30ea87e commit b9fabd4

File tree

10 files changed

+806
-2164
lines changed

10 files changed

+806
-2164
lines changed

Makefile.dryice.js

+13-2
Original file line numberDiff line numberDiff line change
@@ -346,7 +346,7 @@ function buildAceModuleInternal(opts, callback) {
346346
ignore: opts.ignore || [],
347347
withRequire: false,
348348
basepath: ACE_HOME,
349-
transforms: [normalizeLineEndings],
349+
transforms: [normalizeLineEndings, includeLoader],
350350
afterRead: [optimizeTextModules]
351351
}, write);
352352
}
@@ -358,7 +358,7 @@ function buildCore(options, extra, callback) {
358358
order: -1000,
359359
literal: true
360360
}];
361-
options.require =["ace/ace"];
361+
options.require =["ace/ace", "ace/loader_build"];
362362
options.projectType = "main";
363363
options.ns = "ace";
364364
buildAceModule(options, callback);
@@ -583,6 +583,17 @@ function normalizeLineEndings(module) {
583583
return module.source = module.source.replace(/\r\n/g, "\n");
584584
}
585585

586+
function includeLoader(module) {
587+
var pattern = '"include loader_build";';
588+
if (module.source && module.source.indexOf(pattern) != -1) {
589+
console.log("===================================== =====================================");
590+
console.log(module);
591+
console.log("===================================== =====================================");
592+
module.deps.push("ace/loader_build");
593+
module.source = module.source.replace(pattern, 'require("./loader_build")(exports)');
594+
}
595+
}
596+
586597
function optimizeTextModules(sources) {
587598
var textModules = {};
588599
return sources.filter(function(pkg) {

demo/kitchen-sink/demo.js

+6-3
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,6 @@
3232
define(function(require, exports, module) {
3333
"use strict";
3434

35-
require("ace/lib/fixoldbrowsers");
36-
3735
require("ace/ext/rtl");
3836

3937
require("ace/multi_select");
@@ -42,7 +40,12 @@ var devUtil = require("./dev_util");
4240
require("./file_drop");
4341

4442
var config = require("ace/config");
45-
config.init();
43+
config.setLoader(function(moduleName, cb) {
44+
require([moduleName], function(module) {
45+
cb(null, module)
46+
})
47+
});
48+
4649
var env = {};
4750

4851
var dom = require("ace/lib/dom");

demo/kitchen-sink/dev_util.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
* ***** END LICENSE BLOCK ***** */
3030

3131
define(function(require, exports, module) {
32+
var ace = require("ace/ace");
3233
var dom = require("ace/lib/dom");
3334
var event = require("ace/lib/event");
3435
var Range = require("ace/range").Range;
@@ -48,7 +49,7 @@ function def(o, key, get) {
4849
console.error(e);
4950
}
5051
}
51-
def(window, "ace", function(){ return window.env.editor });
52+
def(window, "ace", function(){ return ace });
5253
def(window, "editor", function(){ return window.env.editor == logEditor ? editor : window.env.editor });
5354
def(window, "session", function(){ return window.editor.session });
5455
def(window, "split", function(){ return window.env.split });

0 commit comments

Comments
 (0)