Skip to content

Verify catalog in Java source acceptance test #9818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tuliren opened this issue Jan 26, 2022 · 1 comment · Fixed by #9862
Closed

Verify catalog in Java source acceptance test #9818

tuliren opened this issue Jan 26, 2022 · 1 comment · Fixed by #9862
Assignees
@tuliren
Labels
type/enhancement New feature or request
Milestone
ConnCore Feb 2

Comments

@tuliren
Copy link
Contributor

tuliren commented Jan 26, 2022

The Java source acceptance test currently does not do any validation on the catalog other than null checking:
https://github.com/airbytehq/airbyte/blob/master/airbyte-integrations/bases/standard-source-test/src/main/java/io/airbyte/integrations/standardtest/source/SourceAcceptanceTest.java#L149
@tuliren tuliren added the type/enhancement New feature or request label Jan 26, 2022
@tuliren tuliren self-assigned this Jan 26, 2022
@tuliren
Copy link
Contributor Author

tuliren commented Jan 26, 2022

This should be a quick fix.

This was referenced Jan 26, 2022
Merged
Merged
@tuliren tuliren added this to the ConnCore Feb 2 milestone Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tuliren tuliren

Labels
type/enhancement New feature or request
Projects
None yet
Milestone
ConnCore Feb 2
Development

Successfully merging a pull request may close this issue.

Verify source redshift schema selection in tests airbytehq/airbyte
1 participant
@tuliren