Skip to content

Source FB Marketing: Deprecate the Insights Days per job parameter #8027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sherifnada opened this issue Nov 16, 2021 · 2 comments
Closed

Source FB Marketing: Deprecate the Insights Days per job parameter #8027

sherifnada opened this issue Nov 16, 2021 · 2 comments
Assignees
@bazarnov
Labels
area/connectors Connector related issues connectors/source/facebook-marketing connectors/sources-api type/enhancement New feature or request UX

Comments

@sherifnada
Copy link
Contributor

sherifnada commented Nov 16, 2021 •
edited
Loading

Tell us about the problem you're trying to solve

A question from a user:

For the Facebook Marketing API, how do I know if I have a lot of data? Put another way, how could I spot if I have too much data for a given time period and thus calibrate my time period to suit the size of my data?

image

IMO exposing this option was a tactical error on our part. Like described in our new UX handbook, input configuration like this is an implementation detail and should not be offloaded to the user. We should just remove it and use the default value of 1.

Acceptance Criteria

  1. option is removed from spec.json (in a backwards compatible way)
  2. a sensible value is chosen by default
@sherifnada sherifnada added type/enhancement New feature or request area/connectors Connector related issues UX labels Nov 16, 2021
@bazarnov bazarnov self-assigned this Nov 24, 2021
@bazarnov bazarnov mentioned this issue Nov 24, 2021
Closed
14 tasks
@bazarnov bazarnov linked a pull request Nov 24, 2021 that will close this issue
🐛 Source FB Marketing: deprecate INSIGHTS_DAYS_PER_JOB from connector's specification. #8234
Closed
14 tasks
@oustynova oustynova moved this to On hold in GL Roadmap Dec 17, 2021
@misteryeo
Copy link
Contributor

Adding this comment for visibility - PR is ready to be merged but pending #8385

@bazarnov bazarnov moved this from On hold to Done in GL Roadmap Jan 19, 2022
@bazarnov
Copy link
Collaborator

Closed due to: #8234 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bazarnov bazarnov

Labels
area/connectors Connector related issues connectors/source/facebook-marketing connectors/sources-api type/enhancement New feature or request UX
Projects
No open projects
GL Roadmap
Archived in project
Milestone
No milestone
4 participants
@sherifnada @karinakuz @misteryeo @bazarnov