Skip to content

feat: add enterprise connectors support and UI improvements #59741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

letiescanciano
Copy link
Contributor

Closes https://github.com/airbytehq/airbyte-internal-issues/issues/12793

What

  • Add enterprise connectors plugin and integration
  • Update connector registry to handle enterprise connectors
  • Improve connector table UI with better spacing and layout
  • Rename "OSS" column to "Self-managed" for clarity
  • Add enterprise tab to connector registry
  • Add enterprise support level display
  • Add flex layout for connector links

Screenshot 2025-05-09 at 08 33 59

This change improves the connector documentation by properly handling enterprise connectors and enhancing the UI for better readability.

How

  • Creating a plugin that will load enterprise connectors info based on their folder
  • The plugin is responsible for making this data available to the <ComponentRegistry/> component

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

- Add enterprise connectors plugin and integration
- Update connector registry to handle enterprise connectors
- Improve connector table UI with better spacing and layout
- Rename "OSS" column to "Self-managed" for clarity
- Add enterprise tab to connector registry
- Add enterprise support level display
- Fix github icon display condition
- Add flex layout for connector links

This change improves the connector documentation by properly handling
enterprise connectors and enhancing the UI for better readability.
Copy link

vercel bot commented May 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2025 6:46am


useEffect(() => {
fetchCatalog(REGISTRY_URL, setRegistry);
}, []);

useEffect(() => {
if (pluginData.enterpriseConnectors.length > 0 && registry.length > 0) {
const _connectors = pluginData.enterpriseConnectors
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ian-at-airbyte it seems that source-salesforce-marketing-cloud connector is not on the registry, so I can't fetch its info therefore is not currently being displayed in the new Enterprise tab.
Do you want me to add its information manually? or should it be included in the registry? not sure which team manages that

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be a question for @matteogp. I guess we could include it manually but I'm not exactly sure why it was excluded. Maybe intentional or just an oversight.

@ian-at-airbyte
Copy link
Contributor

This is looking great!

Sorry to do this to you but I have a last minute change. I was walking Alex through this and he asked for two things.

  • For all connectors: Add a Definition ID like the one in these tables. I was thinking this would be better in the metadata on the connector page, rather than in this summary table. I think this is the component: /docusaurus/src/components/HeaderDecoration.jsx.
  • For Enterprise connectors only: Hide the docker definition column (long story).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants