-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat: add enterprise connectors support and UI improvements #59741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- Add enterprise connectors plugin and integration - Update connector registry to handle enterprise connectors - Improve connector table UI with better spacing and layout - Rename "OSS" column to "Self-managed" for clarity - Add enterprise tab to connector registry - Add enterprise support level display - Fix github icon display condition - Add flex layout for connector links This change improves the connector documentation by properly handling enterprise connectors and enhancing the UI for better readability.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
||
useEffect(() => { | ||
fetchCatalog(REGISTRY_URL, setRegistry); | ||
}, []); | ||
|
||
useEffect(() => { | ||
if (pluginData.enterpriseConnectors.length > 0 && registry.length > 0) { | ||
const _connectors = pluginData.enterpriseConnectors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ian-at-airbyte it seems that source-salesforce-marketing-cloud
connector is not on the registry, so I can't fetch its info therefore is not currently being displayed in the new Enterprise tab.
Do you want me to add its information manually? or should it be included in the registry? not sure which team manages that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be a question for @matteogp. I guess we could include it manually but I'm not exactly sure why it was excluded. Maybe intentional or just an oversight.
This is looking great! Sorry to do this to you but I have a last minute change. I was walking Alex through this and he asked for two things.
|
Closes https://github.com/airbytehq/airbyte-internal-issues/issues/12793
What
This change improves the connector documentation by properly handling enterprise connectors and enhancing the UI for better readability.
How
<ComponentRegistry/>
componentUser Impact
Can this PR be safely reverted and rolled back?