Skip to content

DG-11678: Updated schema types for webflow actions task #59660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from

Conversation

blmayer
Copy link

@blmayer blmayer commented May 5, 2025

What

This PR improves error handling in the Webflow source connector, specifically in the schema parsing logic. It ensures that if a required field in a Webflow collection schema is not properly mapped, the connector will raise an exception instead of silently failing, making debugging and maintenance easier.

How

  • Updated the CollectionSchema.parse_response method to raise exceptions when encountering unmapped required fields, rather than swallowing the error.
  • Added logging for unmapped optional fields, so they can be reviewed without interrupting syncs.
  • Improved exception messages to include the problematic field type and guidance for updating the mapping.

Review guide

airbyte-integrations/connectors/source-webflow/source_webflow/source.py:
See the CollectionSchema.parse_response method for the main logic change.
Review logging and exception handling updates.

User Impact

  • Users will now receive clear errors if a required field in their Webflow collection is not supported by the connector, allowing for faster troubleshooting.
  • Optional fields that are not mapped will be logged but will not block syncs.
  • No breaking changes to configuration or usage.

Can this PR be safely reverted and rolled back?

[x] YES 💚
[ ] NO ❌

Copy link

vercel bot commented May 5, 2025

@blmayer is attempting to deploy a commit to the Airbyte Growth Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented May 5, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 3 committers have signed the CLA.

✅ blmayer
❌ Reregistered
❌ visaievamc
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-project-automation github-project-automation bot moved this from Backlog to Waiting Contributor in 🧑‍🏭 Community Pull Requests May 5, 2025
@marcosmarxm
Copy link
Member

@blmayer besides that, please make sure everyone in the commit list sign the CLA to continue the review process.

@marcosmarxm
Copy link
Member

@blmayer still need 2 members from your team to sign the CLA to continue the review process.

@blmayer blmayer closed this May 8, 2025
@github-project-automation github-project-automation bot moved this from Waiting Contributor to Done in 🧑‍🏭 Community Pull Requests May 8, 2025
@Reregistered Reregistered deleted the blmayer/webflow-actions branch May 8, 2025 16:24
@blmayer blmayer restored the blmayer/webflow-actions branch May 8, 2025 16:26
@blmayer blmayer deleted the blmayer/webflow-actions branch May 8, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

6 participants