-
Notifications
You must be signed in to change notification settings - Fork 4.5k
DG-11678: Updated schema types for webflow actions task #59660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…-pulling-commits-for-branch Source GitHub: Connector always pulls master branch commits
Update to latest
… fields, and update exception handling for required fields in CollectionSchema.
…s to object types with additional properties.
…ield for required checks
@blmayer is attempting to deploy a commit to the Airbyte Growth Team on Vercel. A member of the Team first needs to authorize it. |
|
airbyte-integrations/connectors/source-github/source_github/source.py
Outdated
Show resolved
Hide resolved
@blmayer besides that, please make sure everyone in the commit list sign the CLA to continue the review process. |
@blmayer still need 2 members from your team to sign the CLA to continue the review process. |
What
This PR improves error handling in the Webflow source connector, specifically in the schema parsing logic. It ensures that if a required field in a Webflow collection schema is not properly mapped, the connector will raise an exception instead of silently failing, making debugging and maintenance easier.
How
Review guide
airbyte-integrations/connectors/source-webflow/source_webflow/source.py:
See the CollectionSchema.parse_response method for the main logic change.
Review logging and exception handling updates.
User Impact
Can this PR be safely reverted and rolled back?
[x] YES 💚
[ ] NO ❌