Skip to content

feat(source-hubspot): incremental streams to low code: email_events, engagements, subscription_changes #58592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
May 9, 2025
Merged

feat(source-hubspot): incremental streams to low code: email_events, engagements, subscription_changes #58592

merged 23 commits into from
May 9, 2025
+2,025 −1,535

Conversation

darynaishchenko
Copy link
Collaborator

What

How

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@darynaishchenko darynaishchenko self-assigned this Apr 22, 2025
@darynaishchenko darynaishchenko requested a review from a team as a code owner April 22, 2025 16:41
@vercel Vercel
Copy link

vercel bot commented Apr 22, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2025 10:30am

@darynaishchenko darynaishchenko changed the title feat(source-hubspot): incremental streams to low code: contact_lists feat(source-hubspot): incremental streams to low code: contact_lists, email_events Apr 29, 2025
@darynaishchenko darynaishchenko changed the title feat(source-hubspot): incremental streams to low code: contact_lists, email_events feat(source-hubspot): incremental streams to low code: contact_lists, email_events, engagements Apr 30, 2025
@darynaishchenko darynaishchenko changed the title feat(source-hubspot): incremental streams to low code: contact_lists, email_events, engagements feat(source-hubspot): incremental streams to low code: contact_lists, email_events, engagements, subscription_changes Apr 30, 2025
@darynaishchenko
Copy link
Collaborator Author

regression tests:

test_catalog_are_the_same[failed] new fields added: is_file_based, additionalProperties
Contact lists job
record count 0 TestDataIntegrity.test_record_count_with_state for one connection(to investigate)
Can’t find the issue, tested locally, record count is the same.
Email events job
TestDataIntegrity.test_record_count_with_state for one connection: more records in target, records were added between reads.
Engagements job
TestDataIntegrity.test_record_count_with_state more records in target version
Subscription changes job
TestDataIntegrity.test_record_count_with_state fewer records in target version. Can’t find the issue, tested locally, record count is the same.

brianjlai
brianjlai reviewed May 6, 2025
View reviewed changes
Copy link
Contributor

@brianjlai brianjlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work on the engagements stream which is definitely on the trickier side. I did leave some comments around the contact_lists stream that I want to clarify before we move forward since this one may have some changes that impact users due to the switch from the v1 to v3 endpoint.

@darynaishchenko darynaishchenko requested a review from brianjlai May 7, 2025 14:50
@darynaishchenko darynaishchenko changed the title feat(source-hubspot): incremental streams to low code: contact_lists, email_events, engagements, subscription_changes feat(source-hubspot): incremental streams to low code: email_events, engagements, subscription_changes May 7, 2025
brianjlai
brianjlai approved these changes May 8, 2025
View reviewed changes
Copy link
Contributor

@brianjlai brianjlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thank you for the detailed explanation about the EngagementsHttpRequester. I thought about how we could try to define _use_recent_api when we instantiate the requester up front, but didn't see a good way since we need to know the start_time.

Either way, looks good with the latest regression test run. 🚢

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2025 •
edited
Loading

source-hubspot Connector Test Results

348 tests   348 ✅  5m 31s ⏱️
  2 suites    0 💤
  2 files      0 ❌

Results for commit e9ecb8b.

♻️ This comment has been updated with latest results.

@darynaishchenko
Copy link
Collaborator Author

darynaishchenko commented May 9, 2025 •
edited by github-actions bot
Loading

/format-fix

Format-fix job started... Check job output.

✅ Changes applied successfully. (404cf50)

@darynaishchenko darynaishchenko merged commit a88a90b into master May 9, 2025
35 checks passed
@darynaishchenko darynaishchenko deleted the daryna/source-hubspot/incremental-to-low-code branch May 9, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolik0 tolik0 tolik0 approved these changes

@brianjlai brianjlai brianjlai approved these changes

@pnilan pnilan Awaiting requested review from pnilan

Assignees

@darynaishchenko darynaishchenko

Labels
connectors/source/hubspot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@darynaishchenko @tolik0 @brianjlai @octavia-squidington-iii