Skip to content

[cdks, source-postgres, source-mysql, source-mongodb-v2] Fixing vulnerabilities in dependencies #58132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Apr 24, 2025
Merged

[cdks, source-postgres, source-mysql, source-mongodb-v2] Fixing vulnerabilities in dependencies #58132

merged 22 commits into from
Apr 24, 2025

Conversation

theyueli
Copy link
Contributor

@theyueli theyueli commented Apr 17, 2025 •
edited
Loading

What

Fixes https://github.com/airbytehq/airbyte-internal-issues/issues/12439

How

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@theyueli theyueli requested a review from wennergr April 17, 2025 22:59
@theyueli theyueli requested review from a team as code owners April 17, 2025 22:59
@vercel Vercel
Copy link

vercel bot commented Apr 17, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2025 7:42am

@theyueli
Copy link
Contributor Author

theyueli commented Apr 18, 2025 •
edited by github-actions bot
Loading

/bump-version type=patch changelog="Fix vulnerabilities in dependencies."

Bump Version job started... Check job output.

✅ Changes applied successfully. (bdc2df0)

@wennergr
Copy link
Contributor

Can we also include airbyte-source-mongodb-v2 here? It's a key priority for Optum

@theyueli
Copy link
Contributor Author

Can we also include airbyte-source-mongodb-v2 here? It's a key priority for Optum

Sure, I see MongoDB is flagged for mina-core from grype. I will include that as well.

@theyueli
Copy link
Contributor Author

theyueli commented Apr 24, 2025 •
edited by github-actions bot
Loading

/publish-java-cdk dry-run=false

🕑 https://github.com/airbytehq/airbyte/actions/runs/14635411025
✅ Successfully published Java CDK version=0.48.9!

@theyueli theyueli changed the title [source-postgres, source-mysql] Fixing vulnerabilities in dependencies [cdk, source-postgres, source-mysql] Fixing vulnerabilities in dependencies Apr 24, 2025
@theyueli theyueli changed the title [cdk, source-postgres, source-mysql] Fixing vulnerabilities in dependencies [cdk, source-postgres, source-mysql, source-mongodb-v2] Fixing vulnerabilities in dependencies Apr 24, 2025
@theyueli
Copy link
Contributor Author

Can we also include airbyte-source-mongodb-v2 here? It's a key priority for Optum

Sure, I see MongoDB is flagged for mina-core from grype. I will include that as well.

@wennergr now MongoDB has been included to receive the fix.

@theyueli theyueli self-assigned this Apr 24, 2025
@theyueli theyueli requested a review from rodireich April 24, 2025 07:16
@theyueli theyueli enabled auto-merge (squash) April 24, 2025 07:24
@theyueli theyueli changed the title [cdk, source-postgres, source-mysql, source-mongodb-v2] Fixing vulnerabilities in dependencies [cdks, source-postgres, source-mysql, source-mongodb-v2] Fixing vulnerabilities in dependencies Apr 24, 2025
rodireich
rodireich reviewed Apr 24, 2025
View reviewed changes
airbyte-cdk/java/airbyte-cdk/dependencies/build.gradle
@@ -30,7 +30,7 @@ dependencies {
api 'org.slf4j:slf4j-api:2.0.16'
api 'io.github.oshai:kotlin-logging-jvm:7.0.0'
api 'org.jetbrains.kotlinx:kotlinx-coroutines-core:1.8.1'

api 'net.minidev:json-smart:2.5.2'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why adding this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is to override the json smart library's version. json smart is another vulnerability and has been fixed in this version

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The vulnerable version is in base image?

@theyueli theyueli merged commit ad7aa7a into master Apr 24, 2025
31 checks passed
@theyueli theyueli deleted the yue/vulnerability branch April 24, 2025 15:28
@edgao edgao mentioned this pull request Apr 24, 2025
Merged
ericvanbenschoten-dv01 pushed a commit to ericvanbenschoten-dv01/airbyte_ev that referenced this pull request May 6, 2025
@theyueli @octavia-squidington-iii @ericvanbenschoten-dv01
[cdk, source-postgres, source-mysql, source-mongodb-v2] Fixing vulner…
16f2348 
…abilities in dependencies (airbytehq#58132)

Co-authored-by: Octavia Squidington III <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodireich rodireich rodireich approved these changes

@wennergr wennergr Awaiting requested review from wennergr

Assignees

@theyueli theyueli

Labels
connectors/source/mongodb-v2 connectors/source/mysql connectors/source/postgres
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@theyueli @wennergr @rodireich @octavia-squidington-iii