Skip to content

Flaky destinations tests imply that secrets are sometimes not present #28617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
evantahler opened this issue Jul 24, 2023 · 4 comments
Closed

Comments

@evantahler
Copy link
Contributor

The nightly build history for Destination Snowflake is flaky.

Looking at the failures:

SnowflakeDestinationIntegrationTest > testCheckFailsWithInvalidPermissions() FAILED
    java.lang.NullPointerException: Cannot invoke "com.fasterxml.jackson.databind.JsonNode.asText()" because the return value of "com.fasterxml.jackson.databind.JsonNode.get(String)" is null
        at io.airbyte.integrations.destination.snowflake.SnowflakeDatabase.createDataSource(SnowflakeDatabase.java:63)
        at io.airbyte.integrations.destination.snowflake.SnowflakeInternalStagingDestination.getDataSource(SnowflakeInternalStagingDestination.java:94)
        at io.airbyte.integrations.destination.snowflake.SnowflakeInternalStagingDestination.check(SnowflakeInternalStagingDestination.java:50)
        at io.airbyte.integrations.destination.jdbc.copy.SwitchingDestination.check(SwitchingDestination.java:56)
        at io.airbyte.integrations.destination.snowflake.SnowflakeDestinationIntegrationTest.testCheckFailsWithInvalidPermissions(SnowflakeDestinationIntegrationTest.java:36)

This is the short test: https://github.com/airbytehq/airbyte/blob/master/airbyte-integrations/connectors/destination-snowflake/src/test-integration/java/io/airbyte/integrations/destination/snowflake/SnowflakeDestinationIntegrationTest.java#L29-L38

This error implies that reading the config's JSON file is failing... sometimes. If the secret itself isn't changing, then perhaps downloading the config into the test environment is having problems.

@alafanechere
Copy link
Contributor

alafanechere commented Jul 24, 2023

I'm currently discovering a bug related to connector config download, which can be widespread to both python and java connectors when tests are run in parallel.
I suggest to check if this issue persist after closing #27867
My hypothesis is that in parallel pipeline context connector can sometime be tested with the config of another one. This might be solved with a namespace implementation that I'll try to implement this week.

@alafanechere
Copy link
Contributor

I think #28656 will solve this issue. Let's observe the nightly build results over this week before closing.

@alafanechere
Copy link
Contributor

The nightly build passed today.
Will monitor for two consecutive successes before closing.

@alafanechere
Copy link
Contributor

@alafanechere alafanechere self-assigned this Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants