Skip to content

https://github.com/airbytehq/airbyte/pull/25459 #25583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
akashkulk opened this issue Apr 26, 2023 · 0 comments
Closed

https://github.com/airbytehq/airbyte/pull/25459 #25583

akashkulk opened this issue Apr 26, 2023 · 0 comments
Labels
area/documentation Improvements or additions to documentation team/db-dw-sources Backlog for Database and Data Warehouse Sources team type/enhancement New feature or request

Comments

@akashkulk
Copy link
Contributor

akashkulk commented Apr 26, 2023 •
edited
Loading

Initially, we added some logging to format the logs better in #25459.

But this led to the source hanging and ultimately an outage : See link : https://airbytehq-team.slack.com/archives/C054SU1SH0W/p1682509261522549

Investigate what caused it. Looking at the PR, it was due to an infinite loop in
humanReadableByteCountSI caused by trying to fix some last minute formatting issues.

Fix : Robust unit tests JdbcUtils
@akashkulk akashkulk added area/documentation Improvements or additions to documentation type/enhancement New feature or request team/db-dw-sources Backlog for Database and Data Warehouse Sources team labels Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/documentation Improvements or additions to documentation team/db-dw-sources Backlog for Database and Data Warehouse Sources team type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@postamar @akashkulk