Skip to content

Update loading state of the switch component #12530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andyjih opened this issue May 2, 2022 · 2 comments · Fixed by #12790
Closed

Update loading state of the switch component #12530

andyjih opened this issue May 2, 2022 · 2 comments · Fixed by #12790
Assignees
Labels
area/frontend Related to the Airbyte webapp type/enhancement New feature or request

Comments

@andyjih
Copy link
Contributor

andyjih commented May 2, 2022

  1. Update the switch component to support the loading state
    a. Rename component from Toggle to Switch
    b. Migrate from styled components to sass
  2. Identify areas where the loading state is supported
    a. Search in code for the Toggle component and figure out which ones need to have the loading state
  3. Update layout around toggle to include error messages when the request fails

Designs here: https://www.figma.com/proto/etaOkOsnXMoKwbfhCD71kw/WEB-APP?page-id=34030%3A187870&node-id=34051%3A188679&viewport=305%2C48%2C0.25&scaling=min-zoom&starting-point-node-id=34051%3A188679&show-proto-sidebar=1

@andyjih andyjih added area/frontend Related to the Airbyte webapp area/frontend and removed team/triage labels May 2, 2022
@octavia-squidington-iii
Copy link
Collaborator

cc @airbytehq/frontend

@andyjih andyjih added the type/enhancement New feature or request label May 2, 2022
@krishnaglick krishnaglick self-assigned this May 10, 2022
@krishnaglick
Copy link
Contributor

The error functionality, based on the mocks, needs to exist outside the Switch component.
Adding in loading states is fine, and while I can include error messages if they're generated I feel it's slightly outside the apparent scope.
Error reporting should perhaps be part of a larger body of work as often our Error Boundaries just eat them since they're bubbled up through the render tree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp type/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants