Skip to content

Source Intercom: extra slash in Intercom base url #11177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #10936
mrhallak opened this issue Mar 15, 2022 · 4 comments · Fixed by #11176
Closed
Tracked by #10936

Source Intercom: extra slash in Intercom base url #11177

mrhallak opened this issue Mar 15, 2022 · 4 comments · Fixed by #11176
Assignees
Labels
community type/bug Something isn't working

Comments

@mrhallak
Copy link
Contributor

mrhallak commented Mar 15, 2022

Environment

  • Airbyte version: 0.35.55-alpha
  • OS Version / Instance: Ubuntu 20.04
  • Deployment: Docker compose
  • Source Connector and version: Intercom 0.1.13
  • Severity: Medium
  • Step where error happened: Setup new connection

Current Behavior

Unable to test the connection

Expected Behavior

Being able to test the connection

Logs

If applicable, please upload the logs from the failing operation.
For sync jobs, you can download the full logs from the UI by going to the sync attempt page and
clicking the download logs button at the top right of the logs display window.

LOG
2022-03-15 19:30:35 INFO i.a.w.t.TemporalAttemptExecution(get):105 - Docker volume job log path: /tmp/workspace/849ce07d-1ad2-4664-87e1-35ed5e28a78b/0/logs.log
2022-03-15 19:30:35 INFO i.a.w.t.TemporalAttemptExecution(get):110 - Executing worker wrapper. Airbyte version: 0.35.55-alpha
2022-03-15 19:30:35 INFO i.a.c.i.LineGobbler(voidCall):82 - Checking if airbyte/source-intercom:0.1.13 exists...
2022-03-15 19:30:35 INFO i.a.w.p.DockerProcessFactory(create):106 - Creating docker job ID: 849ce07d-1ad2-4664-87e1-35ed5e28a78b
2022-03-15 19:30:35 INFO i.a.c.i.LineGobbler(voidCall):82 - airbyte/source-intercom:0.1.13 was found locally.
2022-03-15 19:30:35 INFO i.a.w.p.DockerProcessFactory(create):158 - Preparing command: docker run --rm --init -i -w /data/849ce07d-1ad2-4664-87e1-35ed5e28a78b/0 --log-driver none --network host -v airbyte_workspace:/data -v /tmp/airbyte_local:/local -e WORKER_JOB_ATTEMPT=0 -e WORKER_CONNECTOR_IMAGE=airbyte/source-intercom:0.1.13 -e AIRBYTE_ROLE= -e WORKER_ENVIRONMENT=DOCKER -e AIRBYTE_VERSION=0.35.55-alpha -e WORKER_JOB_ID=849ce07d-1ad2-4664-87e1-35ed5e28a78b airbyte/source-intercom:0.1.13 check --config source_config.json
2022-03-15 19:30:37 WARN c.n.s.JsonMetaSchema(newValidator):338 - Unknown keyword existingJavaType - you should define your own Meta Schema. If the keyword is irrelevant for validation, just use a NonValidationKeyword
2022-03-15 19:30:37 ERROR i.a.w.p.a.DefaultAirbyteStreamFactory(internalLog):95 - Check failed
2022-03-15 19:30:37 INFO i.a.w.t.TemporalAttemptExecution(get):131 - Stopping cancellation check scheduling...

Steps to Reproduce

  1. Create new source
  2. Choose Intercom
  3. Put in your access token and test

Are you willing to submit a PR?

Already done #11176

@sherifnada
Copy link
Contributor

@mrhallak can you share the full log? It's not clear to me the issue is caused by this trailing slash

@mrhallak
Copy link
Contributor Author

mrhallak commented Mar 15, 2022

@mrhallak can you share the full log? It's not clear to me the issue is caused by this trailing slash

@sherifnada This is pretty much the only logging I'm seeing - same as the one attached above

Screenshot 2022-03-15 at 21 21 31

@lazebnyi lazebnyi self-assigned this Mar 23, 2022
@lazebnyi lazebnyi moved this to Ready for implementation (prioritized) in GL Roadmap Mar 23, 2022
@lazebnyi lazebnyi changed the title Extra slash in Intercom base url Source Intercom: extra slash in Intercom base url Mar 23, 2022
@mrhallak
Copy link
Contributor Author

mrhallak commented Mar 24, 2022

@lazebnyi I'm not sure if we can close this one but the PR has been merged

@lazebnyi lazebnyi linked a pull request Mar 24, 2022 that will close this issue
40 tasks
@lazebnyi
Copy link
Collaborator

Fixed in #11176

@lazebnyi lazebnyi moved this from Ready for implementation (prioritized) to Done in GL Roadmap Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community type/bug Something isn't working
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants