🎉 Base Normalization: quote schema name to allow reserved keywords (#14683)

Signed-off-by: Sergey Chvalyuk <[email protected]>

Author: grubberr

airbyte-integrations/bases/base-normalization/Dockerfile

@@ -28,5 +28,5 @@ WORKDIR /airbyte
 ENV AIRBYTE_ENTRYPOINT "/airbyte/entrypoint.sh"
 ENTRYPOINT ["/airbyte/entrypoint.sh"]
 
-LABEL io.airbyte.version=0.2.12
+LABEL io.airbyte.version=0.2.13
 LABEL io.airbyte.name=airbyte/normalization

airbyte-integrations/bases/base-normalization/normalization/transform_catalog/destination_name_transformer.py

@@ -181,13 +181,15 @@ def __normalize_identifier_name(
             return f"'{result}'"
         return result
 
-    def apply_quote(self, input: str) -> str:
+    def apply_quote(self, input: str, literal=True) -> str:
+        if literal:
+            input = f"'{input}'"
         if self.destination_type == DestinationType.ORACLE:
             # Oracle dbt lib doesn't implemented adapter quote yet.
-            return f"quote('{input}')"
+            return f"quote({input})"
         elif self.destination_type == DestinationType.CLICKHOUSE:
-            return f"quote('{input}')"
-        return f"adapter.quote('{input}')"
+            return f"quote({input})"
+        return f"adapter.quote({input})"
 
     def __normalize_naming_conventions(self, input_name: str, is_column: bool = False) -> str:
         result = input_name

airbyte-integrations/bases/base-normalization/normalization/transform_catalog/stream_processor.py

@@ -1242,7 +1242,10 @@ def add_to_outputs(
                     quoted_unique_key=self.get_unique_key(in_jinja=True),
                     active_row_column_name=active_row_column_name,
                     normalized_at_incremental_clause=self.get_incremental_clause_for_column(
-                        "this.schema + '.' + " + self.name_transformer.apply_quote(final_table_name),
+                        "{} + '.' + {}".format(
+                            self.name_transformer.apply_quote("this.schema", literal=False),
+                            self.name_transformer.apply_quote(final_table_name),
+                        ),
                         self.get_normalized_at(in_jinja=True),
                     ),
                     unique_key_reference=unique_key_reference,

airbyte-workers/src/main/java/io/airbyte/workers/normalization/NormalizationRunnerFactory.java

@@ -14,7 +14,7 @@
 public class NormalizationRunnerFactory {
 
   public static final String BASE_NORMALIZATION_IMAGE_NAME = "airbyte/normalization";
-  public static final String NORMALIZATION_VERSION = "0.2.12";
+  public static final String NORMALIZATION_VERSION = "0.2.13";
 
   static final Map<String, ImmutablePair<String, DefaultNormalizationRunner.DestinationType>> NORMALIZATION_MAPPING =
       ImmutableMap.<String, ImmutablePair<String, DefaultNormalizationRunner.DestinationType>>builder()

docs/understanding-airbyte/basic-normalization.md

@@ -353,8 +353,9 @@ Therefore, in order to "upgrade" to the desired normalization version, you need
 
 | Airbyte Version | Normalization Version | Date       | Pull Request | Subject                                                                    |
 |:----------------|:----------------------|:-----------| :--- |:---------------------------------------------------------------------------|
-|                 | 0.2.11                | 2022-07-26 | [\#13591](https://github.com/airbytehq/airbyte/pull/13591) | Updated support for integer columns.                                       |
+|                 | 0.2.13                | 2022-07-27 | [\#14683](https://github.com/airbytehq/airbyte/pull/14683) | Quote schema name to allow reserved keywords                               |
 |                 | 0.2.12                | 2022-07-26 | [\#14362](https://github.com/airbytehq/airbyte/pull/14362) | Handle timezone in date-time format. Parse date correct in clickhouse.     |
+|                 | 0.2.11                | 2022-07-26 | [\#13591](https://github.com/airbytehq/airbyte/pull/13591) | Updated support for integer columns.                                       |
 |                 | 0.2.10                | 2022-07-18 | [\#14792](https://github.com/airbytehq/airbyte/pull/14792) | Add support for key pair auth for snowflake                                |
 |                 | 0.2.9                 | 2022-07-06 | [\#14485](https://github.com/airbytehq/airbyte/pull/14485) | BigQuery partition pruning otimization                                     |
 |                 | 0.2.8                 | 2022-07-13 | [\#14522](https://github.com/airbytehq/airbyte/pull/14522) | BigQuery replaces `NULL` array entries with the string value `"NULL"`      |
@@ -400,4 +401,3 @@ Therefore, in order to "upgrade" to the desired normalization version, you need
 | 0.28.2-alpha    | 0.1.38                | 2021-07-28 | [\#5027](https://github.com/airbytehq/airbyte/pull/5027) | Handle quotes in column names when parsing JSON blob                       |
 | 0.27.5-alpha    | 0.1.37                | 2021-07-22 | [\#3947](https://github.com/airbytehq/airbyte/pull/4881/) | Handle `NULL` cursor field values when deduping                            |
 | 0.27.2-alpha    | 0.1.36                | 2021-07-09 | [\#3947](https://github.com/airbytehq/airbyte/pull/4163/) | Enable normalization for MySQL destination                                 |
-