tweak snowflake destination to hide INSERT load method (#9982)

* tweak snowflake to hide INSERT load method

* address review comment

Author: subodh1810

airbyte-integrations/connectors/destination-snowflake/src/main/java/io/airbyte/integrations/destination/snowflake/SnowflakeDestination.java

@@ -18,7 +18,6 @@ public class SnowflakeDestination extends SwitchingDestination<SnowflakeDestinat
   private static final Logger LOGGER = LoggerFactory.getLogger(SnowflakeDestination.class);
 
   enum DestinationType {
-    INSERT,
     COPY_S3,
     COPY_GCS,
     INTERNAL_STAGING
@@ -28,7 +27,7 @@ public SnowflakeDestination() {
     super(DestinationType.class, SnowflakeDestination::getTypeFromConfig, getTypeToDestination());
   }
 
-  public static DestinationType getTypeFromConfig(final JsonNode config) {
+  private static DestinationType getTypeFromConfig(final JsonNode config) {
     if (isS3Copy(config)) {
       return DestinationType.COPY_S3;
     } else if (isGcsCopy(config)) {
@@ -38,11 +37,6 @@ public static DestinationType getTypeFromConfig(final JsonNode config) {
     }
   }
 
-  public static boolean isInternalStaging(final JsonNode config) {
-    return config.has("loading_method") && config.get("loading_method").isObject()
-        && config.get("loading_method").get("method").asText().equals("Internal Staging");
-  }
-
   public static boolean isS3Copy(final JsonNode config) {
     return config.has("loading_method") && config.get("loading_method").isObject() && config.get("loading_method").has("s3_bucket_name");
   }
@@ -51,14 +45,12 @@ public static boolean isGcsCopy(final JsonNode config) {
     return config.has("loading_method") && config.get("loading_method").isObject() && config.get("loading_method").has("project_id");
   }
 
-  public static Map<DestinationType, Destination> getTypeToDestination() {
-    final SnowflakeInsertDestination insertDestination = new SnowflakeInsertDestination();
+  private static Map<DestinationType, Destination> getTypeToDestination() {
     final SnowflakeCopyS3Destination copyS3Destination = new SnowflakeCopyS3Destination();
     final SnowflakeCopyGcsDestination copyGcsDestination = new SnowflakeCopyGcsDestination();
     final SnowflakeInternalStagingDestination internalStagingDestination = new SnowflakeInternalStagingDestination();
 
     return ImmutableMap.of(
-        DestinationType.INSERT, insertDestination,
         DestinationType.COPY_S3, copyS3Destination,
         DestinationType.COPY_GCS, copyGcsDestination,
         DestinationType.INTERNAL_STAGING, internalStagingDestination);

airbyte-integrations/connectors/destination-snowflake/src/main/resources/spec.json

@@ -81,28 +81,28 @@
         "order": 8,
         "oneOf": [
           {
-            "title": "[Recommended] Internal Staging",
+            "title": "Select another option",
             "additionalProperties": false,
-            "description": "Writes large batches of records to a file, uploads the file to Snowflake, then uses <pre>COPY INTO table</pre> to upload the file. Recommended for large production workloads for better speed and scalability.",
+            "description": "Select another option",
             "required": ["method"],
             "properties": {
               "method": {
                 "type": "string",
-                "enum": ["Internal Staging"],
-                "default": "Internal Staging"
+                "enum": ["Standard"],
+                "default": "Standard"
               }
             }
           },
           {
-            "title": "Standard Inserts",
+            "title": "[Recommended] Internal Staging",
             "additionalProperties": false,
-            "description": "Uses <pre>INSERT</pre> statements to send batches of records to Snowflake. Easiest (no setup) but not recommended for large production workloads due to slow speed.",
+            "description": "Writes large batches of records to a file, uploads the file to Snowflake, then uses <pre>COPY INTO table</pre> to upload the file. Recommended for large production workloads for better speed and scalability.",
             "required": ["method"],
             "properties": {
               "method": {
                 "type": "string",
-                "enum": ["Standard"],
-                "default": "Standard"
+                "enum": ["Internal Staging"],
+                "default": "Internal Staging"
               }
             }
           },