🐛 Source Zendesk Support: Ticket Audits: added stop condition for fetching next pages, ignore 403 and 404 status codes. (#37761)

Author: darynaishchenko

airbyte-integrations/connectors/source-zendesk-support/metadata.yaml

@@ -11,7 +11,7 @@ data:
   connectorSubtype: api
   connectorType: source
   definitionId: 79c1aa37-dae3-42ae-b333-d1c105477715
-  dockerImageTag: 2.6.1
+  dockerImageTag: 2.6.2
   dockerRepository: airbyte/source-zendesk-support
   documentationUrl: https://docs.airbyte.com/integrations/sources/zendesk-support
   githubIssueLabel: source-zendesk-support

airbyte-integrations/connectors/source-zendesk-support/pyproject.toml

@@ -3,7 +3,7 @@ requires = [ "poetry-core>=1.0.0",]
 build-backend = "poetry.core.masonry.api"
 
 [tool.poetry]
-version = "2.6.1"
+version = "2.6.2"
 name = "source-zendesk-support"
 description = "Source implementation for Zendesk Support."
 authors = [ "Airbyte <[email protected]>",]

airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/components.py

@@ -6,7 +6,6 @@
 import requests
 from airbyte_cdk.sources.declarative.extractors.record_extractor import RecordExtractor
 from airbyte_cdk.sources.declarative.incremental import DatetimeBasedCursor
-from airbyte_cdk.sources.declarative.migrations.state_migration import StateMigration
 from airbyte_cdk.sources.declarative.requesters.request_option import RequestOptionType
 from airbyte_cdk.sources.declarative.types import StreamSlice, StreamState
 

airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/manifest.yaml

@@ -38,7 +38,7 @@ definitions:
           - type: DefaultErrorHandler
             response_filters:
               - http_codes: [403, 404]
-                action: FAIL
+                action: IGNORE
                 error_message: "Skipping stream {{ parameters.get('name') }}, error message: {{ response.get('error') }}. Please ensure the authenticated user has access to this stream. If the issue persists, contact Zendesk support."
           - type: DefaultErrorHandler
             backoff_strategies:
@@ -406,7 +406,7 @@ definitions:
                   action: FAIL
                   error_message: "Skipping stream `{{ parameters.get('name') }}`. Timed out waiting for response: {{ response.text }}..."
                 - http_codes: [403, 404]
-                  action: FAIL
+                  action: IGNORE
                   error_message: "Skipping stream {{ parameters.get('name') }}, error message: {{ response.get('error') }}. Please ensure the authenticated user has access to this stream. If the issue persists, contact Zendesk support."
       paginator:
         type: DefaultPaginator
@@ -418,7 +418,7 @@ definitions:
           type: CursorPagination
           page_size: 200
           cursor_value: "{{ response.get('before_url') }}"
-          stop_condition: "{{ config.get('ignore_pagination') or 'before_url' not in response }}"
+          stop_condition: "{{ config.get('ignore_pagination') or 'before_url' not in response or not last_record }}"
         page_token_option:
           type: RequestPath
     incremental_sync:
@@ -456,7 +456,7 @@ definitions:
           type: RequestPath
     $parameters:
       name: "ticket_comments"
-      path: "incremental/ticket_events.jsopn"
+      path: "incremental/ticket_events.json"
       cursor_field: "created_at"
       cursor_filter: "start_time"
       primary_key: "id"
@@ -476,7 +476,21 @@ definitions:
   ticket_forms_stream:
     $ref: "#/definitions/semi_incremental_stream"
     retriever:
-      $ref: "#/definitions/semi_incremental_stream/retriever"
+      $ref: "#/definitions/retriever"
+      requester:
+        $ref: "#/definitions/retriever/requester"
+        error_handler:
+          type: CompositeErrorHandler
+          error_handlers:
+            - type: DefaultErrorHandler
+              response_filters:
+                - http_codes: [403, 404]
+                  action: FAIL # fail as this stream used to define enterprise plan
+                  error_message: "Skipping stream {{ parameters.get('name') }}, error message: {{ response.get('error') }}. Please ensure the authenticated user has access to this stream. If the issue persists, contact Zendesk support."
+            - type: DefaultErrorHandler
+              backoff_strategies:
+                - type: WaitTimeFromHeader
+                  header: Retry-After
       paginator:
         type: DefaultPaginator
         pagination_strategy:

docs/integrations/sources/zendesk-support.md

@@ -158,6 +158,7 @@ The Zendesk connector ideally should not run into Zendesk API limitations under
 
 | Version  | Date       | Pull Request                                             | Subject                                                                                                                                                                                                                            |
 |:---------|:-----------|:---------------------------------------------------------|:-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| `2.6.2`  | 2024-02-05 | [37761](https://github.com/airbytehq/airbyte/pull/37761) | Add stop condition for `Ticket Audits` when recieved old records; Ignore 403 and 404 status codes.                                                                                                                                 |
 | `2.6.1`  | 2024-04-30 | [37723](https://github.com/airbytehq/airbyte/pull/37723) | Add %Y-%m-%dT%H:%M:%S%z to cursor_datetime_formats                                                                                                                                                                                 |
 | `2.6.0`  | 2024-04-29 | [36823](https://github.com/airbytehq/airbyte/pull/36823) | Migrate to low code; Add new stream `Ticket Activities`                                                                                                                                                                            |
 | `2.5.0`  | 2024-04-25 | [36388](https://github.com/airbytehq/airbyte/pull/36388) | Fix data type of field in `Tickets` stream schema stream.                                                                                                                                                                          |