Skip to content

Commit e7d7b23

Browse files
Source Salesforce: drop ActivityMetricRollup stream (#22322)
* #1330 source salesforce: drop activitymetricrollup stream * #1330 source salesforce: upd changelog * auto-bump connector version --------- Co-authored-by: Octavia Squidington III <[email protected]>
1 parent 31f3bb7 commit e7d7b23

File tree

6 files changed

+9
-5
lines changed

6 files changed

+9
-5
lines changed

airbyte-config/init/src/main/resources/seed/source_definitions.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1562,7 +1562,7 @@
15621562
- name: Salesforce
15631563
sourceDefinitionId: b117307c-14b6-41aa-9422-947e34922962
15641564
dockerRepository: airbyte/source-salesforce
1565-
dockerImageTag: 1.0.30
1565+
dockerImageTag: 2.0.0
15661566
documentationUrl: https://docs.airbyte.com/integrations/sources/salesforce
15671567
icon: salesforce.svg
15681568
sourceType: api

airbyte-config/init/src/main/resources/seed/source_specs.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13106,7 +13106,7 @@
1310613106
supportsNormalization: false
1310713107
supportsDBT: false
1310813108
supported_destination_sync_modes: []
13109-
- dockerImage: "airbyte/source-salesforce:1.0.30"
13109+
- dockerImage: "airbyte/source-salesforce:2.0.0"
1311013110
spec:
1311113111
documentationUrl: "https://docs.airbyte.com/integrations/sources/salesforce"
1311213112
connectionSpecification:

airbyte-integrations/connectors/source-salesforce/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,5 @@ RUN pip install .
1313

1414
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]
1515

16-
LABEL io.airbyte.version=1.0.30
16+
LABEL io.airbyte.version=2.0.0
1717
LABEL io.airbyte.name=airbyte/source-salesforce

airbyte-integrations/connectors/source-salesforce/source_salesforce/api.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,6 +201,8 @@
201201
"UriEvent",
202202
]
203203

204+
UNSUPPORTED_STREAMS = ["ActivityMetric", "ActivityMetricRollup"]
205+
204206

205207
class Salesforce:
206208
logger = logging.getLogger("airbyte")
@@ -256,7 +258,7 @@ def get_validated_streams(self, config: Mapping[str, Any], catalog: ConfiguredAi
256258
"""
257259
stream_objects = {}
258260
for stream_object in self.describe()["sobjects"]:
259-
if stream_object["name"].lower() == "activitymetric":
261+
if stream_object["name"] in UNSUPPORTED_STREAMS:
260262
self.logger.warning(f"Stream {stream_object['name']} can not be used without object ID therefore will be ignored.")
261263
continue
262264
if stream_object["queryable"]:

airbyte-integrations/connectors/source-salesforce/unit_tests/discovery_test.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ def test_discovery_filter(stream_config):
7070
"sobjects": [
7171
{"name": "Account", "queryable": True},
7272
{"name": "ActivityMetric", "queryable": True},
73+
{"name": "ActivityMetricRollup", "queryable": True},
7374
{"name": "Leads", "queryable": False},
7475
]
7576
}

docs/integrations/sources/salesforce.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,8 @@ Now that you have set up the Salesforce source connector, check out the followin
129129

130130
| Version | Date | Pull Request | Subject |
131131
|:--------|:-----------|:---------------------------------------------------------|:---------------------------------------------------------------------------------------------------------------------------------|
132-
| 1.0.30 | 2023-01-27 | [22016](https://github.com/airbytehq/airbyte/pull/22016) | Set `AvailabilityStrategy` for streams explicitly to `None` |
132+
| 2.0.0 | 2023-02-02 | [22322](https://github.com/airbytehq/airbyte/pull/22322) | Remove `ActivityMetricRollup` stream |
133+
| 1.0.30 | 2023-01-27 | [22016](https://github.com/airbytehq/airbyte/pull/22016) | Set `AvailabilityStrategy` for streams explicitly to `None` |
133134
| 1.0.29 | 2023-01-05 | [20886](https://github.com/airbytehq/airbyte/pull/20886) | Remove `ActivityMetric` stream |
134135
| 1.0.28 | 2022-12-29 | [20927](https://github.com/airbytehq/airbyte/pull/20927) | Fix tests; add expected records |
135136
| 1.0.27 | 2022-11-29 | [19869](https://github.com/airbytehq/airbyte/pull/19869) | Remove `AccountHistory` from unsupported BULK streams |

0 commit comments

Comments
 (0)