feat(source-google-ads): api update (#44095)

Co-authored-by: Alexandre Girard <[email protected]>

Author: darynaishchenko

airbyte-integrations/connectors/source-google-ads/integration_tests/integration_test.py

@@ -7,7 +7,7 @@
 
 import pytest
 from airbyte_cdk.models import SyncMode
-from google.ads.googleads.v15.services.types.google_ads_service import GoogleAdsRow
+from google.ads.googleads.v17.services.types.google_ads_service import GoogleAdsRow
 from source_google_ads.source import SourceGoogleAds
 
 

airbyte-integrations/connectors/source-google-ads/metadata.yaml

@@ -11,7 +11,7 @@ data:
   connectorSubtype: api
   connectorType: source
   definitionId: 253487c0-2246-43ba-a21f-5116b20a2c50
-  dockerImageTag: 3.6.5
+  dockerImageTag: 3.7.0
   dockerRepository: airbyte/source-google-ads
   documentationUrl: https://docs.airbyte.com/integrations/sources/google-ads
   githubIssueLabel: source-google-ads

airbyte-integrations/connectors/source-google-ads/poetry.lock

@@ -3,7 +3,7 @@ requires = [ "poetry-core>=1.0.0",]
 build-backend = "poetry.core.masonry.api"
 
 [tool.poetry]
-version = "3.6.5"
+version = "3.7.0"
 name = "source-google-ads"
 description = "Source implementation for Google Ads."
 authors = [ "Airbyte <[email protected]>",]
@@ -17,7 +17,7 @@ include = "source_google_ads"
 
 [tool.poetry.dependencies]
 python = "^3.10,<3.12"
-google-ads = "==22.1.0"
+google-ads = "==25.0.0"
 protobuf = "==4.25.2"
 airbyte-cdk = "^4"
 

airbyte-integrations/connectors/source-google-ads/pyproject.toml

@@ -10,14 +10,14 @@
 from airbyte_cdk.models import FailureType
 from airbyte_cdk.utils import AirbyteTracedException
 from google.ads.googleads.client import GoogleAdsClient
-from google.ads.googleads.v15.services.types.google_ads_service import GoogleAdsRow, SearchGoogleAdsResponse
+from google.ads.googleads.v17.services.types.google_ads_service import GoogleAdsRow, SearchGoogleAdsResponse
 from google.api_core.exceptions import InternalServerError, ServerError, TooManyRequests
 from google.auth import exceptions
 from proto.marshal.collections import Repeated, RepeatedComposite
 
 from .utils import logger
 
-API_VERSION = "v15"
+API_VERSION = "v17"
 
 
 def on_give_up(details):
@@ -94,7 +94,6 @@ def send_request(
         client = self.get_client(login_customer_id)
         search_request = client.get_type("SearchGoogleAdsRequest")
         search_request.query = query
-        search_request.page_size = self.DEFAULT_PAGE_SIZE
         search_request.customer_id = customer_id
         return [self.ga_service(login_customer_id).search(search_request)]
 

airbyte-integrations/connectors/source-google-ads/source_google_ads/google_ads.py

@@ -14,8 +14,8 @@
 from airbyte_cdk.utils import AirbyteTracedException
 from airbyte_protocol.models import FailureType
 from google.ads.googleads.errors import GoogleAdsException
-from google.ads.googleads.v15.services.services.google_ads_service.pagers import SearchPager
-from google.ads.googleads.v15.services.types.google_ads_service import SearchGoogleAdsResponse
+from google.ads.googleads.v17.services.services.google_ads_service.pagers import SearchPager
+from google.ads.googleads.v17.services.types.google_ads_service import SearchGoogleAdsResponse
 from google.api_core.exceptions import InternalServerError, ServerError, ServiceUnavailable, TooManyRequests, Unauthenticated
 
 from .google_ads import GoogleAds, logger

airbyte-integrations/connectors/source-google-ads/source_google_ads/streams.py

@@ -16,11 +16,11 @@
 from airbyte_cdk.models import FailureType
 from airbyte_cdk.utils import AirbyteTracedException
 from google.ads.googleads.errors import GoogleAdsException
-from google.ads.googleads.v15.errors.types.authentication_error import AuthenticationErrorEnum
-from google.ads.googleads.v15.errors.types.authorization_error import AuthorizationErrorEnum
-from google.ads.googleads.v15.errors.types.query_error import QueryErrorEnum
-from google.ads.googleads.v15.errors.types.quota_error import QuotaErrorEnum
-from google.ads.googleads.v15.errors.types.request_error import RequestErrorEnum
+from google.ads.googleads.v17.errors.types.authentication_error import AuthenticationErrorEnum
+from google.ads.googleads.v17.errors.types.authorization_error import AuthorizationErrorEnum
+from google.ads.googleads.v17.errors.types.query_error import QueryErrorEnum
+from google.ads.googleads.v17.errors.types.quota_error import QuotaErrorEnum
+from google.ads.googleads.v17.errors.types.request_error import RequestErrorEnum
 from google.api_core.exceptions import Unauthenticated
 
 logger = logging.getLogger("airbyte")

airbyte-integrations/connectors/source-google-ads/source_google_ads/utils.py

@@ -6,11 +6,11 @@
 import json
 
 from google.ads.googleads.errors import GoogleAdsException
-from google.ads.googleads.v15 import GoogleAdsFailure
-from google.ads.googleads.v15.errors.types.authentication_error import AuthenticationErrorEnum
-from google.ads.googleads.v15.errors.types.authorization_error import AuthorizationErrorEnum
-from google.ads.googleads.v15.errors.types.query_error import QueryErrorEnum
-from google.ads.googleads.v15.errors.types.quota_error import QuotaErrorEnum
+from google.ads.googleads.v17 import GoogleAdsFailure
+from google.ads.googleads.v17.errors.types.authentication_error import AuthenticationErrorEnum
+from google.ads.googleads.v17.errors.types.authorization_error import AuthorizationErrorEnum
+from google.ads.googleads.v17.errors.types.query_error import QueryErrorEnum
+from google.ads.googleads.v17.errors.types.quota_error import QuotaErrorEnum
 
 
 class MockSearchRequest:

airbyte-integrations/connectors/source-google-ads/unit_tests/common.py

@@ -71,13 +71,11 @@ def test_send_request(mocker, customers):
     mocker.patch("source_google_ads.google_ads.GoogleAdsClient.get_service", return_value=MockGoogleAdsService())
     google_ads_client = GoogleAds(**SAMPLE_CONFIG)
     query = "Query"
-    page_size = 1000
     customer_id = next(iter(customers)).id
     response = list(google_ads_client.send_request(query, customer_id=customer_id))
 
     assert response[0].customer_id == customer_id
     assert response[0].query == query
-    assert response[0].page_size == page_size
 
 
 def test_get_fields_from_schema():

airbyte-integrations/connectors/source-google-ads/unit_tests/test_google_ads.py

@@ -9,8 +9,8 @@
 from airbyte_cdk.models import FailureType, SyncMode
 from airbyte_cdk.utils import AirbyteTracedException
 from google.ads.googleads.errors import GoogleAdsException
-from google.ads.googleads.v15.errors.types.errors import ErrorCode, GoogleAdsError, GoogleAdsFailure
-from google.ads.googleads.v15.errors.types.request_error import RequestErrorEnum
+from google.ads.googleads.v17.errors.types.errors import ErrorCode, GoogleAdsError, GoogleAdsFailure
+from google.ads.googleads.v17.errors.types.request_error import RequestErrorEnum
 from google.api_core.exceptions import DataLoss, InternalServerError, ResourceExhausted, TooManyRequests, Unauthenticated
 from grpc import RpcError
 from source_google_ads.google_ads import GoogleAds