Expected Records to .jsonl format (#20850)

* Expected Records to `.jsonl` format

* fix formatting template

* remove endline

* update templates

* Update docs/connector-development/testing-connectors/source-acceptance-tests-reference.md

Co-authored-by: Pedro S. Lopez <[email protected]>

Co-authored-by: Pedro S. Lopez <[email protected]>

Author: evantahler

airbyte-integrations/bases/source-acceptance-test/sample_files/acceptance-test-config.yml

@@ -14,7 +14,7 @@ tests:
       configured_catalog_path: "sample_files/configured_catalog.json"
       empty_streams: []
       expect_records:
-        path: "integration_tests/expected_records.txt"
+        path: "integration_tests/expected_records.jsonl"
         extra_fields: no
         exact_order: no
         extra_records: yes

airbyte-integrations/bases/source-acceptance-test/unit_tests/test_global_fixtures.py

@@ -97,7 +97,7 @@ def test_empty_streams_fixture(mocker, test_strictness_level, basic_read_test_co
             TEST_CONFIGURED_CATALOG,
             {EmptyStreamConfiguration(name="test_stream_b"), EmptyStreamConfiguration(name="test_stream_c")},
             [{"stream": "test_stream_a", "data": {"k": "foo"}, "emitted_at": 1634387507000}],
-            ExpectedRecordsConfig(path="expected_records.json"),
+            ExpectedRecordsConfig(path="expected_records.jsonl"),
             False,
             id="High strictness level: test_stream_b and test_stream_c are declared as empty streams, expected records only contains test_stream_a record -> Not failing",
         ),
@@ -106,7 +106,7 @@ def test_empty_streams_fixture(mocker, test_strictness_level, basic_read_test_co
             TEST_CONFIGURED_CATALOG,
             set(),
             [{"stream": "test_stream_a", "data": {"k": "foo"}, "emitted_at": 1634387507000}],
-            ExpectedRecordsConfig(path="expected_records.json"),
+            ExpectedRecordsConfig(path="expected_records.jsonl"),
             True,
             id="High strictness level: test_stream_b and test_stream_c are not declared as empty streams, expected records only contains test_stream_a record -> Failing",
         ),
@@ -115,7 +115,7 @@ def test_empty_streams_fixture(mocker, test_strictness_level, basic_read_test_co
             TEST_CONFIGURED_CATALOG,
             {EmptyStreamConfiguration(name="test_stream_b")},
             [{"stream": "test_stream_a", "data": {"k": "foo"}, "emitted_at": 1634387507000}],
-            ExpectedRecordsConfig(path="expected_records.json"),
+            ExpectedRecordsConfig(path="expected_records.jsonl"),
             True,
             id="High strictness level: test_stream_b is declared as an empty stream, test_stream_c is not declared as empty streams, expected records only contains test_stream_a record -> Failing",
         ),
@@ -142,7 +142,7 @@ def test_empty_streams_fixture(mocker, test_strictness_level, basic_read_test_co
             TEST_CONFIGURED_CATALOG,
             set(),
             [{"stream": "test_stream_a", "data": {"k": "foo"}, "emitted_at": 1634387507000}],
-            ExpectedRecordsConfig(path="expected_records.json"),
+            ExpectedRecordsConfig(path="expected_records.jsonl"),
             False,
             id="Low strictness level, no empty stream, incomplete expected records ->  Not failing",
         ),
@@ -154,7 +154,7 @@ def test_expected_records_by_stream_fixture(
     mocker.patch.object(conftest.pytest, "fail")
 
     base_path = tmp_path
-    with open(f"{base_path}/expected_records.json", "w") as expected_records_file:
+    with open(f"{base_path}/expected_records.jsonl", "w") as expected_records_file:
         for record in expected_records:
             expected_records_file.write(json.dumps(record) + "\n")
 

airbyte-integrations/connector-templates/source_acceptance_test_files/acceptance-test-config.yml.hbs

@@ -21,7 +21,7 @@ acceptance_tests:
         empty_streams: []
 # TODO uncomment this block to specify that the tests should assert the connector outputs the records provided in the input file a file
 #        expect_records:
-#          path: "integration_tests/expected_records.txt"
+#          path: "integration_tests/expected_records.jsonl"
 #          extra_fields: no
 #          exact_order: no
 #          extra_records: yes

airbyte-integrations/connectors/source-activecampaign/acceptance-test-config.yml

@@ -17,7 +17,7 @@ tests:
       empty_streams: []
   # TODO uncomment this block to specify that the tests should assert the connector outputs the records provided in the input file a file
   #      expect_records:
-  #        path: "integration_tests/expected_records.txt"
+  #        path: "integration_tests/expected_records.jsonl"
   #        extra_fields: no
   #        exact_order: no
   #        extra_records: yes

airbyte-integrations/connectors/source-aha/acceptance-test-config.yml

@@ -19,19 +19,19 @@ acceptance_tests:
       - config_path: "secrets/config.json"
         configured_catalog_path: "integration_tests/configured_catalog.json"
         empty_streams: []
-# TODO uncomment this block to specify that the tests should assert the connector outputs the records provided in the input file a file
-#        expect_records:
-#          path: "integration_tests/expected_records.txt"
-#          extra_fields: no
-#          exact_order: no
-#          extra_records: yes
-  incremental: 
+  # TODO uncomment this block to specify that the tests should assert the connector outputs the records provided in the input file a file
+  #        expect_records:
+  #          path: "integration_tests/expected_records.jsonl"
+  #          extra_fields: no
+  #          exact_order: no
+  #          extra_records: yes
+  incremental:
     bypass_reason: "This connector does not implement incremental sync"
-# TODO uncomment this block this block if your connector implements incremental sync: 
-#    tests:
-#      - config_path: "secrets/config.json"
-#        configured_catalog_path: "integration_tests/configured_catalog.json"
-#        future_state_path: "integration_tests/abnormal_state.json"
+  # TODO uncomment this block this block if your connector implements incremental sync:
+  #    tests:
+  #      - config_path: "secrets/config.json"
+  #        configured_catalog_path: "integration_tests/configured_catalog.json"
+  #        future_state_path: "integration_tests/abnormal_state.json"
   full_refresh:
     tests:
       - config_path: "secrets/config.json"

airbyte-integrations/connectors/source-amazon-ads/acceptance-test-config.yml

@@ -15,7 +15,7 @@ tests:
     - config_path: "secrets/config.json"
       configured_catalog_path: "integration_tests/configured_catalog.json"
       expect_records:
-        path: "integration_tests/expected_records.txt"
+        path: "integration_tests/expected_records.jsonl"
         extra_fields: no
         exact_order: no
         extra_records: no
@@ -47,4 +47,4 @@ tests:
       configured_catalog_path: "integration_tests/configured_catalog_report.json"
       ignored_fields:
         "sponsored_products_report_stream": ["updatedAt"]
-      timeout_seconds: 3600
+      timeout_seconds: 3600

airbyte-integrations/connectors/source-amazon-ads/integration_tests/expected_records.txt renamed to airbyte-integrations/connectors/source-amazon-ads/integration_tests/expected_records.jsonl

@@ -16,7 +16,7 @@ tests:
       configured_catalog_path: "integration_tests/configured_catalog.json"
       empty_streams: []
       # expect_records:
-      #   path: "integration_tests/expected_records.txt"
+      #   path: "integration_tests/expected_records.jsonl"
       #   extra_fields: no
       #   exact_order: no
       #   extra_records: yes

airbyte-integrations/connectors/source-amazon-sqs/acceptance-test-config.yml

@@ -15,12 +15,12 @@ tests:
     - config_path: "secrets/config.json"
       configured_catalog_path: "integration_tests/configured_catalog.json"
       empty_streams: []
-# TODO uncomment this block to specify that the tests should assert the connector outputs the records provided in the input file a file
-#      expect_records:
-#        path: "integration_tests/expected_records.txt"
-#        extra_fields: no
-#        exact_order: no
-#        extra_records: yes
+  # TODO uncomment this block to specify that the tests should assert the connector outputs the records provided in the input file a file
+  #      expect_records:
+  #        path: "integration_tests/expected_records.jsonl"
+  #        extra_fields: no
+  #        exact_order: no
+  #        extra_records: yes
   incremental: # TODO if your connector does not implement incremental sync, remove this block
     - config_path: "secrets/config.json"
       configured_catalog_path: "integration_tests/configured_catalog.json"