Skip to content

Commit dc71bf6

Browse files
authored
🍾 Remove automatic filtering of system schemas from Oracle source. (#6038)
* Remove default schemas from Oracle source. * Bump version and update changelog.
1 parent fa0028d commit dc71bf6

File tree

4 files changed

+8
-4
lines changed

4 files changed

+8
-4
lines changed

airbyte-config/init/src/main/resources/seed/source_definitions.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,7 @@
289289
- sourceDefinitionId: b39a7370-74c3-45a6-ac3a-380d48520a83
290290
name: Oracle DB
291291
dockerRepository: airbyte/source-oracle
292-
dockerImageTag: 0.3.3
292+
dockerImageTag: 0.3.4
293293
documentationUrl: https://docs.airbyte.io/integrations/sources/oracle
294294
- sourceDefinitionId: c8630570-086d-4a40-99ae-ea5b18673071
295295
name: Zendesk Talk

airbyte-integrations/connectors/source-oracle/Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,5 @@ COPY build/distributions/${APPLICATION}*.tar ${APPLICATION}.tar
99

1010
RUN tar xf ${APPLICATION}.tar --strip-components=1
1111

12-
LABEL io.airbyte.version=0.3.3
12+
LABEL io.airbyte.version=0.3.4
1313
LABEL io.airbyte.name=airbyte/source-oracle

airbyte-integrations/connectors/source-oracle/src/main/java/io/airbyte/integrations/source/oracle/OracleSource.java

+5-2
Original file line numberDiff line numberDiff line change
@@ -94,10 +94,13 @@ public List<TableInfo<CommonField<JDBCType>>> discoverInternal(JdbcDatabase data
9494
return internals;
9595
}
9696

97+
/**
98+
* Since the Oracle connector allows a user to specify schemas, and picks a default schemas
99+
* otherwise, system tables are never included, and do not need to be excluded by default.
100+
*/
97101
@Override
98102
public Set<String> getExcludedInternalNameSpaces() {
99-
// need to add SYSTEM too but for that need create another user when creating the container.
100-
return Set.of("APEX_040000", "CTXSYS", "SYSTEM", "FLOWS_FILES", "HR", "MDSYS", "OUTLN", "SYS", "XDB");
103+
return Set.of();
101104
}
102105

103106
public static void main(String[] args) throws Exception {

docs/integrations/sources/oracle.md

+1
Original file line numberDiff line numberDiff line change
@@ -105,5 +105,6 @@ Case sensitive. Defaults to the upper-cased user if empty. If the user does not
105105

106106
| Version | Date | Pull Request | Subject |
107107
| :------ | :-------- | :----- | :------ |
108+
| 0.3.4 | 2021-09-01 | [6038](https://github.com/airbytehq/airbyte/pull/6038) | Remove automatic filtering of system schemas. |
108109
| 0.3.3 | 2021-09-01 | [5779](https://github.com/airbytehq/airbyte/pull/5779) | Ability to only discover certain schemas. |
109110
| 0.3.2 | 2021-08-13 | [4699](https://github.com/airbytehq/airbyte/pull/4699) | Added json config validator. |

0 commit comments

Comments
 (0)