Skip to content

Commit dc2f13f

Browse files
committed
Update styling
1 parent d942050 commit dc2f13f

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

.github/comment_templates/connector_dependency_template.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do
1414
</summary>
1515

1616
| Connector | Version | Changelog | Publish |
17-
| --- | --- | --- | --- |
17+
| --- | :---: | :---: | :---: |
1818
{source_rows}
1919

2020
</details>
@@ -27,7 +27,7 @@ NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do
2727
</summary>
2828

2929
| Connector | Version | Changelog | Publish |
30-
| --- | --- | --- | --- |
30+
| --- | :---: | :---: | :---: |
3131
{destination_rows}
3232

3333
</details>

tools/bin/ci_check_dependency.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -106,22 +106,22 @@ def get_connector_version_status(connector, version):
106106
if base_variant_version == version:
107107
return f"`{version}`"
108108
else:
109-
return f"`{version}`(mismatch normal: `{base_variant_version}`)"
109+
return f"`{version}`<br/>(mismatch: `{base_variant_version}`)"
110110

111111

112112
def get_connector_changelog_status(connector, version):
113113
type, name = connector.replace("-strict-encrypt", "").split("-", 1)
114114
doc_path = f"{DOC_PATH}{type}s/{name}.md"
115115
if not os.path.exists(doc_path):
116-
return "⚠ (doc file not found)"
116+
return "⚠<br/>(doc not found)"
117117
with open(doc_path) as f:
118118
after_changelog = False
119119
for line in f:
120120
if "# changelog" in line.lower():
121121
after_changelog = True
122122
if after_changelog and version in line:
123123
return "✅"
124-
return "❌ (changelog missing)"
124+
return "❌<br/>(changelog missing)"
125125

126126
def as_bulleted_markdown_list(items):
127127
text = ""
@@ -138,11 +138,11 @@ def as_markdown_table_row(connectors, definitions):
138138
changelog_status = get_connector_changelog_status(connector, version)
139139
definition = next((x for x in definitions if x["dockerRepository"].endswith(connector)), None)
140140
if definition is None:
141-
publish_status = "⚠ (connector not in definition)"
141+
publish_status = "⚠<br/>(not in seed)"
142142
elif definition["dockerImageTag"] == version:
143143
publish_status = "✅"
144144
else:
145-
publish_status = "❌ (version mismatch in seed definition)"
145+
publish_status = "❌<br/>(diff seed version)"
146146
text += f"| `{connector}` | {version_status} | {changelog_status} | {publish_status} |\n"
147147
return text
148148

0 commit comments

Comments
 (0)