Skip to content

Commit d7b9ae2

Browse files
Source Google Ads: upgrade google-ads package version (#9996)
* upgrade google-ads package version * add comment about use_proto_plus * bump version * updated spec and def yaml Co-authored-by: auganbay <[email protected]>
1 parent 3aa90a7 commit d7b9ae2

File tree

7 files changed

+8
-16
lines changed

7 files changed

+8
-16
lines changed

airbyte-config/init/src/main/resources/seed/source_definitions.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@
252252
- name: Google Ads
253253
sourceDefinitionId: 253487c0-2246-43ba-a21f-5116b20a2c50
254254
dockerRepository: airbyte/source-google-ads
255-
dockerImageTag: 0.1.23
255+
dockerImageTag: 0.1.24
256256
documentationUrl: https://docs.airbyte.io/integrations/sources/google-ads
257257
icon: google-adwords.svg
258258
sourceType: api

airbyte-config/init/src/main/resources/seed/source_specs.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -2294,7 +2294,7 @@
22942294
supportsNormalization: false
22952295
supportsDBT: false
22962296
supported_destination_sync_modes: []
2297-
- dockerImage: "airbyte/source-google-ads:0.1.23"
2297+
- dockerImage: "airbyte/source-google-ads:0.1.24"
22982298
spec:
22992299
documentationUrl: "https://docs.airbyte.com/integrations/sources/google-ads"
23002300
connectionSpecification:

airbyte-integrations/connectors/source-google-ads/Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,5 @@ RUN pip install .
1313

1414
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]
1515

16-
LABEL io.airbyte.version=0.1.23
16+
LABEL io.airbyte.version=0.1.24
1717
LABEL io.airbyte.name=airbyte/source-google-ads

airbyte-integrations/connectors/source-google-ads/setup.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
from setuptools import find_packages, setup
77

8-
MAIN_REQUIREMENTS = ["airbyte-cdk~=0.1", "google-ads==13.0.0", "pendulum"]
8+
MAIN_REQUIREMENTS = ["airbyte-cdk~=0.1", "google-ads==14.1.0", "pendulum"]
99

1010
TEST_REQUIREMENTS = ["pytest~=6.1", "pytest-mock"]
1111

airbyte-integrations/connectors/source-google-ads/source_google_ads/schemas/ad_group_ads.json

-12
Original file line numberDiff line numberDiff line change
@@ -479,9 +479,6 @@
479479
"type": "string"
480480
}
481481
},
482-
"ad_group_ad.ad.video_ad.bumper.companion_banner": {
483-
"type": ["null", "string"]
484-
},
485482
"ad_group_ad.ad.video_ad.discovery.description1": {
486483
"type": ["null", "string"]
487484
},
@@ -497,15 +494,6 @@
497494
"ad_group_ad.ad.video_ad.in_stream.action_headline": {
498495
"type": ["null", "string"]
499496
},
500-
"ad_group_ad.ad.video_ad.in_stream.companion_banner": {
501-
"type": ["null", "string"]
502-
},
503-
"ad_group_ad.ad.video_ad.media_file": {
504-
"type": ["null", "string"]
505-
},
506-
"ad_group_ad.ad.video_ad.non_skippable.companion_banner": {
507-
"type": ["null", "string"]
508-
},
509497
"ad_group_ad.ad.video_ad.out_stream.description": {
510498
"type": ["null", "string"]
511499
},

airbyte-integrations/connectors/source-google-ads/source_google_ads/source.py

+3
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,9 @@ class SourceGoogleAds(AbstractSource):
3535
@staticmethod
3636
def get_credentials(config: Mapping[str, Any]) -> Mapping[str, Any]:
3737
credentials = config["credentials"]
38+
# use_proto_plus is set to True, because setting to False returned wrong value types, which breakes the backward compatibility.
39+
# For more info read the related PR's description: https://github.com/airbytehq/airbyte/pull/9996
40+
credentials.update(use_proto_plus=True)
3841

3942
# https://developers.google.com/google-ads/api/docs/concepts/call-structure#cid
4043
if "login_customer_id" in config and config["login_customer_id"].strip():

docs/integrations/sources/google-ads.md

+1
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,7 @@ This source is constrained by whatever API limits are set for the Google Ads tha
102102

103103
| Version | Date | Pull Request | Subject |
104104
| :--- | :--- | :--- | :--- |
105+
| `0.1.24` | 2022-02-04 | [9996](https://github.com/airbytehq/airbyte/pull/9996) | Use Google Ads API version V9. |
105106
| `0.1.23` | 2022-01-25 | [8669](https://github.com/airbytehq/airbyte/pull/8669) | Add end date parameter in spec. |
106107
| `0.1.22` | 2022-01-24 | [9608](https://github.com/airbytehq/airbyte/pull/9608) | Reduce stream slice date range. |
107108
| `0.1.21` | 2021-12-28 | [9149](https://github.com/airbytehq/airbyte/pull/9149) | Update title and description |

0 commit comments

Comments
 (0)