Skip to content

Commit d418f9c

Browse files
authored
Update fields in source-connectors specifications: notion (#9207)
1 parent 74cb28e commit d418f9c

File tree

9 files changed

+25
-10
lines changed

9 files changed

+25
-10
lines changed

airbyte-config/init/src/main/resources/config/STANDARD_SOURCE_DEFINITION/6e00b415-b02e-4160-bf02-58176a0ae687.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"sourceDefinitionId": "6e00b415-b02e-4160-bf02-58176a0ae687",
33
"name": "Notion",
44
"dockerRepository": "airbyte/source-notion",
5-
"dockerImageTag": "0.1.0",
5+
"dockerImageTag": "0.1.1",
66
"documentationUrl": "https://hub.docker.com/r/airbyte/source-notion",
77
"icon": "notion.svg"
88
}

airbyte-config/init/src/main/resources/seed/source_definitions.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -447,7 +447,7 @@
447447
- name: Notion
448448
sourceDefinitionId: 6e00b415-b02e-4160-bf02-58176a0ae687
449449
dockerRepository: airbyte/source-notion
450-
dockerImageTag: 0.1.0
450+
dockerImageTag: 0.1.1
451451
documentationUrl: https://docs.airbyte.io/integrations/sources/notion
452452
icon: notion.svg
453453
sourceType: api

airbyte-config/init/src/main/resources/seed/source_specs.yaml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4716,7 +4716,7 @@
47164716
supportsNormalization: false
47174717
supportsDBT: false
47184718
supported_destination_sync_modes: []
4719-
- dockerImage: "airbyte/source-notion:0.1.0"
4719+
- dockerImage: "airbyte/source-notion:0.1.1"
47204720
spec:
47214721
documentationUrl: "https://docsurl.com"
47224722
connectionSpecification:
@@ -4730,11 +4730,13 @@
47304730
properties:
47314731
access_token:
47324732
type: "string"
4733+
title: "Access Token"
47334734
description: "Notion API access token, see the <a href=\"https://developers.notion.com/docs/authorization\"\
47344735
>docs</a> for more information on how to obtain this token."
47354736
airbyte_secret: true
47364737
start_date:
47374738
type: "string"
4739+
title: "Start Date"
47384740
description: "The date from which you'd like to replicate data for Notion\
47394741
\ API, in the format YYYY-MM-DDT00:00:00.000Z. All data generated after\
47404742
\ this date will be replicated."

airbyte-integrations/connectors/source-notion/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,5 +34,5 @@ COPY source_notion ./source_notion
3434
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
3535
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]
3636

37-
LABEL io.airbyte.version=0.1.0
37+
LABEL io.airbyte.version=0.1.1
3838
LABEL io.airbyte.name=airbyte/source-notion

airbyte-integrations/connectors/source-notion/README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,8 @@ Customize `acceptance-test-config.yml` file to configure tests. See [Source Acce
102102
If your connector requires to create or destroy resources for use during acceptance tests create fixtures for it and place them inside integration_tests/acceptance.py.
103103
To run your integration tests with acceptance tests, from the connector root, run
104104
```
105-
python -m pytest integration_tests -p integration_tests.acceptance
105+
docker build . --no-cache -t airbyte/source-notion:dev \
106+
&& python -m pytest -p source_acceptance_test.plugin
106107
```
107108
To run your integration tests with docker
108109

airbyte-integrations/connectors/source-notion/source_notion/schemas/pages.json

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,13 +29,13 @@
2929
},
3030
"properties": {
3131
"type": "object",
32-
"additionalProperties": false,
32+
"additionalProperties": true,
3333
"patternProperties": {
3434
".*": {
3535
"anyOf": [
3636
{
3737
"type": "object",
38-
"additionalProperties": false,
38+
"additionalProperties": true,
3939
"patternProperties": {
4040
"^id$": { "type": "string" },
4141
"^type$": { "enum": ["title", "rich_text"] },
@@ -80,6 +80,14 @@
8080
"date": { "$ref": "date.json" }
8181
}
8282
},
83+
{
84+
"type": "object",
85+
"properties": {
86+
"id": { "type": "string" },
87+
"type": { "enum": ["date"] },
88+
"date": { "$ref": "date.json" }
89+
}
90+
},
8391
{
8492
"type": "object",
8593
"properties": {
Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
{
22
"$schema": "http://json-schema.org/draft-04/schema#",
33
"type": ["null", "object"],
4-
"additionalProperties": false,
4+
"additionalProperties": true,
55
"properties": {
6-
"start": { "type": "string" },
7-
"end": { "type": ["null", "string"] }
6+
"start": { "type": ["null", "string"] },
7+
"end": { "type": ["null", "string"] },
8+
"time_zone": { "type": ["null", "string"] }
89
}
910
}

airbyte-integrations/connectors/source-notion/source_notion/spec.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,13 @@
99
"properties": {
1010
"access_token": {
1111
"type": "string",
12+
"title": "Access Token",
1213
"description": "Notion API access token, see the <a href=\"https://developers.notion.com/docs/authorization\">docs</a> for more information on how to obtain this token.",
1314
"airbyte_secret": true
1415
},
1516
"start_date": {
1617
"type": "string",
18+
"title": "Start Date",
1719
"description": "The date from which you'd like to replicate data for Notion API, in the format YYYY-MM-DDT00:00:00.000Z. All data generated after this date will be replicated.",
1820
"examples": ["2020-11-16T00:00:00.000Z"],
1921
"pattern": "^[0-9]{4}-[0-9]{2}-[0-9]{2}T[0-9]{2}:[0-9]{2}:[0-9]{2}.[0-9]{3}Z$"

docs/integrations/sources/notion.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ Please register on Notion and follow this [docs](https://developers.notion.com/d
5757

5858
| Version | Date | Pull Request | Subject |
5959
| :--- | :--- | :--- | :--- |
60+
| 0.1.1 | 2021-12-30 | [9207](https://github.com/airbytehq/airbyte/pull/9207) | Update connector fields title/description |
6061
| 0.1.0 | 2021-10-17 | [7092](https://github.com/airbytehq/airbyte/pull/7092) | Initial Release |
6162

6263

0 commit comments

Comments
 (0)