Skip to content

Commit cb6bf8b

Browse files
authored
live-test: disable SortQueryParams addon (#44806)
1 parent 63ab010 commit cb6bf8b

File tree

3 files changed

+11
-2
lines changed

3 files changed

+11
-2
lines changed

airbyte-ci/connectors/live-tests/README.md

+4
Original file line numberDiff line numberDiff line change
@@ -279,6 +279,10 @@ The traffic recorded on the control connector is passed to the target connector
279279

280280
## Changelog
281281

282+
### 0.18.6
283+
284+
Disable the `SortQueryParams` MITM proxy addon to avoid double URL encoding.
285+
282286
### 0.18.5
283287

284288
Relax test_oneof_usage criteria for constant value definitions in connector SPEC output.

airbyte-ci/connectors/live-tests/pyproject.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ build-backend = "poetry.core.masonry.api"
44

55
[tool.poetry]
66
name = "live-tests"
7-
version = "0.18.5"
7+
version = "0.18.6"
88
description = "Contains utilities for testing connectors against live data."
99
authors = ["Airbyte <[email protected]>"]
1010
license = "MIT"

airbyte-ci/connectors/live-tests/src/live_tests/commons/mitm_addons.py

+6-1
Original file line numberDiff line numberDiff line change
@@ -25,4 +25,9 @@ def request(self, flow: http.HTTPFlow) -> None:
2525
flow.request.url = sorted_url
2626

2727

28-
addons = [SortQueryParams()]
28+
# Disabling the addon.
29+
# It can alter the request URL when some connector URL are already encoded.
30+
# See discussion here https://github.com/airbytehq/airbyte-internal-issues/issues/9302#issuecomment-2311854334
31+
32+
# addons = [SortQueryParams()]
33+
addons = []

0 commit comments

Comments
 (0)