Clean up breaking changes check

Author: natikgadzhi

airbyte-ci/connectors/connectors_qa/pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "connectors-qa"
-version = "1.0.3"
+version = "1.0.4"
 description = "A package to run QA checks on Airbyte connectors, generate reports and documentation."
 authors = ["Airbyte <[email protected]>"]
 readme = "README.md"
@@ -43,10 +43,3 @@ lint = "ruff check src"
 extra_poetry_groups = ["dev"]
 poe_tasks = ["type_check", "lint", "test"]
 required_environment_variables = ["DOCKER_HUB_USERNAME", "DOCKER_HUB_PASSWORD"]
-
-[tool.pyright]
-reportMissingImports = true
-reportMissingTypeStubs = false
-pythonVersion = "3.10"
-venvPath = "."
-venv = ".venv"

airbyte-ci/connectors/connectors_qa/src/connectors_qa/checks/metadata.py

@@ -10,6 +10,7 @@
 from connectors_qa.models import Check, CheckCategory, CheckResult
 from metadata_service.validators.metadata_validator import PRE_UPLOAD_VALIDATORS, ValidatorOptions, validate_and_load  # type: ignore
 
+import pydash
 
 class MetadataCheck(Check):
     category = CheckCategory.METADATA
@@ -99,7 +100,7 @@ class ValidateBreakingChangesDeadlines(MetadataCheck):
     it's deadline is at least a week in the future.
     """
     name = "Breaking change opt-in should be a week in the future"
-    description = f"If the connector version has a breaking change, the deadline field must be set to at least a week in the future."
+    description = "If the connector version has a breaking change, the deadline field must be set to at least a week in the future."
 
     def _run(self, connector: Connector) -> CheckResult:
 
@@ -113,43 +114,38 @@ def _run(self, connector: Connector) -> CheckResult:
                 message="Can't verify breaking changes deadline: connector version is not defined.",
             )
 
-        breaking_changes = connector.metadata['releases']['breakingChanges']
+        breaking_changes = pydash.get(connector.metadata, "releases.breakingChanges", [])
 
         if breaking_changes is None or len(breaking_changes) == 0:
             return self.pass_(
                 connector=connector,
                 message="No breaking changes found.",
             )
 
-        current_version_brekaking_changes = breaking_changes.get(current_version)
-
-        if current_version_brekaking_changes is None:
+        current_version_breaking_changes = breaking_changes.get(current_version)
+        if current_version_breaking_changes is None:
             return self.pass_(
                 connector=connector,
                 message="No breaking changes found for the current version.",
             )
 
-        upgrade_deadline = current_version_brekaking_changes.get('upgradeDeadline')
-
+        upgrade_deadline = current_version_breaking_changes.get("upgradeDeadline")
         if upgrade_deadline is None:
             return self.fail(
                 connector=connector,
                 message=f"No upgrade deadline found for the breaking changes in {current_version}.",
             )
 
         upgrade_deadline_datetime = datetime.strptime(upgrade_deadline, "%Y-%m-%d")
-        one_week_from_now = datetime.now() + timedelta(weeks=1)
+        one_week_from_now = datetime.utcnow() + timedelta(weeks=1)
 
         if upgrade_deadline_datetime < one_week_from_now:
             return self.fail(
                 connector=connector,
                 message=f"The upgrade deadline for the breaking changes in {current_version} is less than 7 days from today. Please extend the deadline.",
             )
 
-        return self.pass_(
-            connector=connector,
-            message="okay",
-        )
+        return self.pass_(connector=connector, message="The upgrade deadline is set to at least a week in the future")
 
 
 ENABLED_CHECKS = [