Skip to content

Commit be6b5ef

Browse files
author
Marius Posta
authored
bulk-cdk-toolkits-extract-jdbc: noop JdbcCheckQueries when no queries defined (#44842)
1 parent f85baeb commit be6b5ef

File tree

3 files changed

+8
-2
lines changed

3 files changed

+8
-2
lines changed

airbyte-cdk/bulk/toolkits/extract-jdbc/src/main/kotlin/io/airbyte/cdk/check/JdbcCheckQueries.kt

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ const val CHECK_QUERIES_PREFIX = "airbyte.connector.check.jdbc"
3030
class JdbcCheckQueries {
3131

3232
// Micronaut configuration objects work better with mutable properties.
33-
lateinit var queries: List<String>
33+
protected var queries: List<String> = emptyList()
3434

3535
private val log = KotlinLogging.logger {}
3636

airbyte-cdk/bulk/toolkits/extract-jdbc/src/test/kotlin/io/airbyte/cdk/check/JdbcCheckQueriesTest.kt

+6
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,12 @@ class JdbcCheckQueriesTest {
2121

2222
@Inject lateinit var checkQueries: JdbcCheckQueries
2323

24+
@Test
25+
fun testEmpty() {
26+
val empty = JdbcCheckQueries()
27+
Assertions.assertDoesNotThrow { h2.createConnection().use { empty.executeAll(it) } }
28+
}
29+
2430
@Test
2531
@Property(name = "$Q[0]", value = "SELECT DATABASE_PATH() FROM DUAL")
2632
fun testPass() {

airbyte-cdk/bulk/toolkits/extract-jdbc/src/test/kotlin/io/airbyte/cdk/discover/JdbcMetadataQuerierTest.kt

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ class JdbcMetadataQuerierTest {
2323
JdbcMetadataQuerier.Factory(
2424
selectQueryGenerator = H2SourceOperations(),
2525
fieldTypeMapper = H2SourceOperations(),
26-
checkQueries = JdbcCheckQueries().apply { queries = listOf() },
26+
checkQueries = JdbcCheckQueries(),
2727
constants = DefaultJdbcConstants(),
2828
)
2929

0 commit comments

Comments
 (0)