Skip to content

Commit bc22519

Browse files
midavadimgl-pix
authored andcommitted
🎉 Source mixpanel: migration to CDK (#4566)
* Mixpanel initiation * copied schemas and specs file from singer connector * authentication and a few streams * Added Funnels + FunnelsList * Added example of funnel response * added incremental Funnels stream with tests * added Annotations, CohortMembers, Engage, Cohorts, Funnels * added Revenue * fixed formatting * fixed variable names * fixed cohort_members and updated export streams * moved start_date and date checks into SourceMixpanel class * added error handling * added unit test, update docs and ci creds * fix url base for export stream * added full and incremental read for export stream * updated acceptance tests, added limit correction based on number of streams, export cursor is stored in datatime string * Funnel stream - added complex state which contains state for each funnel * added attribution windows support and project timezone config * fixed formatting * added default timezone * added dynamic schema generation for Engage and Export streams * fixed formatting * fixed ability to pass start_date in datetime format as well * fixed ability to pass start_date in datetime format as well * added additional_properties field for dynamic schemas. updates regex for start_date matching to support old config file * fixed formatting * export stream - convert all values to default type - string * added schema ref * added new properties for funnel stream * fixed formatting in funnel schema * added build related files * update changelog * fixed and added comments, renamed rate_limit variable * fixed formatting * changed normalization for reserved mixpanel attributes like $browser * alphabetise spec fields * added description about API limit handling * updated comment
1 parent 4eecba3 commit bc22519

40 files changed

+1838
-6
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
{
2+
"sourceDefinitionId": "12928b32-bf0a-4f1e-964f-07e12e37153a",
3+
"name": "Mixpanel",
4+
"dockerRepository": "airbyte/source-mixpanel",
5+
"dockerImageTag": "0.1.0",
6+
"documentationUrl": "https://hub.docker.com/r/airbyte/source-mixpanel",
7+
"icon": "mixpanel.svg"
8+
}

airbyte-config/init/src/main/resources/config/STANDARD_SOURCE_DEFINITION/859e501d-2b67-471f-91bb-1c801414d28f.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"sourceDefinitionId": "859e501d-2b67-471f-91bb-1c801414d28f",
3-
"name": "Mixpanel",
3+
"name": "Mixpanel Singer",
44
"dockerRepository": "airbyte/source-mixpanel-singer",
55
"dockerImageTag": "0.2.4",
66
"documentationUrl": "https://hub.docker.com/r/airbyte/source-mixpanel-singer",

airbyte-config/init/src/main/resources/seed/source_definitions.yaml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,8 +199,14 @@
199199
dockerImageTag: 0.2.6
200200
documentationUrl: https://hub.docker.com/r/airbyte/source-jira
201201
icon: jira.svg
202-
- sourceDefinitionId: 859e501d-2b67-471f-91bb-1c801414d28f
202+
- sourceDefinitionId: 12928b32-bf0a-4f1e-964f-07e12e37153a
203203
name: Mixpanel
204+
dockerRepository: airbyte/source-mixpanel
205+
dockerImageTag: 0.1.0
206+
documentationUrl: https://hub.docker.com/r/airbyte/source-mixpanel
207+
icon: mixpanel.svg
208+
- sourceDefinitionId: 859e501d-2b67-471f-91bb-1c801414d28f
209+
name: Mixpanel Singer
204210
dockerRepository: airbyte/source-mixpanel-singer
205211
dockerImageTag: 0.2.4
206212
documentationUrl: https://hub.docker.com/r/airbyte/source-mixpanel-singer

airbyte-integrations/builds.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,9 @@
7171

7272
Microsoft Teams [![source-microsoft-teams](https://img.shields.io/endpoint?url=https%3A%2F%2Fairbyte-connector-build-status.s3-website.us-east-2.amazonaws.com%2Ftests%2Fsummary%2Fsource-microsoft-teams%2Fbadge.json)](https://airbyte-connector-build-status.s3-website.us-east-2.amazonaws.com/tests/summary/source-microsoft-teams)
7373

74-
Mixpanel [![source-mixpanel-singer](https://img.shields.io/endpoint?url=https%3A%2F%2Fairbyte-connector-build-status.s3-website.us-east-2.amazonaws.com%2Ftests%2Fsummary%2Fsource-mixpanel-singer%2Fbadge.json)](https://airbyte-connector-build-status.s3-website.us-east-2.amazonaws.com/tests/summary/source-mixpanel-singer)
74+
Mixpanel [![source-mixpanel](https://img.shields.io/endpoint?url=https%3A%2F%2Fstatus-api.airbyte.io%2Ftests%2Fsummary%2Fsource-mixpanel%2Fbadge.json)](https://status-api.airbyte.io/tests/summary/source-mixpanel)
75+
76+
Mixpanel Singer [![source-mixpanel-singer](https://img.shields.io/endpoint?url=https%3A%2F%2Fstatus-api.airbyte.io%2Ftests%2Fsummary%2Fsource-mixpanel-singer%2Fbadge.json)](https://status-api.airbyte.io/tests/summary/source-mixpanel-singer)
7577

7678
Mongo DB [![source-mongodb](https://img.shields.io/endpoint?url=https%3A%2F%2Fairbyte-connector-build-status.s3-website.us-east-2.amazonaws.com%2Ftests%2Fsummary%2Fsource-mongodb%2Fbadge.json)](https://airbyte-connector-build-status.s3-website.us-east-2.amazonaws.com/tests/summary/source-mongodb)
7779

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
*
2+
!Dockerfile
3+
!Dockerfile.test
4+
!main.py
5+
!source_mixpanel
6+
!setup.py
7+
!secrets
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
FROM python:3.7-slim
2+
3+
# Bash is installed for more convenient debugging.
4+
RUN apt-get update && apt-get install -y bash && rm -rf /var/lib/apt/lists/*
5+
6+
WORKDIR /airbyte/integration_code
7+
COPY source_mixpanel ./source_mixpanel
8+
COPY main.py ./
9+
COPY setup.py ./
10+
RUN pip install .
11+
12+
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
13+
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]
14+
15+
LABEL io.airbyte.version=0.1.0
16+
LABEL io.airbyte.name=airbyte/source-mixpanel
Lines changed: 131 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,131 @@
1+
# Mixpanel Source
2+
3+
This is the repository for the Mixpanel source connector, written in Python.
4+
For information about how to use this connector within Airbyte, see [the documentation](https://docs.airbyte.io/integrations/sources/mixpanel).
5+
6+
## Local development
7+
8+
### Prerequisites
9+
**To iterate on this connector, make sure to complete this prerequisites section.**
10+
11+
#### Minimum Python version required `= 3.7.0`
12+
13+
#### Build & Activate Virtual Environment and install dependencies
14+
From this connector directory, create a virtual environment:
15+
```
16+
python -m venv .venv
17+
```
18+
19+
This will generate a virtualenv for this module in `.venv/`. Make sure this venv is active in your
20+
development environment of choice. To activate it from the terminal, run:
21+
```
22+
source .venv/bin/activate
23+
pip install -r requirements.txt
24+
```
25+
If you are in an IDE, follow your IDE's instructions to activate the virtualenv.
26+
27+
Note that while we are installing dependencies from `requirements.txt`, you should only edit `setup.py` for your dependencies. `requirements.txt` is
28+
used for editable installs (`pip install -e`) to pull in Python dependencies from the monorepo and will call `setup.py`.
29+
If this is mumbo jumbo to you, don't worry about it, just put your deps in `setup.py` but install using `pip install -r requirements.txt` and everything
30+
should work as you expect.
31+
32+
#### Building via Gradle
33+
You can also build the connector in Gradle. This is typically used in CI and not needed for your development workflow.
34+
35+
To build using Gradle, from the Airbyte repository root, run:
36+
```
37+
./gradlew :airbyte-integrations:connectors:source-mixpanel:build
38+
```
39+
40+
#### Create credentials
41+
**If you are a community contributor**, follow the instructions in the [documentation](https://docs.airbyte.io/integrations/sources/mixpanel)
42+
to generate the necessary credentials. Then create a file `secrets/config.json` conforming to the `source_mixpanel/spec.json` file.
43+
Note that any directory named `secrets` is gitignored across the entire Airbyte repo, so there is no danger of accidentally checking in sensitive information.
44+
See `integration_tests/sample_config.json` for a sample config file.
45+
46+
**If you are an Airbyte core member**, copy the credentials in Lastpass under the secret name `source mixpanel test creds`
47+
and place them into `secrets/config.json`.
48+
49+
### Locally running the connector
50+
```
51+
python main.py spec
52+
python main.py check --config secrets/config.json
53+
python main.py discover --config secrets/config.json
54+
python main.py read --config secrets/config.json --catalog integration_tests/configured_catalog.json
55+
```
56+
57+
### Locally running the connector docker image
58+
59+
#### Build
60+
First, make sure you build the latest Docker image:
61+
```
62+
docker build . -t airbyte/source-mixpanel:dev
63+
```
64+
65+
You can also build the connector image via Gradle:
66+
```
67+
./gradlew :airbyte-integrations:connectors:source-mixpanel:airbyteDocker
68+
```
69+
When building via Gradle, the docker image name and tag, respectively, are the values of the `io.airbyte.name` and `io.airbyte.version` `LABEL`s in
70+
the Dockerfile.
71+
72+
#### Run
73+
Then run any of the connector commands as follows:
74+
```
75+
docker run --rm airbyte/source-mixpanel:dev spec
76+
docker run --rm -v $(pwd)/secrets:/secrets airbyte/source-mixpanel:dev check --config /secrets/config.json
77+
docker run --rm -v $(pwd)/secrets:/secrets airbyte/source-mixpanel:dev discover --config /secrets/config.json
78+
docker run --rm -v $(pwd)/secrets:/secrets -v $(pwd)/integration_tests:/integration_tests airbyte/source-mixpanel:dev read --config /secrets/config.json --catalog /integration_tests/configured_catalog.json
79+
```
80+
## Testing
81+
Make sure to familiarize yourself with [pytest test discovery](https://docs.pytest.org/en/latest/goodpractices.html#test-discovery) to know how your test files and methods should be named.
82+
First install test dependencies into your virtual environment:
83+
```
84+
pip install .[tests]
85+
```
86+
### Unit Tests
87+
To run unit tests locally, from the connector directory run:
88+
```
89+
python -m pytest unit_tests
90+
```
91+
92+
### Integration Tests
93+
There are two types of integration tests: Acceptance Tests (Airbyte's test suite for all source connectors) and custom integration tests (which are specific to this connector).
94+
#### Custom Integration tests
95+
Place custom tests inside `integration_tests/` folder, then, from the connector root, run
96+
```
97+
python -m pytest integration_tests
98+
```
99+
#### Acceptance Tests
100+
Customize `acceptance-test-config.yml` file to configure tests. See [Source Acceptance Tests](source-acceptance-tests.md) for more information.
101+
If your connector requires to create or destroy resources for use during acceptance tests create fixtures for it and place them inside integration_tests/acceptance.py.
102+
To run your integration tests with acceptance tests, from the connector root, run
103+
```
104+
python -m pytest integration_tests -p integration_tests.acceptance
105+
```
106+
To run your integration tests with docker
107+
108+
### Using gradle to run tests
109+
All commands should be run from airbyte project root.
110+
To run unit tests:
111+
```
112+
./gradlew :airbyte-integrations:connectors:source-mixpanel:unitTest
113+
```
114+
To run acceptance and custom integration tests:
115+
```
116+
./gradlew :airbyte-integrations:connectors:source-mixpanel:integrationTest
117+
```
118+
119+
## Dependency Management
120+
All of your dependencies should go in `setup.py`, NOT `requirements.txt`. The requirements file is only used to connect internal Airbyte dependencies in the monorepo for local development.
121+
We split dependencies between two groups, dependencies that are:
122+
* required for your connector to work need to go to `MAIN_REQUIREMENTS` list.
123+
* required for the testing need to go to `TEST_REQUIREMENTS` list
124+
125+
### Publishing a new version of the connector
126+
You've checked out the repo, implemented a million dollar feature, and you're ready to share your changes with the world. Now what?
127+
1. Make sure your changes are passing unit and integration tests.
128+
1. Bump the connector version in `Dockerfile` -- just increment the value of the `LABEL io.airbyte.version` appropriately (we use [SemVer](https://semver.org/)).
129+
1. Create a Pull Request.
130+
1. Pat yourself on the back for being an awesome contributor.
131+
1. Someone from Airbyte will take a look at your PR and iterate with you to merge it into master.
Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
# See [Source Acceptance Tests](https://docs.airbyte.io/contributing-to-airbyte/building-new-connector/source-acceptance-tests.md)
2+
# for more information about how to configure these tests
3+
connector_image: airbyte/source-mixpanel:dev
4+
tests:
5+
spec:
6+
- spec_path: "source_mixpanel/spec.json"
7+
connection:
8+
- config_path: "secrets/config.json"
9+
status: "succeed"
10+
- config_path: "integration_tests/invalid_config.json"
11+
status: "failed"
12+
discovery:
13+
- config_path: "secrets/config.json"
14+
basic_read:
15+
- config_path: "secrets/config.json"
16+
configured_catalog_path: "integration_tests/configured_catalog.json"
17+
validate_output_from_all_streams: yes
18+
full_refresh:
19+
- config_path: "secrets/config.json"
20+
configured_catalog_path: "integration_tests/configured_catalog.json"
21+
incremental:
22+
# incremental streams Funnels, Revenue, Export
23+
# Funnels - fails because it has complex state, like {'funnel_idX': {'date': 'dateX'}}
24+
# Export - fails because it could return a few previous records for the date of previous sync
25+
- config_path: "secrets/config.json"
26+
configured_catalog_path: "integration_tests/configured_catalog_incremental.json"
27+
# Test is skipped because requests fails when start_date is in the future
28+
# Incremental streams Funnels, Revenue always return data for any valid date
29+
# future_state_path: "integration_tests/abnormal_state.json"
30+
cursor_paths:
31+
revenue: ["date"]
32+
export: ["date"]
33+
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
#!/usr/bin/env sh
2+
docker run --rm -it \
3+
-v /var/run/docker.sock:/var/run/docker.sock \
4+
-v /tmp:/tmp \
5+
-v $(pwd):/test_input \
6+
airbyte/source-acceptance-test \
7+
--acceptance-test-config /test_input
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
plugins {
2+
id 'airbyte-python'
3+
id 'airbyte-docker'
4+
id 'airbyte-source-acceptance-test'
5+
}
6+
7+
airbytePython {
8+
moduleDirectory 'source_mixpanel'
9+
}
10+
11+
dependencies {
12+
implementation files(project(':airbyte-integrations:bases:source-acceptance-test').airbyteDocker.outputs)
13+
implementation files(project(':airbyte-integrations:bases:base-python').airbyteDocker.outputs)
14+
}

0 commit comments

Comments
 (0)