Skip to content

Commit bab6b13

Browse files
committed
Merge branch 'master' into marcos/test-pr-10655
2 parents 5fddcd6 + a4e8417 commit bab6b13

File tree

10 files changed

+97
-52
lines changed

10 files changed

+97
-52
lines changed

airbyte-api/src/main/openapi/config.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2910,9 +2910,9 @@ components:
29102910
OperationIdRequestBody:
29112911
type: object
29122912
required:
2913-
- OperationId
2913+
- operationId
29142914
properties:
2915-
OperationId:
2915+
operationId:
29162916
$ref: "#/components/schemas/OperationId"
29172917
OperationCreate:
29182918
type: object

airbyte-integrations/connectors/destination-snowflake/src/main/resources/spec.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@
2020
"additionalProperties": true,
2121
"properties": {
2222
"host": {
23-
"description": "The host domain of the snowflake instance (must include the account, region, cloud environment, and end with snowflakecomputing.com).",
24-
"examples": ["accountname.us-east-2.aws.snowflakecomputing.com"],
23+
"description": "The host domain of the snowflake instance (must include the account, region, cloud environment, and end with snowflakecomputing.com). The account identifier differs depending on your cloud region, be sure to verify with Snowflake's documentation.",
24+
"examples": ["accountname.us-east-2.aws.snowflakecomputing.com", "accountname.snowflakecomputing.com"],
2525
"type": "string",
2626
"title": "Host",
2727
"order": 0

airbyte-webapp/src/components/Table/Table.tsx

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,16 @@ import {
1111

1212
import { Card } from "components";
1313

14+
type PaddingProps = {
15+
left?: number;
16+
right?: number;
17+
};
18+
1419
type IHeaderProps = {
1520
headerHighlighted?: boolean;
1621
collapse?: boolean;
1722
customWidth?: number;
23+
customPadding?: PaddingProps;
1824
} & ColumnInstance;
1925

2026
type ICellProps = {
@@ -25,6 +31,7 @@ type IThProps = {
2531
highlighted?: boolean;
2632
collapse?: boolean;
2733
customWidth?: number;
34+
customPadding?: PaddingProps;
2835
light?: boolean;
2936
} & React.ThHTMLAttributes<HTMLTableHeaderCellElement>;
3037

@@ -47,8 +54,13 @@ const Tr = styled.tr<{
4754
cursor: ${({ hasClick }) => (hasClick ? "pointer" : "auto")};
4855
`;
4956

50-
const Td = styled.td<{ collapse?: boolean; customWidth?: number }>`
51-
padding: 16px 13px;
57+
const Td = styled.td<{
58+
collapse?: boolean;
59+
customWidth?: number;
60+
customPadding?: PaddingProps;
61+
}>`
62+
padding: ${({ customPadding }) =>
63+
`16px ${customPadding?.right ?? 13}px 16px ${customPadding?.left ?? 13}px`};
5264
font-size: 12px;
5365
line-height: 15px;
5466
font-weight: normal;
@@ -75,7 +87,8 @@ const Td = styled.td<{ collapse?: boolean; customWidth?: number }>`
7587

7688
const Th = styled.th<IThProps>`
7789
background: ${({ theme, light }) => (light ? "none" : theme.textColor)};
78-
padding: 9px 13px 10px;
90+
padding: ${({ customPadding }) =>
91+
`9px ${customPadding?.right ?? 13}px 10px ${customPadding?.left ?? 13}px`};
7992
text-align: left;
8093
font-size: ${({ light }) => (light ? 11 : 10)}px;
8194
line-height: 12px;
@@ -157,6 +170,7 @@ const Table: React.FC<IProps> = ({
157170
{...column.getHeaderProps()}
158171
highlighted={column.headerHighlighted}
159172
collapse={column.collapse}
173+
customPadding={column.customPadding}
160174
customWidth={column.customWidth}
161175
key={`table-column-${key}-${columnKey}`}
162176
light={light}
@@ -185,6 +199,7 @@ const Table: React.FC<IProps> = ({
185199
<Td
186200
{...cell.getCellProps()}
187201
collapse={cell.column.collapse}
202+
customPadding={cell.column.customPadding}
188203
customWidth={cell.column.customWidth}
189204
key={`table-cell-${row.id}-${key}`}
190205
>

airbyte-webapp/src/components/base/DropDown/components/SingleValue.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,14 @@ export type IProps = {
99
data?: IDataItem;
1010
} & SingleValueProps<OptionTypeBase>;
1111

12-
const ItemView = styled.div`
12+
export const ItemView = styled.div`
1313
display: flex;
1414
flex-direction: row;
1515
justify-content: left;
1616
align-items: center;
1717
`;
1818

19-
const Icon = styled.div`
19+
export const Icon = styled.div`
2020
margin-right: 6px;
2121
display: inline-block;
2222
`;

airbyte-webapp/src/packages/cloud/locales/en.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"login.loginTitle": "Sign in to Airbyte",
77
"login.lastStep": "One last step",
88
"login.confirmEmail": "Confirm your email address!",
9-
"login.confirmEmail.text": "We sent you a confirmation link to {email}. <br/>Please click on the link to access your new Airbyte account.",
9+
"login.confirmEmail.text": "We sent you a confirmation link to {email}. Please click on the link to access your new Airbyte account.",
1010
"login.resendEmail": "Didn’t receive the email? Send it again",
1111
"confirmEmail.signOut": "Entered the wrong email address? Start over",
1212
"login.yourEmail": "Your work email*",

airbyte-webapp/src/packages/cloud/views/credits/CreditsPage/components/UsageCell.tsx

Lines changed: 6 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -2,28 +2,13 @@ import React from "react";
22
import styled from "styled-components";
33

44
type ConnectionCellProps = {
5-
value: number;
65
percent: number;
76
};
87

9-
const Content = styled.div`
10-
display: flex;
11-
flex-direction: row;
12-
align-items: center;
13-
`;
14-
15-
const Value = styled.div`
16-
padding-right: 10px;
17-
font-weight: 500;
18-
font-size: 14px;
19-
line-height: 17px;
20-
flex: 1 0 0;
21-
min-width: 50px;
22-
`;
23-
248
const Bar = styled.div`
259
height: 10px;
2610
width: 100%;
11+
min-width: 150px;
2712
background: ${({ theme }) => theme.greyColor20};
2813
flex: 10 0 0;
2914
overflow: hidden;
@@ -37,15 +22,10 @@ const Full = styled.div<{ percent: number }>`
3722
opacity: 0.5;
3823
`;
3924

40-
const UsageCell: React.FC<ConnectionCellProps> = ({ value, percent }) => {
41-
return (
42-
<Content>
43-
<Value>{value}</Value>
44-
<Bar>
45-
<Full percent={percent} />
46-
</Bar>
47-
</Content>
48-
);
49-
};
25+
const UsageCell: React.FC<ConnectionCellProps> = ({ percent }) => (
26+
<Bar>
27+
<Full percent={percent} />
28+
</Bar>
29+
);
5030

5131
export default UsageCell;

airbyte-webapp/src/packages/cloud/views/credits/CreditsPage/components/UsagePerConnectionTable.tsx

Lines changed: 20 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,14 @@ const Content = styled.div`
1818
padding: 0 60px 0 15px;
1919
`;
2020

21+
const UsageValue = styled.div`
22+
font-weight: 500;
23+
font-size: 14px;
24+
line-height: 17px;
25+
padding-right: 10px;
26+
min-width: 53px;
27+
`;
28+
2129
type UsagePerConnectionTableProps = {
2230
creditConsumption: CreditConsumptionByConnector[];
2331
};
@@ -144,11 +152,18 @@ const UsagePerConnectionTable: React.FC<UsagePerConnectionTableProps> = ({
144152
</>
145153
),
146154
accessor: "creditsConsumed",
147-
Cell: ({ cell, row }: CellProps<FullTableProps>) => (
148-
<UsageCell
149-
value={cell.value}
150-
percent={row.original.creditsConsumedPercent}
151-
/>
155+
collapse: true,
156+
customPadding: { right: 0 },
157+
Cell: ({ cell }: CellProps<FullTableProps>) => (
158+
<UsageValue>{cell.value}</UsageValue>
159+
),
160+
},
161+
{
162+
Header: "",
163+
accessor: "creditsConsumedPercent",
164+
customPadding: { left: 0 },
165+
Cell: ({ cell }: CellProps<FullTableProps>) => (
166+
<UsageCell percent={cell.value} />
152167
),
153168
},
154169
// TODO: Replace to Grow column

airbyte-webapp/src/views/Connector/ServiceForm/components/Controls/ConnectorServiceTypeControl.tsx

Lines changed: 42 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,11 @@ import {
2727
IProps as OptionProps,
2828
OptionView,
2929
} from "components/base/DropDown/components/Option";
30+
import {
31+
IProps as SingleValueProps,
32+
Icon as SingleValueIcon,
33+
ItemView as SingleValueView,
34+
} from "components/base/DropDown/components/SingleValue";
3035

3136
const BottomElement = styled.div`
3237
background: ${(props) => props.theme.greyColro0};
@@ -70,6 +75,15 @@ const Stage = styled.div`
7075
color: ${({ theme }) => theme.textColor};
7176
`;
7277

78+
const SingleValueContent = styled(components.SingleValue)`
79+
width: 100%;
80+
padding-right: 38px;
81+
display: flex;
82+
flex-direction: row;
83+
justify-content: space-between;
84+
align-items: center;
85+
`;
86+
7387
type MenuWithRequestButtonProps = MenuListComponentProps<IDataItem, false>;
7488

7589
const ConnectorList: React.FC<MenuWithRequestButtonProps> = ({
@@ -88,6 +102,18 @@ const ConnectorList: React.FC<MenuWithRequestButtonProps> = ({
88102
</>
89103
);
90104

105+
const StageLabel: React.FC<{ releaseStage?: ReleaseStage }> = ({
106+
releaseStage,
107+
}) =>
108+
releaseStage && releaseStage !== ReleaseStage.GENERALLY_AVAILABLE ? (
109+
<Stage>
110+
<FormattedMessage
111+
id={`connector.releaseStage.${releaseStage}`}
112+
defaultMessage={releaseStage}
113+
/>
114+
</Stage>
115+
) : null;
116+
91117
const Option: React.FC<OptionProps> = (props) => {
92118
return (
93119
<components.Option {...props}>
@@ -100,20 +126,26 @@ const Option: React.FC<OptionProps> = (props) => {
100126
{props.data.img || null}
101127
<Label>{props.label}</Label>
102128
</Text>
103-
{props.data.releaseStage &&
104-
props.data.releaseStage !== ReleaseStage.GENERALLY_AVAILABLE ? (
105-
<Stage>
106-
<FormattedMessage
107-
id={`connector.releaseStage.${props.data.releaseStage}`}
108-
defaultMessage={props.data.releaseStage}
109-
/>
110-
</Stage>
111-
) : null}
129+
<StageLabel releaseStage={props.data.releaseStage} />
112130
</OptionView>
113131
</components.Option>
114132
);
115133
};
116134

135+
const SingleValue: React.FC<SingleValueProps> = (props) => {
136+
return (
137+
<SingleValueView>
138+
{props.data.img && <SingleValueIcon>{props.data.img}</SingleValueIcon>}
139+
<div>
140+
<SingleValueContent {...props}>
141+
{props.data.label}
142+
<StageLabel releaseStage={props.data.releaseStage} />
143+
</SingleValueContent>
144+
</div>
145+
</SingleValueView>
146+
);
147+
};
148+
117149
const ConnectorServiceTypeControl: React.FC<{
118150
property: FormBaseItem;
119151
formType: "source" | "destination";
@@ -198,6 +230,7 @@ const ConnectorServiceTypeControl: React.FC<{
198230
components={{
199231
MenuList: ConnectorList,
200232
Option,
233+
SingleValue,
201234
}}
202235
selectProps={{ onOpenRequestConnectorModal }}
203236
error={!!fieldMeta.error && fieldMeta.touched}

docs/integrations/destinations/snowflake.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,9 @@ commit;
111111

112112
You should now have all the requirements needed to configure Snowflake as a destination in the UI. You'll need the following information to configure the Snowflake destination:
113113

114-
* **[Host](https://docs.snowflake.com/en/user-guide/admin-account-identifier.html)** : The host domain of the snowflake instance (must include the account, region, cloud environment, and end with snowflakecomputing.com). Example - `accountname.us-east-2.aws.snowflakecomputing.com`
114+
* **[Host](https://docs.snowflake.com/en/user-guide/admin-account-identifier.html)** : The host domain of the snowflake instance (must include the account, region, cloud environment, and end with snowflakecomputing.com). Be sure to use the correct [account identifier format](https://docs.snowflake.com/en/user-guide/admin-account-identifier.html#account-identifier-formats-by-cloud-platform-and-region) based on the region you are in:
115+
* Example - us-west-1: `xy12345.snowflakecomputing.com`
116+
* Example - us-east-2: `xy12345.us-east-2.aws.snowflakecomputing.com`
115117
* **[Role](https://docs.snowflake.com/en/user-guide/security-access-control-overview.html#roles)** : The role you created for Airbyte to access Snowflake. Example - `AIRBYTE_ROLE`
116118
* **[Warehouse](https://docs.snowflake.com/en/user-guide/warehouses-overview.html#overview-of-warehouses)** : The warehouse you created for Airbyte to sync data into. Example - `AIRBYTE_WAREHOUSE`
117119
* **[Database](https://docs.snowflake.com/en/sql-reference/ddl-database.html#database-schema-share-ddl)** : The database you created for Airbyte to sync data into. Example - `AIRBYTE_DATABASE`

docs/reference/api/generated-api-html/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9154,7 +9154,7 @@ <h3><a name="OperationCreate"><code>OperationCreate</code> - </a> <a class="up"
91549154
<h3><a name="OperationIdRequestBody"><code>OperationIdRequestBody</code> - </a> <a class="up" href="#__Models">Up</a></h3>
91559155
<div class='model-description'></div>
91569156
<div class="field-items">
9157-
<div class="param">OperationId </div><div class="param-desc"><span class="param-type"><a href="#UUID">UUID</a></span> format: uuid</div>
9157+
<div class="param">operationId </div><div class="param-desc"><span class="param-type"><a href="#UUID">UUID</a></span> format: uuid</div>
91589158
</div> <!-- field-items -->
91599159
</div>
91609160
<div class="model">

0 commit comments

Comments
 (0)