Skip to content

Commit b95cf6c

Browse files
authored
Add missing annotations in Helm Chart (#10218)
* Add missing pod annotations. * Add service accounts.
1 parent 721c904 commit b95cf6c

File tree

5 files changed

+19
-0
lines changed

5 files changed

+19
-0
lines changed

charts/airbyte/templates/bootloader/pod.yaml

+4
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,11 @@ metadata:
88
annotations:
99
helm.sh/hook: pre-install,pre-upgrade
1010
helm.sh/hook-weight: "0"
11+
{{- if .Values.bootloader.podAnnotations }}
12+
{{- include "common.tplvalues.render" (dict "value" .Values.bootloader.podAnnotations "context" $) | nindent 4 }}
13+
{{- end }}
1114
spec:
15+
serviceAccountName: {{ include "airbyte.serviceAccountName" . }}
1216
restartPolicy: Never
1317
containers:
1418
- name: airbyte-bootloader-container

charts/airbyte/templates/scheduler/deployment.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ spec:
1919
{{- include "common.tplvalues.render" (dict "value" .Values.scheduler.podAnnotations "context" $) | nindent 8 }}
2020
{{- end }}
2121
spec:
22+
serviceAccountName: {{ include "airbyte.serviceAccountName" . }}
2223
{{- if .Values.scheduler.nodeSelector }}
2324
nodeSelector: {{- include "common.tplvalues.render" (dict "value" .Values.scheduler.nodeSelector "context" $) | nindent 8 }}
2425
{{- end }}

charts/airbyte/templates/server/deployment.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ spec:
2121
{{- include "common.tplvalues.render" (dict "value" .Values.server.podAnnotations "context" $) | nindent 8 }}
2222
{{- end }}
2323
spec:
24+
serviceAccountName: {{ include "airbyte.serviceAccountName" . }}
2425
{{- if .Values.server.nodeSelector }}
2526
nodeSelector: {{- include "common.tplvalues.render" (dict "value" .Values.server.nodeSelector "context" $) | nindent 8 }}
2627
{{- end }}

charts/airbyte/templates/temporal/deployment.yaml

+5
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,12 @@ spec:
1414
metadata:
1515
labels:
1616
airbyte: temporal
17+
{{- if .Values.temporal.podAnnotations }}
18+
annotations:
19+
{{- include "common.tplvalues.render" (dict "value" .Values.temporal.podAnnotations "context" $) | nindent 8 }}
20+
{{- end }}
1721
spec:
22+
serviceAccountName: {{ include "airbyte.serviceAccountName" . }}
1823
{{- if .Values.temporal.nodeSelector }}
1924
nodeSelector: {{- include "common.tplvalues.render" (dict "value" .Values.temporal.nodeSelector "context" $) | nindent 8 }}
2025
{{- end }}

charts/airbyte/values.yaml

+8
Original file line numberDiff line numberDiff line change
@@ -472,6 +472,10 @@ bootloader:
472472
repository: airbyte/bootloader
473473
pullPolicy: IfNotPresent
474474
tag: 0.35.27-alpha
475+
476+
## @param bootloader.podAnnotations [object] Add extra annotations to the bootloader pod
477+
##
478+
podAnnotations: {}
475479

476480
## @section Temporal parameters
477481
## TODO: Move to consuming temporal from a dedicated helm chart
@@ -494,6 +498,10 @@ temporal:
494498
type: ClusterIP
495499
port: 7233
496500

501+
## @param temporal.podAnnotations [object] Add extra annotations to the temporal pod
502+
##
503+
podAnnotations: {}
504+
497505
## @param temporal.nodeSelector [object] Node labels for temporal pod assignment
498506
## Ref: https://kubernetes.io/docs/user-guide/node-selection/
499507
##

0 commit comments

Comments
 (0)