Skip to content

Commit b7be7aa

Browse files
authored
🪟 ✍🏼 Fix namespace modal description (#21679)
* Fix typos and wording in namespace modal text * Fix namespace description and ad support for customformat description * Add more clarity to the source namespace description
1 parent e4f4718 commit b7be7aa

File tree

2 files changed

+12
-11
lines changed

2 files changed

+12
-11
lines changed

airbyte-webapp/src/components/connection/DestinationNamespaceModal/DestinationNamespaceModal.tsx

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -133,13 +133,13 @@ export const DestinationNamespaceModal: React.FC<DestinationNamespaceModalProps>
133133
</div>
134134
</div>
135135
<div className={styles.description}>
136-
{values.namespaceDefinition === NamespaceDefinitionType.source && (
137-
<FormattedMessage id="connectionForm.modal.destinationNamespace.option.source.description" />
138-
)}
139-
{(values.namespaceDefinition === NamespaceDefinitionType.destination ||
140-
values.namespaceDefinition === NamespaceDefinitionType.customformat) && (
141-
<FormattedMessage id="connectionForm.modal.destinationNamespace.option.destination.description" />
142-
)}
136+
<FormattedMessage
137+
id={`connectionForm.modal.destinationNamespace.option.${
138+
values.namespaceDefinition === NamespaceDefinitionType.customformat
139+
? "customFormat"
140+
: values.namespaceDefinition
141+
}.description`}
142+
/>
143143
<Text className={styles.generalInfo}>
144144
<FormattedMessage id="connectionForm.modal.destinationNamespace.description" />
145145
</Text>

airbyte-webapp/src/locales/en.json

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -164,12 +164,13 @@
164164
"connectionForm.modal.destinationNamespace.option.destination": "Destination default",
165165
"connectionForm.modal.destinationNamespace.option.customFormat": "Custom format",
166166
"connectionForm.modal.destinationNamespace.input.placeholder": "My namespace",
167-
"connectionForm.modal.destinationNamespace.option.source.description": "Replicate to the default namespace in the destination, which will differ based on your destination.",
168-
"connectionForm.modal.destinationNamespace.option.destination.description": "All stream will be replicated and store in the default namespace defined on the destination settings page.",
169-
"connectionForm.modal.destinationNamespace.description": "The following table summarises how this works. We assume an example of replication configurations between a Postgres Source and Snowflake Destination (with settings of schema = \"my_schema\"):",
167+
"connectionForm.modal.destinationNamespace.option.source.description": "Replicate the stream's source namespace in the destination.",
168+
"connectionForm.modal.destinationNamespace.option.destination.description": "Replicate and store in the default namespace defined in the destination settings.",
169+
"connectionForm.modal.destinationNamespace.option.customFormat.description": "Create a \"custom format\" to rename the namespace that your data will be replicated into.",
170+
"connectionForm.modal.destinationNamespace.description": "Below is an example of how your data will be replicated with this namespace setting. This example assumes a Postgres Source and a Snowflake Destination with the schema set to \"my_schema\".",
170171
"connectionForm.modal.destinationNamespace.table.header.sourceNamespace": "Source namespace",
171172
"connectionForm.modal.destinationNamespace.table.header.destinationNamespace": "Destination namespace",
172-
"connectionForm.modal.destinationNamespace.table.header.customFormat": "Custom format=",
173+
"connectionForm.modal.destinationNamespace.table.header.customFormat": "Custom format",
173174
"connectionForm.modal.destinationNamespace.table.data.public": "public",
174175
"connectionForm.modal.destinationNamespace.table.data.mySchema": "my_schema",
175176
"connectionForm.modal.destinationNamespace.table.data.myPublicSchema": "my_public_schema",

0 commit comments

Comments
 (0)