Skip to content

Commit b754465

Browse files
authored
fixed spinner size and position during loading logs (#15846)
1 parent abd209f commit b754465

File tree

2 files changed

+14
-10
lines changed

2 files changed

+14
-10
lines changed
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
@use "../../scss/colors";
2+
3+
.logsLoadingContainer {
4+
display: flex;
5+
align-items: center;
6+
justify-content: center;
7+
background: colors.$white;
8+
padding: 6px 0;
9+
min-height: 58px;
10+
}

airbyte-webapp/src/components/JobItem/JobItem.tsx

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import ContentWrapper from "./components/ContentWrapper";
1111
import ErrorDetails from "./components/ErrorDetails";
1212
import JobLogs from "./components/JobLogs";
1313
import MainInfo from "./components/MainInfo";
14+
import styles from "./JobItem.module.scss";
1415

1516
const Item = styled.div<{ isFailed: boolean }>`
1617
border-bottom: 1px solid ${({ theme }) => theme.greyColor20};
@@ -22,13 +23,6 @@ const Item = styled.div<{ isFailed: boolean }>`
2223
}
2324
`;
2425

25-
const LoadLogs = styled.div`
26-
background: ${({ theme }) => theme.whiteColor};
27-
text-align: center;
28-
padding: 6px 0;
29-
min-height: 58px;
30-
`;
31-
3226
interface JobItemProps {
3327
job: SynchronousJobRead | JobsWithJobs;
3428
}
@@ -74,9 +68,9 @@ export const JobItem: React.FC<JobItemProps> = ({ job }) => {
7468
<div>
7569
<Suspense
7670
fallback={
77-
<LoadLogs>
78-
<Spinner />
79-
</LoadLogs>
71+
<div className={styles.logsLoadingContainer}>
72+
<Spinner small />
73+
</div>
8074
}
8175
>
8276
{isOpen && (

0 commit comments

Comments
 (0)