Skip to content

Commit b2e63f2

Browse files
author
Marius Posta
authored
airbyte-ci: relax docs qa checks when sl == 0 (#45360)
1 parent c3c8423 commit b2e63f2

File tree

16 files changed

+29
-23
lines changed

16 files changed

+29
-23
lines changed

airbyte-ci/connectors/connectors_qa/README.md

+4
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,10 @@ poe lint
108108

109109
## Changelog
110110

111+
### 1.8.0
112+
113+
Added minimum sl threshold value to documentation checks to skip them for connectors for which sl is 0.
114+
111115
### 1.7.0
112116

113117
Added `CheckDocumentationLinks`, `CheckDocumentationHeadersOrder`, `CheckPrerequisitesSectionDescribesRequiredFieldsFromSpec`,

airbyte-ci/connectors/connectors_qa/pyproject.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[tool.poetry]
22
name = "connectors-qa"
3-
version = "1.7.0"
3+
version = "1.8.0"
44
description = "A package to run QA checks on Airbyte connectors, generate reports and documentation."
55
authors = ["Airbyte <[email protected]>"]
66
readme = "README.md"

airbyte-ci/connectors/connectors_qa/src/connectors_qa/checks/documentation/documentation.py

+1
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424

2525
class DocumentationCheck(Check):
2626
category = CheckCategory.DOCUMENTATION
27+
applies_to_connector_ab_internal_sl = 100
2728

2829

2930
class CheckMigrationGuide(DocumentationCheck):

airbyte-ci/connectors/metadata_service/lib/metadata_service/models/generated/AirbyteInternal.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,5 @@ class AirbyteInternal(BaseModel):
1313
class Config:
1414
extra = Extra.allow
1515

16-
sl: Optional[Literal[100, 200, 300]] = None
17-
ql: Optional[Literal[100, 200, 300, 400, 500, 600]] = None
16+
sl: Optional[Literal[0, 100, 200, 300]] = None
17+
ql: Optional[Literal[0, 100, 200, 300, 400, 500, 600]] = None

airbyte-ci/connectors/metadata_service/lib/metadata_service/models/generated/ConnectorMetadataDefinitionV0.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -123,8 +123,8 @@ class AirbyteInternal(BaseModel):
123123
class Config:
124124
extra = Extra.allow
125125

126-
sl: Optional[Literal[100, 200, 300]] = None
127-
ql: Optional[Literal[100, 200, 300, 400, 500, 600]] = None
126+
sl: Optional[Literal[0, 100, 200, 300]] = None
127+
ql: Optional[Literal[0, 100, 200, 300, 400, 500, 600]] = None
128128

129129

130130
class PyPi(BaseModel):

airbyte-ci/connectors/metadata_service/lib/metadata_service/models/generated/ConnectorRegistryDestinationDefinition.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -100,8 +100,8 @@ class AirbyteInternal(BaseModel):
100100
class Config:
101101
extra = Extra.allow
102102

103-
sl: Optional[Literal[100, 200, 300]] = None
104-
ql: Optional[Literal[100, 200, 300, 400, 500, 600]] = None
103+
sl: Optional[Literal[0, 100, 200, 300]] = None
104+
ql: Optional[Literal[0, 100, 200, 300, 400, 500, 600]] = None
105105

106106

107107
class GitInfo(BaseModel):

airbyte-ci/connectors/metadata_service/lib/metadata_service/models/generated/ConnectorRegistryReleases.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,8 @@ class AirbyteInternal(BaseModel):
8686
class Config:
8787
extra = Extra.allow
8888

89-
sl: Optional[Literal[100, 200, 300]] = None
90-
ql: Optional[Literal[100, 200, 300, 400, 500, 600]] = None
89+
sl: Optional[Literal[0, 100, 200, 300]] = None
90+
ql: Optional[Literal[0, 100, 200, 300, 400, 500, 600]] = None
9191

9292

9393
class GitInfo(BaseModel):

airbyte-ci/connectors/metadata_service/lib/metadata_service/models/generated/ConnectorRegistrySourceDefinition.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -100,8 +100,8 @@ class AirbyteInternal(BaseModel):
100100
class Config:
101101
extra = Extra.allow
102102

103-
sl: Optional[Literal[100, 200, 300]] = None
104-
ql: Optional[Literal[100, 200, 300, 400, 500, 600]] = None
103+
sl: Optional[Literal[0, 100, 200, 300]] = None
104+
ql: Optional[Literal[0, 100, 200, 300, 400, 500, 600]] = None
105105

106106

107107
class GitInfo(BaseModel):

airbyte-ci/connectors/metadata_service/lib/metadata_service/models/generated/ConnectorRegistryV0.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -100,8 +100,8 @@ class AirbyteInternal(BaseModel):
100100
class Config:
101101
extra = Extra.allow
102102

103-
sl: Optional[Literal[100, 200, 300]] = None
104-
ql: Optional[Literal[100, 200, 300, 400, 500, 600]] = None
103+
sl: Optional[Literal[0, 100, 200, 300]] = None
104+
ql: Optional[Literal[0, 100, 200, 300, 400, 500, 600]] = None
105105

106106

107107
class GitInfo(BaseModel):

airbyte-ci/connectors/metadata_service/lib/metadata_service/models/src/AirbyteInternal.yaml

+2
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,14 @@ properties:
99
sl:
1010
type: integer
1111
enum:
12+
- 0
1213
- 100
1314
- 200
1415
- 300
1516
ql:
1617
type: integer
1718
enum:
19+
- 0
1820
- 100
1921
- 200
2022
- 300

airbyte-ci/connectors/metadata_service/lib/pyproject.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[tool.poetry]
22
name = "metadata-service"
3-
version = "0.14.1"
3+
version = "0.15.0"
44
description = ""
55
authors = ["Ben Church <[email protected]>"]
66
readme = "README.md"

airbyte-ci/connectors/metadata_service/lib/tests/test_validators/test_metadata_validators.py

+2-4
Original file line numberDiff line numberDiff line change
@@ -71,10 +71,8 @@ def test_validation_fail_on_docker_image_tag_decrement(metadata_definition, decr
7171
metadata_definition.data.dockerImageTag = decremented_version
7272
success, error_message = metadata_validator.validate_docker_image_tag_is_not_decremented(metadata_definition, None)
7373
assert not success
74-
assert (
75-
error_message
76-
== f"The dockerImageTag value ({decremented_version}) can't be decremented: it should be equal to or above {current_version}."
77-
)
74+
expected_prefix = f"The dockerImageTag value ({decremented_version}) can't be decremented: it should be equal to or above"
75+
assert error_message.startswith(expected_prefix), error_message
7876

7977

8078
def test_validation_pass_on_docker_image_tag_increment(metadata_definition, incremented_version):

airbyte-ci/connectors/metadata_service/orchestrator/pyproject.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[tool.poetry]
22
name = "orchestrator"
3-
version = "0.5.4"
3+
version = "0.5.5"
44
description = ""
55
authors = ["Ben Church <[email protected]>"]
66
readme = "README.md"

airbyte-ci/connectors/pipelines/README.md

+1
Original file line numberDiff line numberDiff line change
@@ -843,6 +843,7 @@ airbyte-ci connectors --language=low-code migrate-to-manifest-only
843843

844844
| Version | PR | Description |
845845
| ------- | ---------------------------------------------------------- |------------------------------------------------------------------------------------------------------------------------------|
846+
| 4.35.2 | [#45360](https://github.com/airbytehq/airbyte/pull/45360) | Updated dependencies. |
846847
| 4.35.1 | [#45160](https://github.com/airbytehq/airbyte/pull/45160) | Remove deps.toml dependency for java connectors. |
847848
| 4.35.0 | [#44879](https://github.com/airbytehq/airbyte/pull/44879) | Mount `components.py` when building manifest-only connector image |
848849
| 4.34.2 | [#44786](https://github.com/airbytehq/airbyte/pull/44786) | Pre-emptively skip archived connectors when searching for modified files |

airbyte-ci/connectors/pipelines/pyproject.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ build-backend = "poetry.core.masonry.api"
44

55
[tool.poetry]
66
name = "pipelines"
7-
version = "4.35.1"
7+
version = "4.35.2"
88
description = "Packaged maintained by the connector operations team to perform CI for connectors' pipelines"
99
authors = ["Airbyte <[email protected]>"]
1010

docs/contributing-to-airbyte/resources/qa-checks.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ They are by no mean replacing the need for a manual review of the connector code
1313
_Applies to the following connector types: source, destination_
1414
_Applies to the following connector languages: java, low-code, python, manifest-only_
1515
_Applies to connector with any support level_
16-
_Applies to connector with any internal support level_
16+
_Applies to connector with 100 internal support level_
1717
_Applies to connector with any Airbyte usage level_
1818

1919
When a breaking change is introduced, we check that a migration guide is available. It should be stored under `./docs/integrations/<connector-type>s/<connector-name>-migrations.md`.
@@ -24,7 +24,7 @@ This document should contain a section for each breaking change, in order of the
2424
_Applies to the following connector types: source, destination_
2525
_Applies to the following connector languages: java, low-code, python, manifest-only_
2626
_Applies to connector with any support level_
27-
_Applies to connector with any internal support level_
27+
_Applies to connector with 100 internal support level_
2828
_Applies to connector with any Airbyte usage level_
2929

3030
The user facing connector documentation should be stored under `./docs/integrations/<connector-type>s/<connector-name>.md`.
@@ -251,7 +251,7 @@ Check verifies that Changelog header section content follows standard template:
251251
_Applies to the following connector types: source, destination_
252252
_Applies to the following connector languages: java, low-code, python, manifest-only_
253253
_Applies to connector with any support level_
254-
_Applies to connector with any internal support level_
254+
_Applies to connector with 100 internal support level_
255255
_Applies to connector with any Airbyte usage level_
256256

257257
Each new version of a connector must have a changelog entry defined in the user facing documentation in `./docs/integrations/<connector-type>s/<connector-name>.md`.

0 commit comments

Comments
 (0)