Skip to content

Commit b119353

Browse files
authored
[ISSUE #38154] temporarily remove wish_bid from fields (#38301)
1 parent 6ea7957 commit b119353

File tree

5 files changed

+10
-3
lines changed

5 files changed

+10
-3
lines changed

airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ data:
1010
connectorSubtype: api
1111
connectorType: source
1212
definitionId: e7778cfc-e97c-4458-9ecb-b4f2bba8946c
13-
dockerImageTag: 2.1.8
13+
dockerImageTag: 2.1.9
1414
dockerRepository: airbyte/source-facebook-marketing
1515
documentationUrl: https://docs.airbyte.com/integrations/sources/facebook-marketing
1616
githubIssueLabel: source-facebook-marketing

airbyte-integrations/connectors/source-facebook-marketing/pyproject.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ requires = [ "poetry-core>=1.0.0",]
33
build-backend = "poetry.core.masonry.api"
44

55
[tool.poetry]
6-
version = "2.1.8"
6+
version = "2.1.9"
77
name = "source-facebook-marketing"
88
description = "Source implementation for Facebook Marketing."
99
authors = [ "Airbyte <[email protected]>",]

airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/streams/base_insight_streams.py

+7
Original file line numberDiff line numberDiff line change
@@ -371,4 +371,11 @@ def fields(self, **kwargs) -> List[str]:
371371

372372
schema = ResourceSchemaLoader(package_name_from_class(self.__class__)).get_schema("ads_insights")
373373
self._fields = list(schema.get("properties", {}).keys())
374+
375+
# Having this field in syncs seem to have caused data inaccuracy where fields like `spend` had the wrong values
376+
try:
377+
self._fields.remove("wish_bid")
378+
except ValueError:
379+
pass
380+
374381
return self._fields

airbyte-integrations/connectors/source-facebook-marketing/unit_tests/integration/test_ads_insights_action_product_id.py

-1
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,6 @@ def _job_start_request(
155155
"video_time_watched_actions",
156156
"website_ctr",
157157
"website_purchase_roas",
158-
"wish_bid",
159158
],
160159
"time_increment": 1,
161160
"action_attribution_windows": ["1d_click", "7d_click", "28d_click", "1d_view", "7d_view", "28d_view"],

docs/integrations/sources/facebook-marketing.md

+1
Original file line numberDiff line numberDiff line change
@@ -202,6 +202,7 @@ The Facebook Marketing connector uses the `lookback_window` parameter to repeate
202202

203203
| Version | Date | Pull Request | Subject |
204204
|:--------|:-----------|:---------------------------------------------------------|:--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
205+
| 2.1.9 | 2024-05-17 | [38301](https://github.com/airbytehq/airbyte/pull/38301) | Fix data inaccuracies when `wish_bid` is requested |
205206
| 2.1.8 | 2024-05-07 | [37771](https://github.com/airbytehq/airbyte/pull/37771) | Handle errors without API error codes/messages |
206207
| 2.1.7 | 2024-04-24 | [36634](https://github.com/airbytehq/airbyte/pull/36634) | Update to CDK 0.80.0 |
207208
| 2.1.6 | 2024-04-24 | [36634](https://github.com/airbytehq/airbyte/pull/36634) | Schema descriptions |

0 commit comments

Comments
 (0)