Skip to content

Commit ae95d29

Browse files
authored
🐛Destination-dynamodb: fixed build's run (#13303)
* [13180] Destination-dynamodb: fixed build's run
1 parent ab81e4d commit ae95d29

File tree

4 files changed

+7
-12
lines changed

4 files changed

+7
-12
lines changed

airbyte-config/init/src/main/resources/seed/destination_definitions.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@
8080
- name: DynamoDB
8181
destinationDefinitionId: 8ccd8909-4e99-4141-b48d-4984b70b2d89
8282
dockerRepository: airbyte/destination-dynamodb
83-
dockerImageTag: 0.1.2
83+
dockerImageTag: 0.1.3
8484
documentationUrl: https://docs.airbyte.io/integrations/destinations/dynamodb
8585
icon: dynamodb.svg
8686
releaseStage: alpha

airbyte-config/init/src/main/resources/seed/destination_specs.yaml

+5-5
Original file line numberDiff line numberDiff line change
@@ -1111,15 +1111,15 @@
11111111
supported_destination_sync_modes:
11121112
- "overwrite"
11131113
- "append"
1114-
- dockerImage: "airbyte/destination-dynamodb:0.1.2"
1114+
- dockerImage: "airbyte/destination-dynamodb:0.1.3"
11151115
spec:
11161116
documentationUrl: "https://docs.airbyte.io/integrations/destinations/dynamodb"
11171117
connectionSpecification:
11181118
$schema: "http://json-schema.org/draft-07/schema#"
11191119
title: "DynamoDB Destination Spec"
11201120
type: "object"
11211121
required:
1122-
- "dynamodb_table_name"
1122+
- "dynamodb_table_name_prefix"
11231123
- "dynamodb_region"
11241124
- "access_key_id"
11251125
- "secret_access_key"
@@ -1133,10 +1133,10 @@
11331133
\ AWS DynamoDB, just leave empty)."
11341134
examples:
11351135
- "http://localhost:9000"
1136-
dynamodb_table_name:
1137-
title: "DynamoDB Table Name"
1136+
dynamodb_table_name_prefix:
1137+
title: "Table name prefix"
11381138
type: "string"
1139-
description: "The name of the DynamoDB table."
1139+
description: "The prefix to use when naming DynamoDB tables."
11401140
examples:
11411141
- "airbyte_sync"
11421142
dynamodb_region:

airbyte-integrations/connectors/destination-dynamodb/Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,5 +16,5 @@ ENV APPLICATION destination-dynamodb
1616

1717
COPY --from=build /airbyte /airbyte
1818

19-
LABEL io.airbyte.version=0.1.2
19+
LABEL io.airbyte.version=0.1.3
2020
LABEL io.airbyte.name=airbyte/destination-dynamodb

airbyte-integrations/connectors/destination-dynamodb/src/test-integration/java/io/airbyte/integrations/destination/dynamodb/DynamodbDestinationAcceptanceTest.java

-5
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,8 @@
1313
import com.amazonaws.services.dynamodbv2.document.*;
1414
import com.amazonaws.services.dynamodbv2.document.spec.ScanSpec;
1515
import com.fasterxml.jackson.databind.JsonNode;
16-
import com.fasterxml.jackson.databind.ObjectMapper;
1716
import com.fasterxml.jackson.databind.node.ObjectNode;
1817
import io.airbyte.commons.io.IOs;
19-
import io.airbyte.commons.jackson.MoreMappers;
2018
import io.airbyte.commons.json.Jsons;
2119
import io.airbyte.integrations.base.JavaBaseConstants;
2220
import io.airbyte.integrations.standardtest.destination.DestinationAcceptanceTest;
@@ -30,7 +28,6 @@
3028
public class DynamodbDestinationAcceptanceTest extends DestinationAcceptanceTest {
3129

3230
private static final Logger LOGGER = LoggerFactory.getLogger(DynamodbDestinationAcceptanceTest.class);
33-
protected static final ObjectMapper MAPPER = MoreMappers.initMapper();
3431

3532
protected final String secretFilePath = "secrets/config.json";
3633
protected JsonNode configJson;
@@ -69,7 +66,6 @@ protected List<Item> getAllSyncedObjects(final String streamName, final String n
6966
final var tableName = DynamodbOutputTableHelper.getOutputTableName(this.config.getTableNamePrefix(), streamName, namespace);
7067
final var table = dynamodb.getTable(tableName);
7168
final List<Item> items = new ArrayList<Item>();
72-
final List<Item> resultItems = new ArrayList<Item>();
7369
Long maxSyncTime = 0L;
7470

7571
try {
@@ -86,7 +82,6 @@ protected List<Item> getAllSyncedObjects(final String streamName, final String n
8682
LOGGER.error(e.getMessage());
8783
}
8884

89-
final Long finalMaxSyncTime = maxSyncTime;
9085
items.sort(Comparator.comparingLong(o -> ((BigDecimal) o.get(JavaBaseConstants.COLUMN_NAME_EMITTED_AT)).longValue()));
9186

9287
return items;

0 commit comments

Comments
 (0)