Skip to content

Commit a7ec584

Browse files
marcosmarxmasuliman17
marcosmarxm
and
asuliman17
authored
New Connector CallRail + format (#19407)
* init * adding image and call rail record within source_definitions.yaml * replacing data types in users.json * converting text_messages.json to conversations.json * removing trackers.json * renaming streams in abnormal_state.json and seperating incremental from non-incremental streams in caatalog files * - moving stream slicer to retriever in definition - renaming text_messages to conversations * adding doc for callrail.md * adjusting sepc.yaml based off of Marcos's comments. * adjusting sepc.yaml * cleaning up acceptance-test-config. small adjustments to rest of files. * adding pagination * fix tests * generate source spec * solve conflict source spec and def Co-authored-by: adhamsuliman <[email protected]>
1 parent b4dfbdb commit a7ec584

29 files changed

+875
-0
lines changed

‎airbyte-config/init/src/main/resources/icons/callrail.svg

Lines changed: 1 addition & 0 deletions
Loading

‎airbyte-config/init/src/main/resources/seed/source_definitions.yaml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -183,6 +183,14 @@
183183
documentationUrl: https://docs.airbyte.com/integrations/sources/breezometer
184184
sourceType: api
185185
releaseStage: alpha
186+
- name: CallRail
187+
sourceDefinitionId: dc98a6ad-2dd1-47b6-9529-2ec35820f9c6
188+
dockerRepository: airbyte/source-callrail
189+
dockerImageTag: 0.1.0
190+
documentationUrl: https://docs.airbyte.com/integrations/sources/callrail
191+
icon: callrail.svg
192+
sourceType: api
193+
releaseStage: alpha
186194
- name: Cart.com
187195
sourceDefinitionId: bb1a6d31-6879-4819-a2bd-3eed299ea8e2
188196
dockerRepository: airbyte/source-cart

‎airbyte-config/init/src/main/resources/seed/source_specs.yaml

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1896,6 +1896,36 @@
18961896
supportsNormalization: false
18971897
supportsDBT: false
18981898
supported_destination_sync_modes: []
1899+
- dockerImage: "airbyte/source-callrail:0.1.0"
1900+
spec:
1901+
documentationUrl: "https://docs.airbyte.com/integrations/sources/callrail"
1902+
connectionSpecification:
1903+
$schema: "http://json-schema.org/draft-07/schema#"
1904+
title: "Call Rail Spec"
1905+
type: "object"
1906+
required:
1907+
- "api_key"
1908+
- "account_id"
1909+
- "start_date"
1910+
additionalProperties: true
1911+
properties:
1912+
api_key:
1913+
type: "string"
1914+
description: "API access key"
1915+
airbyte_secret: true
1916+
account_id:
1917+
type: "string"
1918+
description: "Account ID"
1919+
airbyte_secret: true
1920+
start_date:
1921+
type: "string"
1922+
description: "Start getting data from that date."
1923+
pattern: "^[0-9]{4}-[0-9]{2}-[0-9]{2}$"
1924+
examples:
1925+
- "%Y-%m-%d"
1926+
supportsNormalization: false
1927+
supportsDBT: false
1928+
supported_destination_sync_modes: []
18991929
- dockerImage: "airbyte/source-cart:0.2.0"
19001930
spec:
19011931
documentationUrl: "https://docs.airbyte.com/integrations/sources/cart"

‎airbyte-integrations/connectors/source-callrail/.dockerignore

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
*
2+
!Dockerfile
3+
!main.py
4+
!source_callrail
5+
!setup.py
6+
!secrets

‎airbyte-integrations/connectors/source-callrail/Dockerfile

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,38 @@
1+
FROM python:3.9.11-alpine3.15 as base
2+
3+
# build and load all requirements
4+
FROM base as builder
5+
WORKDIR /airbyte/integration_code
6+
7+
# upgrade pip to the latest version
8+
RUN apk --no-cache upgrade \
9+
&& pip install --upgrade pip \
10+
&& apk --no-cache add tzdata build-base
11+
12+
13+
COPY setup.py ./
14+
# install necessary packages to a temporary folder
15+
RUN pip install --prefix=/install .
16+
17+
# build a clean environment
18+
FROM base
19+
WORKDIR /airbyte/integration_code
20+
21+
# copy all loaded and built libraries to a pure basic image
22+
COPY --from=builder /install /usr/local
23+
# add default timezone settings
24+
COPY --from=builder /usr/share/zoneinfo/Etc/UTC /etc/localtime
25+
RUN echo "Etc/UTC" > /etc/timezone
26+
27+
# bash is installed for more convenient debugging.
28+
RUN apk --no-cache add bash
29+
30+
# copy payload code only
31+
COPY main.py ./
32+
COPY source_callrail ./source_callrail
33+
34+
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
35+
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]
36+
37+
LABEL io.airbyte.version=0.1.0
38+
LABEL io.airbyte.name=airbyte/source-callrail

‎airbyte-integrations/connectors/source-callrail/README.md

Lines changed: 79 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,79 @@
1+
# Callrail Source
2+
3+
This is the repository for the Callrail configuration based source connector.
4+
For information about how to use this connector within Airbyte, see [the documentation](https://docs.airbyte.io/integrations/sources/callrail).
5+
6+
## Local development
7+
8+
#### Building via Gradle
9+
You can also build the connector in Gradle. This is typically used in CI and not needed for your development workflow.
10+
11+
To build using Gradle, from the Airbyte repository root, run:
12+
```
13+
./gradlew :airbyte-integrations:connectors:source-callrail:build
14+
```
15+
16+
#### Create credentials
17+
**If you are a community contributor**, follow the instructions in the [documentation](https://docs.airbyte.io/integrations/sources/callrail)
18+
to generate the necessary credentials. Then create a file `secrets/config.json` conforming to the `source_callrail/spec.yaml` file.
19+
Note that any directory named `secrets` is gitignored across the entire Airbyte repo, so there is no danger of accidentally checking in sensitive information.
20+
See `integration_tests/sample_config.json` for a sample config file.
21+
22+
**If you are an Airbyte core member**, copy the credentials in Lastpass under the secret name `source callrail test creds`
23+
and place them into `secrets/config.json`.
24+
25+
### Locally running the connector docker image
26+
27+
#### Build
28+
First, make sure you build the latest Docker image:
29+
```
30+
docker build . -t airbyte/source-callrail:dev
31+
```
32+
33+
You can also build the connector image via Gradle:
34+
```
35+
./gradlew :airbyte-integrations:connectors:source-callrail:airbyteDocker
36+
```
37+
When building via Gradle, the docker image name and tag, respectively, are the values of the `io.airbyte.name` and `io.airbyte.version` `LABEL`s in
38+
the Dockerfile.
39+
40+
#### Run
41+
Then run any of the connector commands as follows:
42+
```
43+
docker run --rm airbyte/source-callrail:dev spec
44+
docker run --rm -v $(pwd)/secrets:/secrets airbyte/source-callrail:dev check --config /secrets/config.json
45+
docker run --rm -v $(pwd)/secrets:/secrets airbyte/source-callrail:dev discover --config /secrets/config.json
46+
docker run --rm -v $(pwd)/secrets:/secrets -v $(pwd)/integration_tests:/integration_tests airbyte/source-callrail:dev read --config /secrets/config.json --catalog /integration_tests/configured_catalog.json
47+
```
48+
## Testing
49+
50+
#### Acceptance Tests
51+
Customize `acceptance-test-config.yml` file to configure tests. See [Source Acceptance Tests](https://docs.airbyte.io/connector-development/testing-connectors/source-acceptance-tests-reference) for more information.
52+
If your connector requires to create or destroy resources for use during acceptance tests create fixtures for it and place them inside integration_tests/acceptance.py.
53+
54+
To run your integration tests with docker
55+
56+
### Using gradle to run tests
57+
All commands should be run from airbyte project root.
58+
To run unit tests:
59+
```
60+
./gradlew :airbyte-integrations:connectors:source-callrail:unitTest
61+
```
62+
To run acceptance and custom integration tests:
63+
```
64+
./gradlew :airbyte-integrations:connectors:source-callrail:integrationTest
65+
```
66+
67+
## Dependency Management
68+
All of your dependencies should go in `setup.py`, NOT `requirements.txt`. The requirements file is only used to connect internal Airbyte dependencies in the monorepo for local development.
69+
We split dependencies between two groups, dependencies that are:
70+
* required for your connector to work need to go to `MAIN_REQUIREMENTS` list.
71+
* required for the testing need to go to `TEST_REQUIREMENTS` list
72+
73+
### Publishing a new version of the connector
74+
You've checked out the repo, implemented a million dollar feature, and you're ready to share your changes with the world. Now what?
75+
1. Make sure your changes are passing unit and integration tests.
76+
1. Bump the connector version in `Dockerfile` -- just increment the value of the `LABEL io.airbyte.version` appropriately (we use [SemVer](https://semver.org/)).
77+
1. Create a Pull Request.
78+
1. Pat yourself on the back for being an awesome contributor.
79+
1. Someone from Airbyte will take a look at your PR and iterate with you to merge it into master.

‎airbyte-integrations/connectors/source-callrail/__init__.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
#
2+
# Copyright (c) 2022 Airbyte, Inc., all rights reserved.
3+
#

‎airbyte-integrations/connectors/source-callrail/acceptance-test-config.yml

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
# See [Source Acceptance Tests](https://docs.airbyte.com/connector-development/testing-connectors/source-acceptance-tests-reference)
2+
# for more information about how to configure these tests
3+
connector_image: airbyte/source-callrail:dev
4+
tests:
5+
spec:
6+
- spec_path: "source_callrail/spec.yaml"
7+
timeout_seconds: 60
8+
connection:
9+
- config_path: "secrets/config.json"
10+
status: "succeed"
11+
- config_path: "integration_tests/invalid_config.json"
12+
status: "failed"
13+
discovery:
14+
- config_path: "secrets/config.json"
15+
basic_read:
16+
- config_path: "secrets/config.json"
17+
configured_catalog_path: "integration_tests/configured_catalog.json"
18+
empty_streams: ["calls", "conversations"]
19+
full_refresh:
20+
- config_path: "secrets/config.json"
21+
configured_catalog_path: "integration_tests/configured_catalog.json"

‎airbyte-integrations/connectors/source-callrail/acceptance-test-docker.sh

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
#!/usr/bin/env sh
2+
3+
# Build latest connector image
4+
docker build . -t $(cat acceptance-test-config.yml | grep "connector_image" | head -n 1 | cut -d: -f2-)
5+
6+
# Pull latest acctest image
7+
docker pull airbyte/source-acceptance-test:latest
8+
9+
# Run
10+
docker run --rm -it \
11+
-v /var/run/docker.sock:/var/run/docker.sock \
12+
-v /tmp:/tmp \
13+
-v $(pwd):/test_input \
14+
airbyte/source-acceptance-test \
15+
--acceptance-test-config /test_input
16+

‎airbyte-integrations/connectors/source-callrail/build.gradle

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
plugins {
2+
id 'airbyte-python'
3+
id 'airbyte-docker'
4+
id 'airbyte-source-acceptance-test'
5+
}
6+
7+
airbytePython {
8+
moduleDirectory 'source_callrail'
9+
}

‎airbyte-integrations/connectors/source-callrail/integration_tests/__init__.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
#
2+
# Copyright (c) 2022 Airbyte, Inc., all rights reserved.
3+
#

‎airbyte-integrations/connectors/source-callrail/integration_tests/abnormal_state.json

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
{
2+
"calls": {
3+
"start_time": "2999-10-30T00:00:00.000Z"
4+
},
5+
"conversations": {
6+
"last_message_at": "2999-10-30T00:00:00.000Z"
7+
}
8+
}

‎airbyte-integrations/connectors/source-callrail/integration_tests/acceptance.py

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
#
2+
# Copyright (c) 2022 Airbyte, Inc., all rights reserved.
3+
#
4+
5+
6+
import pytest
7+
8+
pytest_plugins = ("source_acceptance_test.plugin",)
9+
10+
11+
@pytest.fixture(scope="session", autouse=True)
12+
def connector_setup():
13+
"""This fixture is a placeholder for external resources that acceptance test might require."""
14+
# TODO: setup test dependencies if needed. otherwise remove the TODO comments
15+
yield
16+
# TODO: clean up test dependencies

‎airbyte-integrations/connectors/source-callrail/integration_tests/configured_catalog.json

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
{
2+
"streams": [
3+
{
4+
"stream": {
5+
"name": "users",
6+
"json_schema": {},
7+
"supported_sync_modes": ["full_refresh", "incremental"]
8+
},
9+
"sync_mode": "full_refresh",
10+
"destination_sync_mode": "append"
11+
},
12+
{
13+
"stream": {
14+
"name": "companies",
15+
"json_schema": {},
16+
"supported_sync_modes": ["full_refresh", "incremental"]
17+
},
18+
"sync_mode": "full_refresh",
19+
"destination_sync_mode": "append"
20+
}
21+
]
22+
}

‎airbyte-integrations/connectors/source-callrail/integration_tests/invalid_config.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
{
2+
"api_key": "",
3+
"account_id": "",
4+
"start_date": "2019-01-01"
5+
}

‎airbyte-integrations/connectors/source-callrail/integration_tests/sample_config.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
{
2+
"api_key": "XXXXXXXXXXXXXXXXXX",
3+
"account_id": "XXXXXXXXXXXXXXXXXX",
4+
"start_date": "2019-01-01"
5+
}

‎airbyte-integrations/connectors/source-callrail/integration_tests/sample_state.json

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
{
2+
"calls": {
3+
"start_time": "2022-10-13T13:51:44.830-07:00"
4+
},
5+
"conversations": {
6+
"last_message_at": "2022-10-13T13:51:44.830-07:00"
7+
},
8+
"users": {
9+
"created_at": "2022-10-13T13:51:44.830-07:00"
10+
},
11+
"companies": {
12+
"created_at": "2022-10-13T13:51:44.830-07:00"
13+
}
14+
}

‎airbyte-integrations/connectors/source-callrail/main.py

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
#
2+
# Copyright (c) 2022 Airbyte, Inc., all rights reserved.
3+
#
4+
5+
6+
import sys
7+
8+
from airbyte_cdk.entrypoint import launch
9+
from source_callrail import SourceCallrail
10+
11+
if __name__ == "__main__":
12+
source = SourceCallrail()
13+
launch(source, sys.argv[1:])

‎airbyte-integrations/connectors/source-callrail/requirements.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
-e ../../bases/source-acceptance-test
2+
-e .

‎airbyte-integrations/connectors/source-callrail/setup.py

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
#
2+
# Copyright (c) 2022 Airbyte, Inc., all rights reserved.
3+
#
4+
5+
6+
from setuptools import find_packages, setup
7+
8+
MAIN_REQUIREMENTS = [
9+
"airbyte-cdk~=0.1",
10+
]
11+
12+
TEST_REQUIREMENTS = [
13+
"pytest~=6.1",
14+
"pytest-mock~=3.6.1",
15+
"source-acceptance-test",
16+
]
17+
18+
setup(
19+
name="source_callrail",
20+
description="Source implementation for Callrail.",
21+
author="Airbyte",
22+
author_email="[email protected]",
23+
packages=find_packages(),
24+
install_requires=MAIN_REQUIREMENTS,
25+
package_data={"": ["*.json", "*.yaml", "schemas/*.json", "schemas/shared/*.json"]},
26+
extras_require={
27+
"tests": TEST_REQUIREMENTS,
28+
},
29+
)

‎airbyte-integrations/connectors/source-callrail/source_callrail/__init__.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
#
2+
# Copyright (c) 2022 Airbyte, Inc., all rights reserved.
3+
#
4+
5+
6+
from .source import SourceCallrail
7+
8+
__all__ = ["SourceCallrail"]

0 commit comments

Comments
 (0)