Skip to content

Commit 9f06bcc

Browse files
authored
fix(source-zendesk-support): migrate to cursor based pagination (#38607)
Signed-off-by: Artem Inzhyyants <[email protected]>
1 parent 07c0584 commit 9f06bcc

File tree

5 files changed

+10
-5
lines changed

5 files changed

+10
-5
lines changed

airbyte-integrations/connectors/source-zendesk-support/metadata.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ data:
1111
connectorSubtype: api
1212
connectorType: source
1313
definitionId: 79c1aa37-dae3-42ae-b333-d1c105477715
14-
dockerImageTag: 2.6.4
14+
dockerImageTag: 2.6.5
1515
dockerRepository: airbyte/source-zendesk-support
1616
documentationUrl: https://docs.airbyte.com/integrations/sources/zendesk-support
1717
githubIssueLabel: source-zendesk-support

airbyte-integrations/connectors/source-zendesk-support/pyproject.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ requires = [ "poetry-core>=1.0.0",]
33
build-backend = "poetry.core.masonry.api"
44

55
[tool.poetry]
6-
version = "2.6.4"
6+
version = "2.6.5"
77
name = "source-zendesk-support"
88
description = "Source implementation for Zendesk Support."
99
authors = [ "Airbyte <[email protected]>",]

airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/manifest.yaml

+4
Original file line numberDiff line numberDiff line change
@@ -290,6 +290,10 @@ definitions:
290290

291291
organization_memberships_stream:
292292
$ref: "#/definitions/semi_incremental_stream"
293+
retriever:
294+
$ref: "#/definitions/semi_incremental_stream/retriever"
295+
paginator:
296+
$ref: "#/definitions/links_next_paginator"
293297
$parameters:
294298
name: "organization_memberships"
295299
path: "organization_memberships"

airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55

66
import calendar
77
import copy
8+
import logging
89
import re
910
from datetime import datetime
1011
from unittest.mock import Mock, patch
@@ -15,7 +16,6 @@
1516
import pytest
1617
import pytz
1718
import requests
18-
from airbyte_cdk import AirbyteLogger
1919
from airbyte_protocol.models import SyncMode
2020
from source_zendesk_support.source import BasicApiTokenAuthenticator, SourceZendeskSupport
2121
from source_zendesk_support.streams import (
@@ -175,7 +175,7 @@ def test_check(response, start_date, check_passed):
175175
config = copy.deepcopy(TEST_CONFIG)
176176
config["start_date"] = start_date
177177
with patch.object(UserSettingsStream, "get_settings", return_value=response) as mock_method:
178-
ok, _ = SourceZendeskSupport().check_connection(logger=AirbyteLogger, config=config)
178+
ok, _ = SourceZendeskSupport().check_connection(logger=logging.Logger, config=config)
179179
assert check_passed == ok
180180
if ok:
181181
mock_method.assert_called()

docs/integrations/sources/zendesk-support.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ The Zendesk Support source connector supports the following streams:
132132
The Zendesk Support connector fetches deleted records in the following streams:
133133

134134
| Stream | Deletion indicator field |
135-
| :----------------------- | :----------------------- |
135+
|:-------------------------|:-------------------------|
136136
| **Brands** | `is_deleted` |
137137
| **Groups** | `deleted` |
138138
| **Organizations** | `deleted_at` |
@@ -164,6 +164,7 @@ The Zendesk connector ideally should not run into Zendesk API limitations under
164164

165165
| Version | Date | Pull Request | Subject |
166166
|:--------|:-----------|:---------------------------------------------------------|:-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
167+
| 2.6.5 | 2024-05-23 | [38607](https://github.com/airbytehq/airbyte/pull/38607) | migrate to cursor based pagination in stream `Organization memberships` |
167168
| 2.6.4 | 2024-05-20 | [38310](https://github.com/airbytehq/airbyte/pull/38310) | Fix record filter for `Ticket Metrics` stream |
168169
| 2.6.3 | 2024-05-02 | [36669](https://github.com/airbytehq/airbyte/pull/36669) | Schema descriptions |
169170
| 2.6.2 | 2024-02-05 | [37761](https://github.com/airbytehq/airbyte/pull/37761) | Add stop condition for `Ticket Audits` when recieved old records; Ignore 403 and 404 status codes. |

0 commit comments

Comments
 (0)