Skip to content

Commit 9b9f34e

Browse files
allow "java" connectors to be written in kotlin (#37485)
Today, we don't allow java connectors to be written in kotlin. We could add a new language KOTLIN, but since all the targets are the same, it seems overkill. So i'm just changing the condition for language=JAVA
1 parent 352fc28 commit 9b9f34e

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

airbyte-ci/connectors/connector_ops/connector_ops/utils.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -380,7 +380,7 @@ def language(self) -> ConnectorLanguage:
380380
return ConnectorLanguage.LOW_CODE
381381
if Path(self.code_directory / "setup.py").is_file() or Path(self.code_directory / "pyproject.toml").is_file():
382382
return ConnectorLanguage.PYTHON
383-
if Path(self.code_directory / "src" / "main" / "java").exists():
383+
if Path(self.code_directory / "src" / "main" / "java").exists() or Path(self.code_directory / "src" / "main" / "kotlin").exists():
384384
return ConnectorLanguage.JAVA
385385
return None
386386

airbyte-ci/connectors/pipelines/README.md

+1
Original file line numberDiff line numberDiff line change
@@ -649,6 +649,7 @@ E.G.: running Poe tasks on the modified internal packages of the current branch:
649649

650650
| Version | PR | Description |
651651
| ------- | ---------------------------------------------------------- |----------------------------------------------------------------------------------------------------------------------------|
652+
| 4.7.4 | [#37485](https://github.com/airbytehq/airbyte/pull/37485) | Allow java connectors to be written in kotlin. |
652653
| 4.7.3 | [#37101](https://github.com/airbytehq/airbyte/pull/37101) | Pin PyAirbyte version. |
653654
| 4.7.2 | [#36962](https://github.com/airbytehq/airbyte/pull/36962) | Re-enable connector dependencies upload on publish. |
654655
| 4.7.1 | [#36961](https://github.com/airbytehq/airbyte/pull/36961) | Temporarily disable python connectors dependencies upload until we find a schema the data team can work with. |

airbyte-ci/connectors/pipelines/pyproject.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ build-backend = "poetry.core.masonry.api"
44

55
[tool.poetry]
66
name = "pipelines"
7-
version = "4.7.3"
7+
version = "4.7.4"
88
description = "Packaged maintained by the connector operations team to perform CI for connectors' pipelines"
99
authors = ["Airbyte <[email protected]>"]
1010

0 commit comments

Comments
 (0)