Skip to content

Commit 9ac6474

Browse files
stephane-airbytestephane-airbyte
committed
remove all display names
1 parent c9342ca commit 9ac6474

File tree

15 files changed

+49
-59
lines changed

15 files changed

+49
-59
lines changed

‎airbyte-cdk/java/airbyte-cdk/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,7 @@ MavenLocal debugging steps:
166166

167167
| Version | Date | Pull Request | Subject |
168168
|:--------|:-----------|:-----------------------------------------------------------|:---------------------------------------------------------------------------------------------------------------------------------------------------------------|
169+
| 0.23.5 | 2024-02-26 | [\#35512](https://github.com/airbytehq/airbyte/pull/35512) | Rmove @DisplayName from all CDK tests. |
169170
| 0.23.4 | 2024-02-26 | [\#35507](https://github.com/airbytehq/airbyte/pull/35507) | Add more logs into TestDatabase. |
170171
| 0.23.3 | 2024-02-26 | [\#35495](https://github.com/airbytehq/airbyte/pull/35495) | Fix Junit Interceptor to print better stacktraces |
171172
| 0.23.2 | 2024-02-22 | [\#35385](https://github.com/airbytehq/airbyte/pull/35342) | Bugfix: inverted logic of disableTypeDedupe flag |

‎airbyte-cdk/java/airbyte-cdk/core/src/main/resources/version.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
version=0.23.4
1+
version=0.23.5

‎airbyte-cdk/java/airbyte-cdk/db-sources/src/test/java/io/airbyte/cdk/integrations/source/relationaldb/StateDecoratingIteratorTest.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@
3030
import java.util.Collections;
3131
import java.util.Iterator;
3232
import org.junit.jupiter.api.BeforeEach;
33-
import org.junit.jupiter.api.DisplayName;
3433
import org.junit.jupiter.api.Test;
3534
import org.testcontainers.shaded.com.google.common.collect.ImmutableMap;
3635

@@ -289,7 +288,7 @@ void testUnicodeNull() {
289288
}
290289

291290
@Test
292-
@DisplayName("When initial cursor is null, and emit state for every record")
291+
// When initial cursor is null, and emit state for every record
293292
void testStateEmissionFrequency1() {
294293
messageIterator = MoreIterators.of(RECORD_MESSAGE_1, RECORD_MESSAGE_2, RECORD_MESSAGE_3, RECORD_MESSAGE_4, RECORD_MESSAGE_5);
295294
final StateDecoratingIterator iterator1 = new StateDecoratingIterator(
@@ -320,7 +319,7 @@ void testStateEmissionFrequency1() {
320319
}
321320

322321
@Test
323-
@DisplayName("When initial cursor is null, and emit state for every 2 records")
322+
// When initial cursor is null, and emit state for every 2 records
324323
void testStateEmissionFrequency2() {
325324
messageIterator = MoreIterators.of(RECORD_MESSAGE_1, RECORD_MESSAGE_2, RECORD_MESSAGE_3, RECORD_MESSAGE_4, RECORD_MESSAGE_5);
326325
final StateDecoratingIterator iterator1 = new StateDecoratingIterator(
@@ -346,7 +345,7 @@ void testStateEmissionFrequency2() {
346345
}
347346

348347
@Test
349-
@DisplayName("When initial cursor is not null")
348+
// When initial cursor is not null
350349
void testStateEmissionWhenInitialCursorIsNotNull() {
351350
messageIterator = MoreIterators.of(RECORD_MESSAGE_2, RECORD_MESSAGE_3, RECORD_MESSAGE_4, RECORD_MESSAGE_5);
352351
final StateDecoratingIterator iterator1 = new StateDecoratingIterator(
@@ -396,7 +395,7 @@ void testStateEmissionWhenInitialCursorIsNotNull() {
396395
* <a href="https://github.com/airbytehq/airbyte/issues/15427">link</a>
397396
*/
398397
@Test
399-
@DisplayName("When there are multiple records with the same cursor value")
398+
// When there are multiple records with the same cursor value
400399
void testStateEmissionForRecordsSharingSameCursorValue() {
401400

402401
messageIterator = MoreIterators.of(

‎airbyte-cdk/java/airbyte-cdk/db-sources/src/testFixtures/java/io/airbyte/cdk/integrations/debezium/CdcSourceTest.java

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@
4949
import java.util.stream.Stream;
5050
import org.junit.jupiter.api.AfterEach;
5151
import org.junit.jupiter.api.BeforeEach;
52-
import org.junit.jupiter.api.DisplayName;
5352
import org.junit.jupiter.api.Test;
5453
import org.slf4j.Logger;
5554
import org.slf4j.LoggerFactory;
@@ -327,7 +326,7 @@ protected void assertExpectedRecords(final Set<JsonNode> expectedRecords,
327326
}
328327

329328
@Test
330-
@DisplayName("On the first sync, produce returns records that exist in the database.")
329+
// On the first sync, produce returns records that exist in the database.
331330
void testExistingData() throws Exception {
332331
final CdcTargetPosition targetPosition = cdcLatestTargetPosition();
333332
final AutoCloseableIterator<AirbyteMessage> read = source().read(config(), getConfiguredCatalog(), null);
@@ -351,7 +350,7 @@ protected void compareTargetPositionFromTheRecordsWithTargetPostionGeneratedBefo
351350
}
352351

353352
@Test
354-
@DisplayName("When a record is deleted, produces a deletion record.")
353+
// When a record is deleted, produces a deletion record.
355354
void testDelete() throws Exception {
356355
final AutoCloseableIterator<AirbyteMessage> read1 = source()
357356
.read(config(), getConfiguredCatalog(), null);
@@ -379,7 +378,7 @@ protected void assertExpectedStateMessagesFromIncrementalSync(final List<Airbyte
379378
}
380379

381380
@Test
382-
@DisplayName("When a record is updated, produces an update record.")
381+
// When a record is updated, produces an update record.
383382
void testUpdate() throws Exception {
384383
final String updatedModel = "Explorer";
385384
final AutoCloseableIterator<AirbyteMessage> read1 = source()
@@ -406,7 +405,8 @@ void testUpdate() throws Exception {
406405

407406
@SuppressWarnings({"BusyWait", "CodeBlock2Expr"})
408407
@Test
409-
@DisplayName("Verify that when data is inserted into the database while a sync is happening and after the first sync, it all gets replicated.")
408+
// Verify that when data is inserted into the database while a sync is happening and after the first
409+
// sync, it all gets replicated.
410410
protected void testRecordsProducedDuringAndAfterSync() throws Exception {
411411

412412
final int recordsToCreate = 20;
@@ -472,7 +472,8 @@ protected void assertExpectedStateMessagesForRecordsProducedDuringAndAfterSync(f
472472
}
473473

474474
@Test
475-
@DisplayName("When both incremental CDC and full refresh are configured for different streams in a sync, the data is replicated as expected.")
475+
// When both incremental CDC and full refresh are configured for different streams in a sync, the
476+
// data is replicated as expected.
476477
void testCdcAndFullRefreshInSameSync() throws Exception {
477478
final ConfiguredAirbyteCatalog configuredCatalog = Jsons.clone(getConfiguredCatalog());
478479

@@ -545,7 +546,7 @@ void testCdcAndFullRefreshInSameSync() throws Exception {
545546
}
546547

547548
@Test
548-
@DisplayName("When no records exist, no records are returned.")
549+
// When no records exist, no records are returned.
549550
void testNoData() throws Exception {
550551

551552
deleteCommand(MODELS_STREAM_NAME);
@@ -563,7 +564,7 @@ protected void assertExpectedStateMessagesForNoData(final List<AirbyteStateMessa
563564
}
564565

565566
@Test
566-
@DisplayName("When no changes have been made to the database since the previous sync, no records are returned.")
567+
// When no changes have been made to the database since the previous sync, no records are returned.
567568
void testNoDataOnSecondSync() throws Exception {
568569
final AutoCloseableIterator<AirbyteMessage> read1 = source()
569570
.read(config(), getConfiguredCatalog(), null);

‎airbyte-cdk/java/airbyte-cdk/dependencies/src/test/java/io/airbyte/api/client/AirbyteApiClientTest.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
import static org.mockito.Mockito.when;
1111

1212
import java.util.concurrent.Callable;
13-
import org.junit.jupiter.api.DisplayName;
1413
import org.junit.jupiter.api.Nested;
1514
import org.junit.jupiter.api.Test;
1615
import org.mockito.Mock;
@@ -28,7 +27,7 @@ public class AirbyteApiClientTest {
2827
class RetryWithJitter {
2928

3029
@Test
31-
@DisplayName("Should not retry on success")
30+
// Should not retry on success
3231
void ifSucceedShouldNotRetry() throws Exception {
3332
mockCallable = mock(Callable.class);
3433
when(mockCallable.call()).thenReturn("Success!");
@@ -39,7 +38,7 @@ void ifSucceedShouldNotRetry() throws Exception {
3938
}
4039

4140
@Test
42-
@DisplayName("Should retry up to the configured max retries on continued errors")
41+
// Should retry up to the configured max retries on continued errors
4342
void onlyRetryTillMaxRetries() throws Exception {
4443
mockCallable = mock(Callable.class);
4544
when(mockCallable.call()).thenThrow(new RuntimeException("Bomb!"));
@@ -51,7 +50,7 @@ void onlyRetryTillMaxRetries() throws Exception {
5150
}
5251

5352
@Test
54-
@DisplayName("Should retry only if there are errors")
53+
// Should retry only if there are errors
5554
void onlyRetryOnErrors() throws Exception {
5655
mockCallable = mock(Callable.class);
5756
// Because we succeed on the second try, we should only call the method twice.

‎airbyte-cdk/java/airbyte-cdk/dependencies/src/test/java/io/airbyte/commons/logging/MdcScopeTest.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
import java.util.Map;
88
import org.assertj.core.api.Assertions;
99
import org.junit.jupiter.api.BeforeEach;
10-
import org.junit.jupiter.api.DisplayName;
1110
import org.junit.jupiter.api.Test;
1211
import org.slf4j.MDC;
1312

@@ -23,7 +22,7 @@ void init() {
2322
}
2423

2524
@Test
26-
@DisplayName("The MDC context is properly overrided")
25+
// The MDC context is properly overrided
2726
void testMDCModified() {
2827
try (final MdcScope ignored = new MdcScope(modificationInMDC)) {
2928
final Map<String, String> mdcState = MDC.getCopyOfContextMap();
@@ -34,7 +33,7 @@ void testMDCModified() {
3433
}
3534

3635
@Test
37-
@DisplayName("The MDC context is properly restored")
36+
// The MDC context is properly restored
3837
void testMDCRestore() {
3938
try (final MdcScope ignored = new MdcScope(modificationInMDC)) {}
4039

‎airbyte-cdk/java/airbyte-cdk/dependencies/src/test/java/io/airbyte/configoss/helpers/YamlListToStandardDefinitionsTest.java

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
import com.fasterxml.jackson.databind.ObjectMapper;
1212
import io.airbyte.commons.jackson.MoreMappers;
1313
import io.airbyte.configoss.StandardDestinationDefinition;
14-
import org.junit.jupiter.api.DisplayName;
1514
import org.junit.jupiter.api.Nested;
1615
import org.junit.jupiter.api.Test;
1716

@@ -57,15 +56,15 @@ class YamlListToStandardDefinitionsTest {
5756
+ " documentationUrl";
5857

5958
@Nested
60-
@DisplayName("vertifyAndConvertToJsonNode")
59+
// vertifyAndConvertToJsonNode
6160
class VerifyAndConvertToJsonNode {
6261

6362
private static final String ID_NAME = "destinationDefinitionId";
6463

6564
private final ObjectMapper mapper = MoreMappers.initMapper();
6665

6766
@Test
68-
@DisplayName("should correctly read yaml file")
67+
// should correctly read yaml file
6968
void correctlyReadTest() throws JsonProcessingException {
7069
final var jsonDefs = YamlListToStandardDefinitions.verifyAndConvertToJsonNode(ID_NAME, GOOD_DES_DEF_YAML);
7170
final var defList = mapper.treeToValue(jsonDefs, StandardDestinationDefinition[].class);
@@ -74,37 +73,37 @@ void correctlyReadTest() throws JsonProcessingException {
7473
}
7574

7675
@Test
77-
@DisplayName("should error out on duplicate id")
76+
// should error out on duplicate id
7877
void duplicateIdTest() {
7978
assertThrows(RuntimeException.class, () -> YamlListToStandardDefinitions.verifyAndConvertToJsonNode(ID_NAME, DUPLICATE_ID));
8079
}
8180

8281
@Test
83-
@DisplayName("should error out on duplicate name")
82+
// should error out on duplicate name
8483
void duplicateNameTest() {
8584
assertThrows(RuntimeException.class, () -> YamlListToStandardDefinitions.verifyAndConvertToJsonNode(ID_NAME, DUPLICATE_NAME));
8685
}
8786

8887
@Test
89-
@DisplayName("should error out on empty file")
88+
// should error out on empty file
9089
void emptyFileTest() {
9190
assertThrows(RuntimeException.class, () -> YamlListToStandardDefinitions.verifyAndConvertToJsonNode(ID_NAME, ""));
9291
}
9392

9493
@Test
95-
@DisplayName("should error out on bad data")
94+
// should error out on bad data
9695
void badDataTest() {
9796
assertThrows(RuntimeException.class, () -> YamlListToStandardDefinitions.verifyAndConvertToJsonNode(ID_NAME, BAD_DATA));
9897
}
9998

10099
}
101100

102101
@Nested
103-
@DisplayName("verifyAndConvertToModelList")
102+
// verifyAndConvertToModelList
104103
class VerifyAndConvertToModelList {
105104

106105
@Test
107-
@DisplayName("should correctly read yaml file")
106+
// should correctly read yaml file
108107
void correctlyReadTest() {
109108
final var defs = YamlListToStandardDefinitions
110109
.verifyAndConvertToModelList(StandardDestinationDefinition.class, GOOD_DES_DEF_YAML);
@@ -113,28 +112,28 @@ void correctlyReadTest() {
113112
}
114113

115114
@Test
116-
@DisplayName("should error out on duplicate id")
115+
// should error out on duplicate id
117116
void duplicateIdTest() {
118117
assertThrows(RuntimeException.class,
119118
() -> YamlListToStandardDefinitions.verifyAndConvertToModelList(StandardDestinationDefinition.class, DUPLICATE_ID));
120119
}
121120

122121
@Test
123-
@DisplayName("should error out on duplicate name")
122+
// should error out on duplicate name
124123
void duplicateNameTest() {
125124
assertThrows(RuntimeException.class,
126125
() -> YamlListToStandardDefinitions.verifyAndConvertToModelList(StandardDestinationDefinition.class, DUPLICATE_NAME));
127126
}
128127

129128
@Test
130-
@DisplayName("should error out on empty file")
129+
// should error out on empty file
131130
void emptyFileTest() {
132131
assertThrows(RuntimeException.class,
133132
() -> YamlListToStandardDefinitions.verifyAndConvertToModelList(StandardDestinationDefinition.class, ""));
134133
}
135134

136135
@Test
137-
@DisplayName("should error out on bad data")
136+
// should error out on bad data
138137
void badDataTest() {
139138
assertThrows(RuntimeException.class,
140139
() -> YamlListToStandardDefinitions.verifyAndConvertToModelList(StandardDestinationDefinition.class, BAD_DATA));

‎airbyte-cdk/java/airbyte-cdk/dependencies/src/test/java/io/airbyte/workers/TestHarnessUtilsTest.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
import java.util.function.BiConsumer;
2525
import org.apache.commons.lang3.tuple.ImmutablePair;
2626
import org.junit.jupiter.api.BeforeEach;
27-
import org.junit.jupiter.api.DisplayName;
2827
import org.junit.jupiter.api.Nested;
2928
import org.junit.jupiter.api.Test;
3029
import org.slf4j.Logger;
@@ -65,7 +64,7 @@ private void runShutdown() {
6564
}
6665

6766
@SuppressWarnings("BusyWait")
68-
@DisplayName("Verify that shutdown waits indefinitely when heartbeat and process are healthy.")
67+
// Verify that shutdown waits indefinitely when heartbeat and process are healthy.
6968
@Test
7069
void testStartsWait() throws InterruptedException {
7170
when(process.isAlive()).thenReturn(true);
@@ -86,7 +85,7 @@ void testStartsWait() throws InterruptedException {
8685
}
8786

8887
@Test
89-
@DisplayName("Test heartbeat ends and graceful shutdown.")
88+
// Test heartbeat ends and graceful shutdown.
9089
void testGracefulShutdown() {
9190
when(heartbeatMonitor.isBeating()).thenReturn(false);
9291
when(process.isAlive()).thenReturn(false);
@@ -97,7 +96,7 @@ void testGracefulShutdown() {
9796
}
9897

9998
@Test
100-
@DisplayName("Test heartbeat ends and shutdown is forced.")
99+
// Test heartbeat ends and shutdown is forced.
101100
void testForcedShutdown() {
102101
when(heartbeatMonitor.isBeating()).thenReturn(false);
103102
when(process.isAlive()).thenReturn(true);
@@ -108,7 +107,7 @@ void testForcedShutdown() {
108107
}
109108

110109
@Test
111-
@DisplayName("Test process dies.")
110+
// Test process dies.
112111
void testProcessDies() {
113112
when(heartbeatMonitor.isBeating()).thenReturn(true);
114113
when(process.isAlive()).thenReturn(false);

‎airbyte-cdk/java/airbyte-cdk/gcs-destinations/src/test/java/io/airbyte/cdk/integrations/destination/gcs/csv/GcsCsvFormatConfigTest.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,13 @@
1818
import io.airbyte.cdk.integrations.destination.s3.util.StreamTransferManagerFactory;
1919
import io.airbyte.commons.json.Jsons;
2020
import org.apache.commons.lang3.reflect.FieldUtils;
21-
import org.junit.jupiter.api.DisplayName;
2221
import org.junit.jupiter.api.Test;
2322

24-
@DisplayName("GcsCsvFormatConfig")
23+
// GcsCsvFormatConfig
2524
public class GcsCsvFormatConfigTest {
2625

2726
@Test
28-
@DisplayName("Flattening enums can be created from value string")
27+
// Flattening enums can be created from value string
2928
public void testFlatteningCreationFromString() {
3029
assertEquals(Flattening.NO, Flattening.fromValue("no flattening"));
3130
assertEquals(Flattening.ROOT_LEVEL, Flattening.fromValue("root level flattening"));

‎airbyte-cdk/java/airbyte-cdk/gcs-destinations/src/test/java/io/airbyte/cdk/integrations/destination/gcs/jsonl/GcsJsonlFormatConfigTest.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,9 @@
1616
import io.airbyte.cdk.integrations.destination.s3.util.StreamTransferManagerFactory;
1717
import io.airbyte.commons.json.Jsons;
1818
import org.apache.commons.lang3.reflect.FieldUtils;
19-
import org.junit.jupiter.api.DisplayName;
2019
import org.junit.jupiter.api.Test;
2120

22-
@DisplayName("GcsJsonlFormatConfig")
21+
// GcsJsonlFormatConfig
2322
public class GcsJsonlFormatConfigTest {
2423

2524
@Test

‎airbyte-cdk/java/airbyte-cdk/s3-destinations/src/test/java/io/airbyte/cdk/integrations/destination/s3/S3FormatConfigsTest.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,13 @@
1313
import io.airbyte.cdk.integrations.destination.s3.util.Flattening;
1414
import io.airbyte.commons.json.Jsons;
1515
import java.util.Map;
16-
import org.junit.jupiter.api.DisplayName;
1716
import org.junit.jupiter.api.Test;
1817

19-
@DisplayName("S3FormatConfigs")
18+
// S3FormatConfigs
2019
public class S3FormatConfigsTest {
2120

2221
@Test
23-
@DisplayName("When CSV format is specified, it returns CSV format config")
22+
// When CSV format is specified, it returns CSV format config
2423
public void testGetCsvS3FormatConfig() {
2524
final JsonNode configJson = Jsons.jsonNode(Map.of(
2625
"format", Jsons.jsonNode(Map.of(

‎airbyte-cdk/java/airbyte-cdk/s3-destinations/src/test/java/io/airbyte/cdk/integrations/destination/s3/csv/S3CsvFormatConfigTest.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,13 @@
2020
import io.airbyte.cdk.integrations.destination.s3.util.StreamTransferManagerFactory;
2121
import io.airbyte.commons.json.Jsons;
2222
import org.apache.commons.lang3.reflect.FieldUtils;
23-
import org.junit.jupiter.api.DisplayName;
2423
import org.junit.jupiter.api.Test;
2524

26-
@DisplayName("S3CsvFormatConfig")
25+
// S3CsvFormatConfig
2726
public class S3CsvFormatConfigTest {
2827

2928
@Test
30-
@DisplayName("Flattening enums can be created from value string")
29+
// Flattening enums can be created from value string
3130
public void testFlatteningCreationFromString() {
3231
assertEquals(Flattening.NO, Flattening.fromValue("no flattening"));
3332
assertEquals(Flattening.ROOT_LEVEL, Flattening.fromValue("root level flattening"));

0 commit comments

Comments
 (0)