Skip to content

Commit 9a22900

Browse files
committed
fix primary key in configured_catalog
1 parent b7fba06 commit 9a22900

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

airbyte-integrations/connectors/source-google-ads/integration_tests/configured_catalog.json

+5-4
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
"json_schema": {},
3131
"supported_sync_modes": ["full_refresh", "incremental"],
3232
"source_defined_cursor": true,
33+
"source_defined_primary_key": [["click_view.gclid", "segments.date"]],
3334
"default_cursor_field": ["segments.date"]
3435
},
3536
"sync_mode": "incremental",
@@ -102,7 +103,7 @@
102103
"json_schema": {},
103104
"supported_sync_modes": ["full_refresh", "incremental"],
104105
"source_defined_cursor": true,
105-
"source_defined_primary_key": [["ad_group_ad.ad.id"]],
106+
"source_defined_primary_key": [["ad_group_ad.ad.id", "segments.date"]],
106107
"default_cursor_field": ["segments.date"]
107108
},
108109
"sync_mode": "incremental",
@@ -116,7 +117,7 @@
116117
"supported_sync_modes": ["full_refresh", "incremental"],
117118
"source_defined_cursor": true,
118119
"default_cursor_field": ["segments.date"],
119-
"source_defined_primary_key": [["ad_group.id"]]
120+
"source_defined_primary_key": [["ad_group.id", "segments.date"]]
120121
},
121122
"sync_mode": "incremental",
122123
"destination_sync_mode": "overwrite",
@@ -129,7 +130,7 @@
129130
"supported_sync_modes": ["full_refresh", "incremental"],
130131
"source_defined_cursor": true,
131132
"default_cursor_field": ["segments.date"],
132-
"source_defined_primary_key": [["customer.id"]]
133+
"source_defined_primary_key": [["customer.id", "segments.date"]]
133134
},
134135
"sync_mode": "incremental",
135136
"destination_sync_mode": "overwrite",
@@ -142,7 +143,7 @@
142143
"supported_sync_modes": ["full_refresh", "incremental"],
143144
"source_defined_cursor": true,
144145
"default_cursor_field": ["segments.date"],
145-
"source_defined_primary_key": [["campaign.id"]]
146+
"source_defined_primary_key": [["campaign.id", "segments.date"]]
146147
},
147148
"sync_mode": "incremental",
148149
"destination_sync_mode": "overwrite",

airbyte-integrations/connectors/source-google-ads/source_google_ads/streams.py

+1
Original file line numberDiff line numberDiff line change
@@ -306,5 +306,6 @@ class ClickView(IncrementalGoogleAdsStream):
306306
ClickView stream: https://developers.google.com/google-ads/api/reference/rpc/v8/ClickView
307307
"""
308308

309+
primary_key = ["click_view.gclid", "segments.date"]
309310
days_of_data_storage = 90
310311
range_days = 1

0 commit comments

Comments
 (0)