Source Notion: Migrate to Low-Code (#35974)

Co-authored-by: Anatolii Yatsuk <[email protected]>
Co-authored-by: Anatolii Yatsuk <[email protected]>

Author: ChristoGrab

airbyte-integrations/connectors/source-notion/.coveragerc

@@ -0,0 +1,3 @@
+[run]
+omit = 
+    source_notion/run.py

airbyte-integrations/connectors/source-notion/integration_tests/abnormal_state.json

@@ -31,5 +31,57 @@
         "name": "blocks"
       }
     }
+  },
+  {
+    "type": "STREAM",
+    "stream": {
+      "stream_descriptor": { "name": "comments", "namespace": null },
+      "stream_state": {
+        "states": [
+          {
+            "partition": {
+              "id": "9cca331a-1edb-4120-9a86-cf40214fac37",
+              "parent_slice": {}
+            },
+            "cursor": { "last_edited_time": "2099-10-10T13:51:00.000Z" }
+          },
+          {
+            "partition": {
+              "id": "8fbb79d0-f858-4fe7-9e88-6b4019c72365",
+              "parent_slice": {}
+            },
+            "cursor": { "last_edited_time": "2099-10-10T13:53:00.000Z" }
+          },
+          {
+            "partition": {
+              "id": "18fe94d2-60ec-4a7e-be86-b43e5c9198af",
+              "parent_slice": {}
+            },
+            "cursor": { "last_edited_time": "2099-10-10T13:47:00.000Z" }
+          },
+          {
+            "partition": {
+              "id": "249f3796-7e81-47b0-9075-00ed2d06439d",
+              "parent_slice": {}
+            },
+            "cursor": { "last_edited_time": "2099-09-12T20:55:00.000Z" }
+          },
+          {
+            "partition": {
+              "id": "29299296-ef3f-4aff-aef5-02d651a59be3",
+              "parent_slice": {}
+            },
+            "cursor": { "last_edited_time": "2099-09-12T20:56:00.000Z" }
+          },
+          {
+            "partition": {
+              "id": "a55d276e-4bc2-4fcc-9fb3-e60b867c86e7",
+              "parent_slice": {}
+            },
+            "cursor": { "last_edited_time": "2099-10-10T13:52:00.000Z" }
+          }
+        ]
+      }
+    }
   }
 ]

airbyte-integrations/connectors/source-notion/integration_tests/catalog.json

@@ -8,7 +8,7 @@
         "default_primary_key": [["id"]]
       },
       "sync_mode": "full_refresh",
-      "destination_sync_mode": "overwrite",
+      "destination_sync_mode": "append",
       "primary_key": [["id"]]
     },
     {
@@ -22,7 +22,7 @@
       },
       "primary_key": [["id"]],
       "cursor_field": ["last_edited_time"],
-      "sync_mode": "incremental",
+      "sync_mode": "full_refresh",
       "destination_sync_mode": "append"
     },
     {
@@ -36,7 +36,7 @@
       },
       "primary_key": [["id"]],
       "cursor_field": ["last_edited_time"],
-      "sync_mode": "incremental",
+      "sync_mode": "full_refresh",
       "destination_sync_mode": "append"
     },
     {
@@ -50,7 +50,7 @@
       },
       "primary_key": [["id"]],
       "cursor_field": ["last_edited_time"],
-      "sync_mode": "incremental",
+      "sync_mode": "full_refresh",
       "destination_sync_mode": "append"
     },
     {
@@ -60,11 +60,11 @@
         "supported_sync_modes": ["full_refresh", "incremental"],
         "source_defined_cursor": true,
         "default_primary_key": [["id"]],
-        "default_cursor_field": ["page_last_edited_time"]
+        "default_cursor_field": ["last_edited_time"]
       },
       "primary_key": [["id"]],
-      "cursor_field": ["page_last_edited_time"],
-      "sync_mode": "incremental",
+      "cursor_field": ["last_edited_time"],
+      "sync_mode": "full_refresh",
       "destination_sync_mode": "append"
     }
   ]

airbyte-integrations/connectors/source-notion/integration_tests/configured_catalog.json

@@ -41,6 +41,20 @@
       "cursor_field": ["last_edited_time"],
       "sync_mode": "incremental",
       "destination_sync_mode": "append"
+    },
+    {
+      "stream": {
+        "name": "comments",
+        "json_schema": {},
+        "supported_sync_modes": ["full_refresh", "incremental"],
+        "source_defined_cursor": true,
+        "default_primary_key": [["id"]],
+        "default_cursor_field": ["last_edited_time"]
+      },
+      "primary_key": [["id"]],
+      "cursor_field": ["last_edited_time"],
+      "sync_mode": "incremental",
+      "destination_sync_mode": "append"
     }
   ]
 }

airbyte-integrations/connectors/source-notion/integration_tests/incremental_catalog.json

@@ -10,7 +10,7 @@ data:
   connectorSubtype: api
   connectorType: source
   definitionId: 6e00b415-b02e-4160-bf02-58176a0ae687
-  dockerImageTag: 2.2.0
+  dockerImageTag: 3.0.0
   dockerRepository: airbyte/source-notion
   documentationUrl: https://docs.airbyte.com/integrations/sources/notion
   githubIssueLabel: source-notion
@@ -30,6 +30,18 @@ data:
   releaseStage: generally_available
   releases:
     breakingChanges:
+      3.0.0:
+        message:
+          The source Notion connector is being migrated from the Python CDK to our declarative low-code CDK.
+          Due to changes in the handling of state format between these CDKs, this migration constitutes a breaking change
+          for users syncing the `Comments` stream.
+          To ensure a smooth migration, please reset your data for this stream upon updating. This will facilitate a fresh first sync.
+          If you are not syncing the `Comments` stream, you can upgrade without any further action.
+          For more information, see our migration documentation for source Notion.
+        upgradeDeadline: "2024-04-29"
+        scopedImpact:
+          - scopeType: stream
+            impactedScopes: ["comments"]
       2.0.0:
         message:
           Version 2.0.0 introduces schema changes to multiple properties shared
@@ -46,5 +58,5 @@ data:
   supportLevel: certified
   tags:
     - language:python
-    - cdk:python
+    - cdk:low-code
 metadataSpecVersion: "1.0"