Skip to content

Commit 8fd7367

Browse files
šŸ› migrate-to-manifest-only: conditionally propagate $parameters when resolving manifest (#44557)
Co-authored-by: Natik Gadzhi <[email protected]>
1 parent 10f8f3f commit 8fd7367

File tree

6 files changed

+1676
-6
lines changed

6 files changed

+1676
-6
lines changed

ā€Žairbyte-ci/connectors/pipelines/README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -842,7 +842,8 @@ airbyte-ci connectors --language=low-code migrate-to-manifest-only
842842
## Changelog
843843

844844
| Version | PR | Description |
845-
| ------- | ---------------------------------------------------------- | ---------------------------------------------------------------------------------------------------------------------------- |
845+
| ------- | ---------------------------------------------------------- |------------------------------------------------------------------------------------------------------------------------------|
846+
| 4.34.1 | [#44557](https://github.com/airbytehq/airbyte/pull/44557) | Conditionally propagate parameters in manifest-only migration |
846847
| 4.34.0 | [#44551](https://github.com/airbytehq/airbyte/pull/44551) | `connectors publish` do not push the `latest` tag when the current version is a release candidate. |
847848
| 4.33.1 | [#44465](https://github.com/airbytehq/airbyte/pull/44465) | Ignore version check if only erd folder is changed |
848849
| 4.33.0 | [#44377](https://github.com/airbytehq/airbyte/pull/44377) | Upload connector SBOM to metadata service bucket on publish. |

ā€Žairbyte-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/migrate_to_inline_schemas/pipeline.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ async def _run(self) -> StepResult:
198198
_update_inline_schema(schema_loader, json_streams, stream_name)
199199

200200
write_yaml(data, manifest_path)
201-
await format_prettier([manifest_path], logger=logger)
201+
# await format_prettier([manifest_path], logger=logger)
202202

203203
for json_stream in json_streams.values():
204204
logger.info(f" !! JSON schema not found: {json_stream.name}")

0 commit comments

Comments
Ā (0)