Skip to content

Commit 8fbd12d

Browse files
🪟 🔧 Remove utmStorage util (#22194)
This method was only effective when we redirect users directly to cloud.airbyte.io/signup?utm_source..... but wasn't working when users first landed in airbyte.com with UTM params and then end up signing up. We are managing UTM params with cross domain cookies in the different tools we use to measure attribution (GA and Hubspot) so we don't need this anymore.
1 parent ca0792d commit 8fbd12d

File tree

5 files changed

+0
-81
lines changed

5 files changed

+0
-81
lines changed

airbyte-webapp/src/packages/cloud/cloudRoutes.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import { useQuery } from "hooks/useQuery";
1212
import { useAuthService } from "packages/cloud/services/auth/AuthService";
1313
import { useCurrentWorkspace, WorkspaceServiceProvider } from "services/workspaces/WorkspacesService";
1414
import { setSegmentAnonymousId, useGetSegmentAnonymousId } from "utils/crossDomainUtils";
15-
import { storeUtmFromQuery } from "utils/utmStorage";
1615
import { CompleteOauthRequest } from "views/CompleteOauthRequest";
1716

1817
import { CloudRoutes } from "./cloudRoutePaths";
@@ -119,7 +118,6 @@ export const Routing: React.FC = () => {
119118
const { search } = useLocation();
120119

121120
useEffectOnce(() => {
122-
storeUtmFromQuery(search);
123121
setSegmentAnonymousId(search);
124122
});
125123

airbyte-webapp/src/packages/cloud/services/auth/AuthService.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ import { User } from "packages/cloud/lib/domain/users";
1818
import { useGetUserService } from "packages/cloud/services/users/UserService";
1919
import { useAuth } from "packages/firebaseReact";
2020
import { useInitService } from "services/useInitService";
21-
import { getUtmFromStorage } from "utils/utmStorage";
2221

2322
import { FREE_EMAIL_SERVICE_PROVIDERS } from "./freeEmailProviders";
2423
import { actions, AuthServiceState, authStateReducer, initialState } from "./reducer";
@@ -119,7 +118,6 @@ export const AuthenticationProvider: React.FC<React.PropsWithChildren<unknown>>
119118
isCorporate: ctx.hasCorporateEmail(user.email),
120119
// Which login provider was used, e.g. "password", "google.com", "github.com"
121120
provider: firebaseUser.providerData[0]?.providerId,
122-
...getUtmFromStorage(),
123121
});
124122

125123
return user;

airbyte-webapp/src/pages/routes.tsx

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,12 @@
11
import React, { useMemo } from "react";
22
import { Navigate, Route, Routes, useLocation } from "react-router-dom";
3-
import { useEffectOnce } from "react-use";
43

54
import { ApiErrorBoundary } from "components/common/ApiErrorBoundary";
65

76
import { useAnalyticsIdentifyUser, useAnalyticsRegisterValues } from "hooks/services/Analytics";
87
import { useApiHealthPoll } from "hooks/services/Health";
98
import { useCurrentWorkspace } from "hooks/services/useWorkspace";
109
import { useListWorkspaces } from "services/workspaces/WorkspacesService";
11-
import { storeUtmFromQuery } from "utils/utmStorage";
1210
import { CompleteOauthRequest } from "views/CompleteOauthRequest";
1311
import MainView from "views/layout/MainView";
1412

@@ -94,12 +92,6 @@ const RoutingWithWorkspace: React.FC<{ element?: JSX.Element }> = ({ element })
9492
};
9593

9694
export const Routing: React.FC = () => {
97-
const { search } = useLocation();
98-
99-
useEffectOnce(() => {
100-
storeUtmFromQuery(search);
101-
});
102-
10395
// TODO: Remove this after it is verified there are no problems with current routing
10496
const OldRoutes = useMemo(
10597
() =>

airbyte-webapp/src/utils/utmStorage.test.ts

Lines changed: 0 additions & 47 deletions
This file was deleted.

airbyte-webapp/src/utils/utmStorage.ts

Lines changed: 0 additions & 22 deletions
This file was deleted.

0 commit comments

Comments
 (0)