Skip to content

Commit 8ab89d3

Browse files
authored
🐛 Airbyte-ci: Track deletions when generating pull request (#43934)
1 parent 6edefbe commit 8ab89d3

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

airbyte-ci/connectors/pipelines/README.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -789,7 +789,8 @@ airbyte-ci connectors --language=low-code migrate-to-manifest-only
789789

790790
| Version | PR | Description |
791791
| ------- | ---------------------------------------------------------- | ---------------------------------------------------------------------------------------------------------------------------- |
792-
| 4.31.4 | [#43724](https://github.com/airbytehq/airbyte/pull/43724) | Do not send slack message on connector pre-release. |
792+
| 4.31.5 | [#43934](https://github.com/airbytehq/airbyte/pull/43934) | Track deleted files when generating pull-request |
793+
| 4.31.4 | [#43724](https://github.com/airbytehq/airbyte/pull/43724) | Do not send slack message on connector pre-release. |
793794
| 4.31.3 | [#43426](https://github.com/airbytehq/airbyte/pull/43426) | Ignore archived connectors on connector selection from modified files. |
794795
| 4.31.2 | [#43433](https://github.com/airbytehq/airbyte/pull/43433) | Fix 'changed_file' indentation in 'pull-request' command |
795796
| 4.31.1 | [#43442](https://github.com/airbytehq/airbyte/pull/43442) | Resolve type check failure in bump version |

airbyte-ci/connectors/pipelines/pipelines/helpers/github.py

+4
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,10 @@ def create_or_update_github_pull_request(
153153
blob = repo.create_git_blob(content, "base64")
154154
changed_file = ChangedFile(path=str(modified_file), sha=blob.sha)
155155
changed_files.append(changed_file)
156+
else:
157+
logger.info(f"{modified_file} no longer exists, adding to PR as a deletion")
158+
changed_file = ChangedFile(path=str(modified_file), sha=None)
159+
changed_files.append(changed_file)
156160
existing_ref = None
157161
try:
158162
existing_ref = repo.get_git_ref(f"heads/{branch_id}")

airbyte-ci/connectors/pipelines/pyproject.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ build-backend = "poetry.core.masonry.api"
44

55
[tool.poetry]
66
name = "pipelines"
7-
version = "4.31.4"
7+
version = "4.31.5"
88
description = "Packaged maintained by the connector operations team to perform CI for connectors' pipelines"
99
authors = ["Airbyte <[email protected]>"]
1010

0 commit comments

Comments
 (0)