Skip to content

Commit 884b216

Browse files
fix compiler errors
1 parent 7688cc8 commit 884b216

File tree

5 files changed

+12
-14
lines changed

5 files changed

+12
-14
lines changed

airbyte-cdk/java/airbyte-cdk/azure-destinations/build.gradle

+6
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,9 @@
1+
compileKotlin {
2+
compilerOptions {
3+
allWarningsAsErrors = false
4+
}
5+
}
6+
17
dependencies {
28
implementation project(':airbyte-cdk:java:airbyte-cdk:dependencies')
39
implementation project(':airbyte-cdk:java:airbyte-cdk:core')

airbyte-cdk/java/airbyte-cdk/azure-destinations/src/main/kotlin/io/airbyte/cdk/integrations/destination/jdbc/copy/azure/AzureBlobStorageConfig.kt

+2-5
Original file line numberDiff line numberDiff line change
@@ -6,16 +6,13 @@ package io.airbyte.cdk.integrations.destination.jdbc.copy.azure
66
import com.fasterxml.jackson.databind.JsonNode
77
import java.util.*
88

9-
class AzureBlobStorageConfig(private val endpointDomainName: String?,
9+
class AzureBlobStorageConfig(val endpointDomainName: String = DEFAULT_STORAGE_ENDPOINT_DOMAIN_NAME,
1010
val accountName: String,
1111
val containerName: String,
1212
val sasToken: String) {
13-
fun getEndpointDomainName(): String {
14-
return endpointDomainName ?: DEFAULT_STORAGE_ENDPOINT_DOMAIN_NAME
15-
}
1613

1714
val endpointUrl: String
18-
get() = String.format(Locale.ROOT, "https://%s.%s", accountName, getEndpointDomainName())
15+
get() = String.format(Locale.ROOT, "https://%s.%s", accountName, endpointDomainName)
1916

2017
companion object {
2118
private const val DEFAULT_STORAGE_ENDPOINT_DOMAIN_NAME = "blob.core.windows.net"

airbyte-cdk/java/airbyte-cdk/azure-destinations/src/main/kotlin/io/airbyte/cdk/integrations/destination/jdbc/copy/azure/AzureBlobStorageStreamCopier.kt

+2-7
Original file line numberDiff line numberDiff line change
@@ -39,19 +39,14 @@ abstract class AzureBlobStorageStreamCopier(protected val stagingFolder: String,
3939
private val nameTransformer: StandardNameTransformer,
4040
private val sqlOperations: SqlOperations) : StreamCopier {
4141
protected var filenameGenerator: StagingFilenameGenerator = StagingFilenameGenerator(streamName, GlobalDataSizeConstants.DEFAULT_MAX_BATCH_SIZE_BYTES.toLong())
42-
protected val azureStagingFiles: MutableSet<String?> = HashSet()
42+
protected val azureStagingFiles: MutableSet<String> = HashSet()
4343

4444
@get:VisibleForTesting
4545
val tmpTableName: String = nameTransformer.getTmpTableName(streamName)
4646
protected val activeStagingWriterFileNames: MutableSet<String?> = HashSet()
4747
private val csvPrinters = HashMap<String?, CSVPrinter>()
4848
private val blobClients = HashMap<String?, AppendBlobClient>()
49-
override var currentFile: String? = null
50-
private set
51-
52-
fun getAzureStagingFiles(): Set<String?> {
53-
return azureStagingFiles
54-
}
49+
override lateinit var currentFile: String
5550

5651
@Throws(Exception::class)
5752
override fun write(id: UUID?, recordMessage: AirbyteRecordMessage?, azureFileName: String?) {

airbyte-cdk/java/airbyte-cdk/azure-destinations/src/main/kotlin/io/airbyte/cdk/integrations/destination/jdbc/copy/azure/AzureBlobStorageStreamCopierFactory.kt

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import io.airbyte.cdk.integrations.destination.jdbc.copy.StreamCopierFactory.Com
1313
import io.airbyte.protocol.models.v0.ConfiguredAirbyteStream
1414
import io.airbyte.protocol.models.v0.DestinationSyncMode
1515

16-
abstract class AzureBlobStorageStreamCopierFactory : StreamCopierFactory<AzureBlobStorageConfig?> {
16+
abstract class AzureBlobStorageStreamCopierFactory : StreamCopierFactory<AzureBlobStorageConfig> {
1717
override fun create(configuredSchema: String?,
1818
azureBlobConfig: AzureBlobStorageConfig,
1919
stagingFolder: String?,

airbyte-cdk/java/airbyte-cdk/core/src/main/kotlin/io/airbyte/cdk/integrations/destination/jdbc/copy/StreamCopier.kt

+1-1
Original file line numberDiff line numberDiff line change
@@ -65,5 +65,5 @@ interface StreamCopier {
6565
fun prepareStagingFile(): String?
6666

6767
/** @return current staging file name */
68-
val currentFile: String?
68+
val currentFile: String
6969
}

0 commit comments

Comments
 (0)