Skip to content

Commit 8714b6a

Browse files
committed
Remove obsolete yup validations for dbt Cloud jobs
Since the values are now supplied by dbt Cloud via API, the user no longer has to manually input anything; and this sudden lack of user input rather obviates the need to validate user input.
1 parent 72b601d commit 8714b6a

File tree

1 file changed

+0
-11
lines changed

1 file changed

+0
-11
lines changed

airbyte-webapp/src/pages/ConnectionPage/pages/ConnectionItemPage/ConnectionTransformationTab/DbtCloudTransformationsCard.tsx

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import { Form, Formik, FieldArray, FormikHelpers } from "formik";
55
import { ReactNode } from "react";
66
import { FormattedMessage, useIntl } from "react-intl";
77
import { Link } from "react-router-dom";
8-
import * as yup from "yup";
98

109
import { FormChangeTracker } from "components/common/FormChangeTracker";
1110
import { Button } from "components/ui/Button";
@@ -33,15 +32,6 @@ interface DbtJobListValues {
3332
jobs: DbtCloudJob[];
3433
}
3534

36-
const dbtCloudJobListSchema = yup.object({
37-
jobs: yup.array().of(
38-
yup.object({
39-
account: yup.number().required().positive().integer(),
40-
job: yup.number().required().positive().integer(),
41-
})
42-
),
43-
});
44-
4535
export const DbtCloudTransformationsCard = ({ connection }: { connection: WebBackendConnectionRead }) => {
4636
// Possible render paths:
4737
// 1) IF the workspace has no dbt cloud account linked
@@ -107,7 +97,6 @@ const DbtJobsForm: React.FC<DbtJobsFormProps> = ({ saveJobs, dbtCloudJobs }) =>
10797
<Formik
10898
onSubmit={onSubmit}
10999
initialValues={{ jobs }}
110-
validationSchema={dbtCloudJobListSchema}
111100
render={({ values, isValid, dirty }) => {
112101
return (
113102
<Form className={styles.jobListForm}>

0 commit comments

Comments
 (0)