Added dot-notation eslint rule (#16989)

* Added dot-notation eslint rule and ran --fix

* Alpha

Author: krishnaglick

airbyte-webapp/.eslintrc

@@ -22,6 +22,7 @@
     "css-modules/no-undef-class": ["error", { "camelCase": true }],
     "css-modules/no-unused-class": ["error", { "camelCase": true }],
     "dot-location": "warn",
+    "dot-notation": "warn",
     "eqeqeq": "error",
     "prettier/prettier": "warn",
     "unused-imports/no-unused-imports": "warn",

airbyte-webapp/src/components/TextWithHTML/TextWithHTML.tsx

@@ -7,7 +7,7 @@ interface IProps {
 
 const allowedAttributes = {
   ...sanitizeHtml.defaults.allowedAttributes,
-  a: [...sanitizeHtml.defaults.allowedAttributes["a"], "rel"],
+  a: [...sanitizeHtml.defaults.allowedAttributes.a, "rel"],
 };
 
 const TextWithHTML: React.FC<IProps> = ({ text }) => {

airbyte-webapp/src/components/base/DropDown/SelectContainer.tsx

@@ -13,7 +13,7 @@ export const SelectContainer: React.FC<
 > = (props) => {
   const wrapperProps = {
     "data-testid": props.selectProps["data-testid"],
-    role: props.selectProps["role"] || "combobox",
+    role: props.selectProps.role || "combobox",
   };
   return <components.SelectContainer {...props} innerProps={{ ...props.innerProps, ...wrapperProps }} />;
 };

airbyte-webapp/src/core/jsonSchema/utils.test.ts

@@ -185,7 +185,7 @@ it("apply func at", () => {
 
     sch.properties = sch.properties ?? {};
 
-    sch.properties["marked"] = {
+    sch.properties.marked = {
       type: "string",
     };
 

airbyte-webapp/src/hooks/services/Connection/ConnectionFormService.tsx

@@ -54,7 +54,7 @@ const useConnectionForm = ({
   const onFormSubmit = useCallback(
     async (values: FormikConnectionFormValues, formikHelpers: FormikHelpers<FormikConnectionFormValues>) => {
       // Set the scheduleType based on the schedule value
-      values["scheduleType"] = values.scheduleData?.basicSchedule
+      values.scheduleType = values.scheduleData?.basicSchedule
         ? ConnectionScheduleType.basic
         : ConnectionScheduleType.manual;
 

airbyte-webapp/src/views/Connection/ConnectionForm/formConfig.test.ts

@@ -24,7 +24,7 @@ describe("#useFrequencyDropdownData", () => {
     const additionalFrequency = {
       basicSchedule: {
         units: 1,
-        timeUnit: ConnectionScheduleTimeUnit["hours"],
+        timeUnit: ConnectionScheduleTimeUnit.hours,
       },
     };
     const { result } = renderHook(() => useFrequencyDropdownData(additionalFrequency), { wrapper });
@@ -35,7 +35,7 @@ describe("#useFrequencyDropdownData", () => {
     const additionalFrequency = {
       basicSchedule: {
         units: 7,
-        timeUnit: ConnectionScheduleTimeUnit["minutes"],
+        timeUnit: ConnectionScheduleTimeUnit.minutes,
       },
     };
     const { result } = renderHook(() => useFrequencyDropdownData(additionalFrequency), { wrapper });