Skip to content

Commit 7ca4490

Browse files
committed
Update spacing and alignment in stream row to match design
1 parent a418e10 commit 7ca4490

File tree

4 files changed

+29
-16
lines changed

4 files changed

+29
-16
lines changed

airbyte-webapp/src/views/Connection/CatalogDiffModal/components/DiffSection.module.scss

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,6 @@
2929
color: colors.$grey;
3030
line-height: 12px;
3131
}
32-
33-
.padLeft {
34-
padding-left: variables.$spacing-md;
35-
}
3632
}
3733

3834
.sectionHeader,

airbyte-webapp/src/views/Connection/CatalogDiffModal/components/DiffSection.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ export const DiffSection: React.FC<DiffSectionProps> = ({ streams, catalog, diff
3737
<th>
3838
<FormattedMessage id="connection.updateSchema.namespace" />
3939
</th>
40-
<th className={styles.padLeft}>
40+
<th>
4141
<FormattedMessage id="connection.updateSchema.streamName" />
4242
</th>
4343
<th />

airbyte-webapp/src/views/Connection/CatalogDiffModal/components/StreamRow.module.scss

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
flex-direction: row;
77
height: 40px;
88
align-items: center;
9-
padding: variables.$spacing-sm variables.$spacing-xl;
9+
padding: variables.$spacing-sm variables.$spacing-lg;
1010
gap: variables.$spacing-md;
1111
border-bottom: 1px solid colors.$white;
1212
width: 100%;
@@ -21,6 +21,19 @@
2121
}
2222
}
2323

24+
.content {
25+
display: flex;
26+
align-items: center;
27+
}
28+
29+
.iconContainer {
30+
width: 10px;
31+
height: 100%;
32+
display: flex;
33+
align-items: center;
34+
margin-right: variables.$spacing-lg;
35+
}
36+
2437
.icon {
2538
margin-top: -1px;
2639

@@ -49,7 +62,7 @@
4962

5063
.nameCell,
5164
%nameCell {
52-
width: 140px;
65+
width: 150px;
5366
text-align: left;
5467

5568
& .row {

airbyte-webapp/src/views/Connection/CatalogDiffModal/components/StreamRow.tsx

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -35,16 +35,20 @@ export const StreamRow: React.FC<StreamRowProps> = ({ streamTransform, syncMode,
3535
const namespace = streamTransform.streamDescriptor.namespace;
3636
return (
3737
<tr className={rowStyle}>
38-
<td>
39-
{diffVerb === "new" ? (
40-
<FontAwesomeIcon icon={faPlus} size="1x" className={iconStyle} />
41-
) : diffVerb === "removed" ? (
42-
<FontAwesomeIcon icon={faMinus} size="1x" className={iconStyle} />
43-
) : (
44-
<ModificationIcon />
45-
)}
38+
<td className={styles.nameCell}>
39+
<div className={styles.content}>
40+
<div className={styles.iconContainer}>
41+
{diffVerb === "new" ? (
42+
<FontAwesomeIcon icon={faPlus} size="1x" className={iconStyle} />
43+
) : diffVerb === "removed" ? (
44+
<FontAwesomeIcon icon={faMinus} size="1x" className={iconStyle} />
45+
) : (
46+
<ModificationIcon />
47+
)}
48+
</div>
49+
{namespace}
50+
</div>
4651
</td>
47-
<td className={styles.nameCell}>{namespace}</td>
4852
<td className={styles.nameCell}>{itemName}</td>
4953
<td>{diffVerb === "removed" && syncMode && <SyncModeBox syncModeString={syncMode} />} </td>
5054
</tr>

0 commit comments

Comments
 (0)