Skip to content

Commit 6176ecb

Browse files
Source Salesforce: fix tests (#20927)
* Source Salesforce: fix tests * Source Salesforce: update expected records * Source Salesforce: update expected records * Source Salesforce: update docs; bump version * Source Salesforce: update acceptance test reason * auto-bump connector version Co-authored-by: Octavia Squidington III <[email protected]>
1 parent f6cc98f commit 6176ecb

File tree

7 files changed

+9732
-97
lines changed

7 files changed

+9732
-97
lines changed

airbyte-config/init/src/main/resources/seed/source_definitions.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1431,7 +1431,7 @@
14311431
- name: Salesforce
14321432
sourceDefinitionId: b117307c-14b6-41aa-9422-947e34922962
14331433
dockerRepository: airbyte/source-salesforce
1434-
dockerImageTag: 1.0.27
1434+
dockerImageTag: 1.0.28
14351435
documentationUrl: https://docs.airbyte.com/integrations/sources/salesforce
14361436
icon: salesforce.svg
14371437
sourceType: api

airbyte-config/init/src/main/resources/seed/source_specs.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12857,7 +12857,7 @@
1285712857
supportsNormalization: false
1285812858
supportsDBT: false
1285912859
supported_destination_sync_modes: []
12860-
- dockerImage: "airbyte/source-salesforce:1.0.27"
12860+
- dockerImage: "airbyte/source-salesforce:1.0.28"
1286112861
spec:
1286212862
documentationUrl: "https://docs.airbyte.com/integrations/sources/salesforce"
1286312863
connectionSpecification:

airbyte-integrations/connectors/source-salesforce/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,5 @@ RUN pip install .
1313

1414
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]
1515

16-
LABEL io.airbyte.version=1.0.27
16+
LABEL io.airbyte.version=1.0.28
1717
LABEL io.airbyte.name=airbyte/source-salesforce

airbyte-integrations/connectors/source-salesforce/acceptance-test-config.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,8 @@ acceptance_tests:
3131
bypass_reason: "impossible to fill the stream with data because it is an organic traffic"
3232
- name: "ActiveScratchOrgShare"
3333
bypass_reason: "impossible to fill the stream with data because it is an organic traffic"
34+
- name: "Describe"
35+
bypass_reason: "Data is not permanent"
3436
incremental:
3537
tests:
3638
- config_path: "secrets/config.json"

airbyte-integrations/connectors/source-salesforce/integration_tests/expected_records.jsonl

Lines changed: 9725 additions & 93 deletions
Large diffs are not rendered by default.

airbyte-integrations/connectors/source-salesforce/source_salesforce/api.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -343,7 +343,7 @@ def load_schema(name: str, stream_options: Mapping[str, Any]) -> Tuple[str, Opti
343343
stream_schemas = {}
344344
for i in range(0, len(stream_names), self.parallel_tasks_size):
345345
chunk_stream_names = stream_names[i : i + self.parallel_tasks_size]
346-
with concurrent.futures.ThreadPoolExecutor(max_workers=len(chunk_stream_names)) as executor:
346+
with concurrent.futures.ThreadPoolExecutor() as executor:
347347
for stream_name, schema, err in executor.map(
348348
lambda args: load_schema(*args), [(stream_name, stream_objects[stream_name]) for stream_name in chunk_stream_names]
349349
):

docs/integrations/sources/salesforce.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,7 @@ Now that you have set up the Salesforce source connector, check out the followin
129129

130130
| Version | Date | Pull Request | Subject |
131131
|:--------|:-----------|:---------------------------------------------------------|:---------------------------------------------------------------------------------------------------------------------------------|
132+
| 1.0.28 | 2022-12-29 | [20927](https://github.com/airbytehq/airbyte/pull/20927) | Fix tests; add expected records |
132133
| 1.0.27 | 2022-11-29 | [19869](https://github.com/airbytehq/airbyte/pull/19869) | Remove `AccountHistory` from unsupported BULK streams |
133134
| 1.0.26 | 2022-11-15 | [19286](https://github.com/airbytehq/airbyte/pull/19286) | Bugfix: fallback to REST API if entity is not supported by BULK API |
134135
| 1.0.25 | 2022-11-13 | [19294](https://github.com/airbytehq/airbyte/pull/19294) | Use the correct encoding for non UTF-8 objects and data |

0 commit comments

Comments
 (0)