Skip to content

Commit 59eacee

Browse files
committed
Merge branch 'guillaume-chech/mixpanel-source-export-parsing' of github.com:guillaume-chech/airbyte into marcos/test-pr-11318
2 parents a203d68 + d377171 commit 59eacee

File tree

1 file changed

+3
-2
lines changed
  • airbyte-integrations/connectors/source-mixpanel/source_mixpanel

1 file changed

+3
-2
lines changed

airbyte-integrations/connectors/source-mixpanel/source_mixpanel/source.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -704,7 +704,7 @@ def path(self, **kwargs) -> str:
704704
return "export"
705705

706706
def process_response(self, response: requests.Response, **kwargs) -> Iterable[Mapping]:
707-
"""Export API return response.text in JSONL format but each line is a valid JSON object
707+
"""Export API return response in JSONL format but each line is a valid JSON object
708708
Raw item example:
709709
{
710710
"event": "Viewed E-commerce Page",
@@ -727,7 +727,8 @@ def process_response(self, response: requests.Response, **kwargs) -> Iterable[Ma
727727
self.logger.warn(f"Couldn't fetch data from Export API. Response: {response.text}")
728728
return []
729729

730-
for record_line in response.text.splitlines():
730+
# We prefer response.iter_lines() to response.text.split_lines() as the later can missparse text properties embeding linebreaks
731+
for record_line in response.iter_lines():
731732
record = json.loads(record_line)
732733
# transform record into flat dict structure
733734
item = {"event": record["event"]}

0 commit comments

Comments
 (0)