Skip to content

Commit 598d4e3

Browse files
Source Facebook Marketing: fix OC 1040 (#20736)
* Source Facebook Marketing: fix OC 1040 * Source Facebook Marketing: docs update; bump version * auto-bump connector version Co-authored-by: Octavia Squidington III <[email protected]>
1 parent 3a9dd2f commit 598d4e3

File tree

5 files changed

+5
-4
lines changed

5 files changed

+5
-4
lines changed

airbyte-config/init/src/main/resources/seed/source_definitions.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -451,7 +451,7 @@
451451
- name: Facebook Marketing
452452
sourceDefinitionId: e7778cfc-e97c-4458-9ecb-b4f2bba8946c
453453
dockerRepository: airbyte/source-facebook-marketing
454-
dockerImageTag: 0.2.79
454+
dockerImageTag: 0.2.80
455455
documentationUrl: https://docs.airbyte.com/integrations/sources/facebook-marketing
456456
icon: facebook.svg
457457
sourceType: api

airbyte-config/init/src/main/resources/seed/source_specs.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3474,7 +3474,7 @@
34743474
supportsNormalization: false
34753475
supportsDBT: false
34763476
supported_destination_sync_modes: []
3477-
- dockerImage: "airbyte/source-facebook-marketing:0.2.79"
3477+
- dockerImage: "airbyte/source-facebook-marketing:0.2.80"
34783478
spec:
34793479
documentationUrl: "https://docs.airbyte.com/integrations/sources/facebook-marketing"
34803480
changelogUrl: "https://docs.airbyte.com/integrations/sources/facebook-marketing"

airbyte-integrations/connectors/source-facebook-marketing/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,5 @@ ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
1313
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]
1414

1515

16-
LABEL io.airbyte.version=0.2.79
16+
LABEL io.airbyte.version=0.2.80
1717
LABEL io.airbyte.name=airbyte/source-facebook-marketing

airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/streams/base_insight_streams.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,6 @@ def read_records(
119119
) -> Iterable[Mapping[str, Any]]:
120120
"""Waits for current job to finish (slice) and yield its result"""
121121
job = stream_slice["insight_job"]
122-
self._next_cursor_value = self._get_start_date()
123122
try:
124123
for obj in job.get_result():
125124
yield obj.export_all_data()
@@ -197,6 +196,7 @@ def _generate_async_jobs(self, params: Mapping) -> Iterator[AsyncJob]:
197196
:return:
198197
"""
199198

199+
self._next_cursor_value = self._get_start_date()
200200
for ts_start in self._date_intervals():
201201
if ts_start in self._completed_slices:
202202
continue

docs/integrations/sources/facebook-marketing.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,7 @@ Please be informed that the connector uses the `lookback_window` parameter to pe
131131

132132
| Version | Date | Pull Request | Subject |
133133
|:--------|:-----------|:---------------------------------------------------------|:--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
134+
| 0.2.80 | 2022-12-21 | [20736](https://github.com/airbytehq/airbyte/pull/20736) | Fix update next cursor |
134135
| 0.2.79 | 2022-12-07 | [20402](https://github.com/airbytehq/airbyte/pull/20402) | Exclude Not supported fields from request |
135136
| 0.2.78 | 2022-12-07 | [20165](https://github.com/airbytehq/airbyte/pull/20165) | fix fields permission error |
136137
| 0.2.77 | 2022-12-06 | [20131](https://github.com/airbytehq/airbyte/pull/20131) | update next cursor value at read start |

0 commit comments

Comments
 (0)