|
13 | 13 | Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed. |
14 | 14 |
|
15 | 15 | ## Pre-merge Checklist |
16 | | -Expand the relevant checklist and delete the others. |
| 16 | +Expand the relevant checklist and delete the others. |
17 | 17 |
|
18 | | -<details><summary> <strong> New Connector </strong></summary> |
19 | | -<p> |
| 18 | +<details><summary><strong>New Connector</strong></summary> |
| 19 | + |
| 20 | +### Community member or Airbyter |
20 | 21 |
|
21 | | -#### Community member or Airbyter |
22 | | - |
23 | 22 | - [ ] **Community member?** Grant edit access to maintainers ([instructions](https://docs.github.com/en/github/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests)) |
24 | | -- [ ] Secrets in the connector's spec are annotated with `airbyte_secret` |
| 23 | +- [ ] Secrets in the connector's spec are annotated with `airbyte_secret` |
25 | 24 | - [ ] Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run `./gradlew :airbyte-integrations:connectors:<name>:integrationTest`. |
26 | 25 | - [ ] Code reviews completed |
27 | | -- [ ] Documentation updated |
| 26 | +- [ ] Documentation updated |
28 | 27 | - [ ] Connector's `README.md` |
29 | 28 | - [ ] Connector's `bootstrap.md`. See [description and examples](https://docs.google.com/document/d/1ypdgmwmEHWv-TrO4_YOQ7pAJGVrMp5BOkEVh831N260/edit?usp=sharing) |
30 | 29 | - [ ] `docs/SUMMARY.md` |
31 | 30 | - [ ] `docs/integrations/<source or destination>/<name>.md` including changelog. See changelog [example](https://docs.airbyte.io/integrations/sources/stripe#changelog) |
32 | 31 | - [ ] `docs/integrations/README.md` |
33 | 32 | - [ ] `airbyte-integrations/builds.md` |
34 | 33 | - [ ] PR name follows [PR naming conventions](https://docs.airbyte.io/contributing-to-airbyte/updating-documentation#issues-and-pull-requests) |
35 | | - |
36 | | -#### Airbyter |
37 | 34 |
|
38 | | -If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items. |
39 | | - |
| 35 | +### Airbyter |
| 36 | + |
| 37 | +If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items. |
| 38 | + |
40 | 39 | - [ ] Create a non-forked branch based on this PR and test the below items on it |
41 | 40 | - [ ] Build is successful |
42 | | -- [ ] Credentials added to Github CI. [Instructions](https://docs.airbyte.io/connector-development#using-credentials-in-ci). |
43 | | -- [ ] [`/test connector=connectors/<name>` command](https://docs.airbyte.io/connector-development#updating-an-existing-connector) is passing. |
| 41 | +- [ ] Credentials added to Github CI. [Instructions](https://docs.airbyte.io/connector-development#using-credentials-in-ci). |
| 42 | +- [ ] [`/test connector=connectors/<name>` command](https://docs.airbyte.io/connector-development#updating-an-existing-connector) is passing |
44 | 43 | - [ ] New Connector version released on Dockerhub by running the `/publish` command described [here](https://docs.airbyte.io/connector-development#updating-an-existing-connector) |
45 | 44 | - [ ] After the connector is published, connector added to connector index as described [here](https://docs.airbyte.io/connector-development#publishing-a-connector) |
46 | 45 | - [ ] Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described [here](https://docs.airbyte.io/connector-development#publishing-a-connector) |
47 | | - |
48 | | -</p> |
| 46 | + |
49 | 47 | </details> |
50 | 48 |
|
| 49 | +<details><summary><strong>Updating a connector</strong></summary> |
| 50 | + |
| 51 | +### Community member or Airbyter |
51 | 52 |
|
52 | | -<details><summary> <strong> Updating a connector </strong></summary> |
53 | | -<p> |
54 | | - |
55 | | -#### Community member or Airbyter |
56 | | - |
57 | 53 | - [ ] Grant edit access to maintainers ([instructions](https://docs.github.com/en/github/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests)) |
58 | | -- [ ] Secrets in the connector's spec are annotated with `airbyte_secret` |
| 54 | +- [ ] Secrets in the connector's spec are annotated with `airbyte_secret` |
59 | 55 | - [ ] Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run `./gradlew :airbyte-integrations:connectors:<name>:integrationTest`. |
60 | 56 | - [ ] Code reviews completed |
61 | | -- [ ] Documentation updated |
| 57 | +- [ ] Documentation updated |
62 | 58 | - [ ] Connector's `README.md` |
63 | 59 | - [ ] Connector's `bootstrap.md`. See [description and examples](https://docs.google.com/document/d/1ypdgmwmEHWv-TrO4_YOQ7pAJGVrMp5BOkEVh831N260/edit?usp=sharing) |
64 | 60 | - [ ] Changelog updated in `docs/integrations/<source or destination>/<name>.md` including changelog. See changelog [example](https://docs.airbyte.io/integrations/sources/stripe#changelog) |
65 | 61 | - [ ] PR name follows [PR naming conventions](https://docs.airbyte.io/contributing-to-airbyte/updating-documentation#issues-and-pull-requests) |
66 | | - |
67 | | -#### Airbyter |
68 | 62 |
|
69 | | -If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items. |
70 | | - |
| 63 | +### Airbyter |
| 64 | + |
| 65 | +If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items. |
| 66 | + |
71 | 67 | - [ ] Create a non-forked branch based on this PR and test the below items on it |
72 | 68 | - [ ] Build is successful |
73 | | -- [ ] Credentials added to Github CI. [Instructions](https://docs.airbyte.io/connector-development#using-credentials-in-ci). |
74 | | -- [ ] [`/test connector=connectors/<name>` command](https://docs.airbyte.io/connector-development#updating-an-existing-connector) is passing. |
| 69 | +- [ ] Credentials added to Github CI. [Instructions](https://docs.airbyte.io/connector-development#using-credentials-in-ci). |
| 70 | +- [ ] [`/test connector=connectors/<name>` command](https://docs.airbyte.io/connector-development#updating-an-existing-connector) is passing |
75 | 71 | - [ ] New Connector version released on Dockerhub by running the `/publish` command described [here](https://docs.airbyte.io/connector-development#updating-an-existing-connector) |
76 | 72 | - [ ] After the new connector version is published, connector version bumped in the seed directory as described [here](https://docs.airbyte.io/connector-development#publishing-a-connector) |
77 | 73 | - [ ] Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described [here](https://docs.airbyte.io/connector-development#publishing-a-connector) |
78 | 74 |
|
79 | | -</p> |
80 | 75 | </details> |
81 | 76 |
|
82 | | -<details><summary> <strong> Connector Generator </strong> </summary> |
83 | | -<p> |
84 | | - |
| 77 | +<details><summary><strong>Connector Generator</strong></summary> |
| 78 | + |
85 | 79 | - [ ] Issue acceptance criteria met |
86 | 80 | - [ ] PR name follows [PR naming conventions](https://docs.airbyte.io/contributing-to-airbyte/updating-documentation#issues-and-pull-requests) |
87 | 81 | - [ ] If adding a new generator, add it to the [list of scaffold modules being tested](https://github.com/airbytehq/airbyte/blob/master/airbyte-integrations/connector-templates/generator/build.gradle#L41) |
88 | 82 | - [ ] The generator test modules (all connectors with `-scaffold` in their name) have been updated with the latest scaffold by running `./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates` then checking in your changes |
89 | | -- [ ] Documentation which references the generator is updated as needed. |
90 | | -</p> |
| 83 | +- [ ] Documentation which references the generator is updated as needed |
| 84 | + |
91 | 85 | </details> |
0 commit comments