Skip to content

Commit 5629bb9

Browse files
authored
CI: fix missing slash command input args (#37564)
1 parent e172376 commit 5629bb9

5 files changed

+47
-15
lines changed

.github/workflows/connector-performance-command.yml

+5
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,11 @@ on:
8383
description: "Whether to report the performance test results to Datadog."
8484
required: false
8585
default: "false"
86+
pr:
87+
description: "PR Number (Unused)"
88+
type: number
89+
required: false
90+
8691
jobs:
8792
uuid:
8893
name: "Custom UUID of workflow run"

.github/workflows/format-fix-command.yml

+29-15
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,22 @@ on:
55
inputs:
66
pr:
77
description: "Pull request number. Used to pull the proper branch ref, including on forks."
8+
type: number
89
required: false
910
comment-id:
1011
description: "Optional. The comment-id of the slash command. Used to update the comment with the status."
1112
required: false
1213

14+
# These must be declared, but they are unused and ignored.
15+
# TODO: Get 'repo' and 'gitref' from the PR on other workflows, so we can remove these.
16+
repo:
17+
description: "Repo (Ignored)"
18+
required: false
19+
default: "airbytehq/airbyte"
20+
gitref:
21+
description: "Ref (Ignored)"
22+
required: false
23+
1324
run-name: "Fix formatting on PR #${{ github.event.inputs.pr }}"
1425
concurrency:
1526
group: ${{ github.workflow }}-${{ github.event.inputs.pr }}
@@ -21,30 +32,32 @@ jobs:
2132
name: "Run airbyte-ci format fix all"
2233
runs-on: ubuntu-latest
2334
steps:
24-
- name: Checkout Airbyte
25-
uses: actions/checkout@v3
26-
with:
27-
# Important that this is set so that CI checks are triggered again
28-
# Without this we would be forever waiting on required checks to pass
29-
token: ${{ secrets.GH_PAT_APPROVINGTON_OCTAVIA }}
30-
fetch-depth: 1
31-
32-
- name: Checkout PR (${{ github.event.inputs.pr }})
33-
uses: dawidd6/action-checkout-pr@v1
34-
with:
35-
pr: ${{ github.event.inputs.pr }}
36-
3735
- name: Get job variables
3836
id: job-vars
3937
env:
4038
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
4139
shell: bash
4240
run: |
4341
PR_JSON=$(gh api repos/${{ github.repository }}/pulls/${{ github.event.inputs.pr }})
44-
echo "::set-output name=repo::$(echo "$PR_JSON" | jq -r .head.repo.full_name)"
45-
echo "::set-output name=branch::$(echo "$PR_JSON" | jq -r .head.ref)"
42+
echo "repo=$(echo "$PR_JSON" | jq -r .head.repo.full_name)" >> $GITHUB_OUTPUT
43+
echo "branch=$(echo "$PR_JSON" | jq -r .head.ref)" >> $GITHUB_OUTPUT
4644
echo "run-url=https://github.com/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID" >> $GITHUB_OUTPUT
4745
46+
- name: Checkout Airbyte
47+
uses: actions/checkout@v3
48+
with:
49+
repository: ${{ steps.job-vars.outputs.repo }}
50+
ref: ${{ steps.job-vars.outputs.branch }}
51+
fetch-depth: 1
52+
# Important that token is a PAT so that CI checks are triggered again.
53+
# Without this we would be forever waiting on required checks to pass.
54+
token: ${{ secrets.GH_PAT_APPROVINGTON_OCTAVIA }}
55+
56+
# - name: Checkout PR (${{ github.event.inputs.pr }})
57+
# uses: dawidd6/action-checkout-pr@v1
58+
# with:
59+
# pr: ${{ github.event.inputs.pr }}
60+
4861
- name: Append comment with job run link
4962
# If not comment-id is provided, this will create a new
5063
# comment with the job run link.
@@ -82,6 +95,7 @@ jobs:
8295
# Don't commit if we're on master
8396
if: github.ref != 'refs/heads/master'
8497
with:
98+
repository: ${{ steps.job-vars.outputs.repo }}
8599
commit_message: "chore: format code"
86100
commit_user_name: Octavia Squidington III
87101
commit_user_email: [email protected]

.github/workflows/publish-java-cdk-command.yml

+4
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,10 @@ on:
4040
comment-id:
4141
description: "Optional comment-id of the slash command. Ignore if not applicable."
4242
required: false
43+
pr:
44+
description: "PR Number (Unused)"
45+
type: number
46+
required: false
4347

4448
concurrency:
4549
group: publish-java-cdk

.github/workflows/test-command.yml

+5
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,11 @@ on:
2626
local_cdk:
2727
description: "Run Connector Acceptance Tests against the CDK version on the current branch."
2828
required: false
29+
pr:
30+
description: "PR Number (Unused)"
31+
type: number
32+
required: false
33+
2934
jobs:
3035
write-deprecation-message:
3136
runs-on: ubuntu-latest

.github/workflows/test-performance-command.yml

+4
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,10 @@ on:
2424
memorylimit:
2525
description: "Memory CPU limit"
2626
required: false
27+
pr:
28+
description: "PR Number (Unused)"
29+
type: number
30+
required: false
2731

2832
jobs:
2933
start-test-runner:

0 commit comments

Comments
 (0)